From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D6C2C433DF for ; Wed, 12 Aug 2020 12:16:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1F7E8207DA for ; Wed, 12 Aug 2020 12:16:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727822AbgHLMQq (ORCPT ); Wed, 12 Aug 2020 08:16:46 -0400 Received: from out30-133.freemail.mail.aliyun.com ([115.124.30.133]:39239 "EHLO out30-133.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726829AbgHLMQp (ORCPT ); Wed, 12 Aug 2020 08:16:45 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R751e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e07484;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=19;SR=0;TI=SMTPD_---0U5ZBL.H_1597234598; Received: from IT-FVFX43SYHV2H.local(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0U5ZBL.H_1597234598) by smtp.aliyun-inc.com(127.0.0.1); Wed, 12 Aug 2020 20:16:39 +0800 Subject: Re: [PATCH v17 14/21] mm/compaction: do page isolation first in compaction From: Alex Shi To: Alexander Duyck Cc: Andrew Morton , Mel Gorman , Tejun Heo , Hugh Dickins , Konstantin Khlebnikov , Daniel Jordan , Yang Shi , Matthew Wilcox , Johannes Weiner , kbuild test robot , linux-mm , LKML , cgroups@vger.kernel.org, Shakeel Butt , Joonsoo Kim , Wei Yang , "Kirill A. Shutemov" , Rong Chen References: <1595681998-19193-1-git-send-email-alex.shi@linux.alibaba.com> <1595681998-19193-15-git-send-email-alex.shi@linux.alibaba.com> <241ca157-104f-4f0d-7d5b-de394443788d@linux.alibaba.com> <8dbd004e-8eba-f1ec-a5eb-5dc551978936@linux.alibaba.com> <9581db48-cef3-788a-7f5a-8548fee56c13@linux.alibaba.com> Message-ID: <51249892-632b-4aaf-1f66-3bc0d5c5cbab@linux.alibaba.com> Date: Wed, 12 Aug 2020 20:16:06 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <9581db48-cef3-788a-7f5a-8548fee56c13@linux.alibaba.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2020/8/12 下午7:43, Alex Shi 写道: >>> Sorry, I still can not follow you here. Compound code part is unchanged >>> and follow the original logical. So would you like to pose a new code to >>> see if its works? >> No there are significant changes as you reordered all of the >> operations. Prior to your change the LRU bit was checked, but not >> cleared before testing for PageCompound. Now you are clearing it >> before you are testing if it is a compound page. So if compaction is >> running we will be seeing the pages in the LRU stay put, but the >> compound bit flickering off and on if the compound page is encountered >> with the wrong or NULL lruvec. What I was suggesting is that the > The lruvec could be wrong or NULL here, that is the base stone of whole > patchset. > Sorry for typo. s/could/could not/ From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Shi Subject: Re: [PATCH v17 14/21] mm/compaction: do page isolation first in compaction Date: Wed, 12 Aug 2020 20:16:06 +0800 Message-ID: <51249892-632b-4aaf-1f66-3bc0d5c5cbab@linux.alibaba.com> References: <1595681998-19193-1-git-send-email-alex.shi@linux.alibaba.com> <1595681998-19193-15-git-send-email-alex.shi@linux.alibaba.com> <241ca157-104f-4f0d-7d5b-de394443788d@linux.alibaba.com> <8dbd004e-8eba-f1ec-a5eb-5dc551978936@linux.alibaba.com> <9581db48-cef3-788a-7f5a-8548fee56c13@linux.alibaba.com> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <9581db48-cef3-788a-7f5a-8548fee56c13-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="utf-8" To: Alexander Duyck Cc: Andrew Morton , Mel Gorman , Tejun Heo , Hugh Dickins , Konstantin Khlebnikov , Daniel Jordan , Yang Shi , Matthew Wilcox , Johannes Weiner , kbuild test robot , linux-mm , LKML , cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Shakeel Butt , Joonsoo Kim , Wei Yang , "Kirill A. Shutemov" , Rong Chen 在 2020/8/12 下午7:43, Alex Shi 写道: >>> Sorry, I still can not follow you here. Compound code part is unchanged >>> and follow the original logical. So would you like to pose a new code to >>> see if its works? >> No there are significant changes as you reordered all of the >> operations. Prior to your change the LRU bit was checked, but not >> cleared before testing for PageCompound. Now you are clearing it >> before you are testing if it is a compound page. So if compaction is >> running we will be seeing the pages in the LRU stay put, but the >> compound bit flickering off and on if the compound page is encountered >> with the wrong or NULL lruvec. What I was suggesting is that the > The lruvec could be wrong or NULL here, that is the base stone of whole > patchset. > Sorry for typo. s/could/could not/