Re: [PATCH v10 2/3] ARM: dts: Add FIMD node and display timing node to exynos4412-origen.dts

[Sylwester Nawrocki <sylvester.nawrocki@gmail.com>]

On 04/01/2013 04:22 PM, Vikas Sajjan wrote:
> This patch adds FIMD related nodes for the Origen Quad board.
>
> Signed-off-by: Vikas Sajjan<vikas.sajjan@linaro.org>
> ---
>   arch/arm/boot/dts/exynos4412-origen.dts |   21 +++++++++++++++++++++
>   1 file changed, 21 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4412-origen.dts b/arch/arm/boot/dts/exynos4412-origen.dts
> index a5478bd..cb0c507 100644
> --- a/arch/arm/boot/dts/exynos4412-origen.dts
> +++ b/arch/arm/boot/dts/exynos4412-origen.dts
> @@ -70,6 +70,27 @@
>   		status = "okay";
>   	};
>
> +	fimd@11c00000 {
> +		pinctrl-0 =<&lcd_clk&lcd_data24&pwm1_out>;
> +		pinctrl-names = "default";
> +		status = "okay";
> +	};
> +
> +	display-timings {
> +		native-mode =<&timing0>;
> +		timing0: timing@0 {

I think you could leave out '@0' part, since there is only one node.
And if you decide to keep it, then this node should contain 'reg'
property AFAICT.

Otherwise the series looks good to me. With the above issue addressed
feel free to add

Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>

> +			clock-frequency =<50000>;
> +			hactive =<1024>;
> +			vactive =<600>;
> +			hfront-porch =<64>;
> +			hback-porch =<16>;
> +			hsync-len =<48>;
> +			vback-porch =<64>;
> +			vfront-porch =<16>;
> +			vsync-len =<3>;
> +		};
> +	};
> +
>   	serial@13800000 {
>   		status = "okay";
>   	};

Thanks,
Sylwester