From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762922Ab3DCR5d (ORCPT ); Wed, 3 Apr 2013 13:57:33 -0400 Received: from mail-da0-f53.google.com ([209.85.210.53]:33438 "EHLO mail-da0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760080Ab3DCR5c (ORCPT ); Wed, 3 Apr 2013 13:57:32 -0400 Message-ID: <515C6D87.2060106@linaro.org> Date: Wed, 03 Apr 2013 10:57:27 -0700 From: John Stultz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130308 Thunderbird/17.0.4 MIME-Version: 1.0 To: Stephane Eranian CC: David Ahern , Pawel Moll , Peter Zijlstra , Thomas Gleixner , LKML , "mingo@elte.hu" , Paul Mackerras , Anton Blanchard , Will Deacon , "ak@linux.intel.com" , Pekka Enberg , Steven Rostedt Subject: Re: [RFC] perf: need to expose sched_clock to correlate user samples with kernel samples References: <1350408232.2336.42.camel@laptop> <1359728280.8360.15.camel@hornet> <51118797.9080800@linaro.org> <5123C3AF.8060100@linaro.org> <1361356160.10155.22.camel@laptop> <51285BF1.2090208@linaro.org> <1361801441.4007.40.camel@laptop> <1363291021.3100.144.camel@hornet> <51586315.7080006@gmail.com> <5159D221.70304@linaro.org> <515A0A3A.2040105@gmail.com> <515C34BF.6060508@gmail.com> <515C393C.8030405@gmail.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/03/2013 07:22 AM, Stephane Eranian wrote: > On Wed, Apr 3, 2013 at 4:14 PM, David Ahern wrote: >> On 4/3/13 8:00 AM, Stephane Eranian wrote: >>>> Why not have perf convert its >>>> perf_clock timestamps into monotonic or realtime when dumping events? So this is exactly what I've been wondering through all this. Perf can keep track of events using its own time domain (which is understandably required due to performance and locking issues), but when exporting those timestamps to userland, could it not do the same (likely imperfect) conversion to existing userland time domains (like CLOCK_MONOTONIC)? >>> Can monotonic timestamps be obtained from NMI context in the kernel? >> >> I don't understand the context of the question. >> >> I am not suggesting perf_clock be changed. I am working on correlating >> existing perf_clock timestamps to clocks typically used by apps (REALTIME >> and time-of-day but also applies to MONOTONIC). >> > But for that, you'd need to expose to users the correlation between > the two clocks. > And now you'd fixed two clock sources definitions not just one. I'm not sure I follow this. If perf exported data came with CLOCK_MONOTONIC timestamps, no correlation would need to be exposed. perf would just have to do the extra overhead of doing the conversion on export. >> You are wanting the reverse -- have apps emit perf_clock timestamps. I was >> just wondering what is the advantage of this approach? >> > Well, that's how I interpreted your question ;-< > > If you could have perf_clock use monotonic then we would not have this > discussion. > The correlation would be trivial. I think the suggestion is not to have the perf_clock use CLOCK_MONOTONIC, but the perf interfaces export CLOCK_MONOTONIC. thanks -john