All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
	linux-kernel@vger.kernel.org,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Jiri Olsa <jolsa@redhat.com>, Mike Galbraith <efault@gmx.de>,
	Namhyung Kim <namhyung@gmail.com>,
	Paul Mackerras <paulus@samba.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH V2 12/15] perf tools: allow non-matching sample types
Date: Mon, 01 Jul 2013 12:53:55 -0600	[thread overview]
Message-ID: <51D1D043.5030509@gmail.com> (raw)
In-Reply-To: <51D14CB6.206@intel.com>

On 7/1/13 3:32 AM, Adrian Hunter wrote:
> Snip
>
>>
>> While this works for a combined S/W and tracepoint events session, I do not
>> like promoting sample types to the minimum compatible level for all events
>> in the session. perf needs to allow each event to have its own sample_type
>> and not force a minimal compatibility.
>
> Why?  The impact is small. The kernel API is completely unchanged.

I'd like to see libperf become a stable, usable library - usable by more 
than the perf binary and its builtin commands. I have already done this 
once for a daemon, and it was a PITA to get the specific use functional 
without memory leaks/growth in the libperf part.

With respect to this specific patch it means appropriate flexibility in 
the data collected for events. ie., each event can have its own 
sample_type. For example if the tracepoint already contains task 
information TID is not needed - and IP may not be wanted either. The 
code processing the samples should not require all events to have some 
minimum data format - that just wastes buffer space.

David


  reply	other threads:[~2013-07-01 18:54 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-27  7:54 [PATCH V2 00/15] perf tools: some fixes and tweaks Adrian Hunter
2013-06-27  7:54 ` [PATCH V2 01/15] perf tools: remove unused parameter Adrian Hunter
2013-06-27  7:54 ` [PATCH V2 02/15] perf tools: fix missing tool parameter Adrian Hunter
2013-06-27  7:54 ` [PATCH V2 03/15] perf tools: fix missing 'finished_round' Adrian Hunter
2013-06-27  7:54 ` [PATCH V2 04/15] perf tools: fix parse_events_terms() segfault on error path Adrian Hunter
2013-06-27  7:54 ` [PATCH V2 05/15] perf tools: fix new_term() missing free " Adrian Hunter
2013-06-27  7:54 ` [PATCH V2 06/15] perf tools: fix parse_events_terms() freeing local variable " Adrian Hunter
2013-06-27 16:13   ` David Ahern
2013-06-28  6:32     ` Adrian Hunter
2013-06-28 13:41       ` David Ahern
2013-06-28 13:57         ` Jiri Olsa
2013-06-27  7:54 ` [PATCH V2 07/15] perf tools: add const specifier to perf_pmu__find name parameter Adrian Hunter
2013-06-27  7:55 ` [PATCH V2 08/15] perf tools: tidy duplicated munmap code Adrian Hunter
2013-06-27  7:55 ` [PATCH V2 09/15] perf tools: validate perf event header size Adrian Hunter
2013-06-27  7:55 ` [PATCH V2 10/15] perf tools: add debug prints Adrian Hunter
2013-06-27  7:55 ` [PATCH V2 11/15] perf tools: fix symbol_conf.nr_events Adrian Hunter
2013-06-27  7:55 ` [PATCH V2 12/15] perf tools: allow non-matching sample types Adrian Hunter
2013-06-27 16:39   ` David Ahern
2013-07-01  9:32     ` Adrian Hunter
2013-07-01 18:53       ` David Ahern [this message]
2013-07-01 19:10         ` Stephane Eranian
2013-07-02  6:58           ` Adrian Hunter
2013-07-03  6:40             ` Stephane Eranian
2013-07-02  7:09         ` Adrian Hunter
2013-07-03  6:44           ` Stephane Eranian
2013-08-26 18:54             ` Arnaldo Carvalho de Melo
2013-06-27  7:55 ` [PATCH V2 13/15] perf tools: struct thread has a tid not a pid Adrian Hunter
2013-06-27  7:55 ` [PATCH V2 14/15] perf tools: add pid to struct thread Adrian Hunter
2013-06-27 16:52   ` David Ahern
2013-06-27  7:55 ` [PATCH V2 15/15] perf tools: fix ppid in thread__fork() Adrian Hunter
2013-06-27 16:57   ` David Ahern
2013-06-28  6:47     ` Adrian Hunter
2013-06-28 13:46       ` David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51D1D043.5030509@gmail.com \
    --to=dsahern@gmail.com \
    --cc=acme@ghostprotocols.net \
    --cc=adrian.hunter@intel.com \
    --cc=efault@gmx.de \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namhyung@gmail.com \
    --cc=paulus@samba.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.