All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: Gleb Natapov <gleb@redhat.com>, James Hogan <james.hogan@imgtec.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH] kvm: sync cpu state on internal error before dump
Date: Sat, 24 Aug 2013 19:28:44 +0200	[thread overview]
Message-ID: <5218ED4C.8060201@suse.de> (raw)
In-Reply-To: <20130824103729.GF15513@redhat.com>

Am 24.08.2013 12:37, schrieb Gleb Natapov:
> On Fri, Aug 23, 2013 at 02:41:13PM +0100, James Hogan wrote:
>> On 23/08/13 13:58, Gleb Natapov wrote:
>>> On Fri, Aug 23, 2013 at 01:26:00PM +0100, James Hogan wrote:
>>>> When a KVM internal error occurs QEMU dumps the CPU state, however it
>>>> doesn't synchronise the state from KVM first so the dumped state is out
>>>> of date. Add the synchronisation calls before the dump in both locations
>>>> (which is used depends on whether the arch says to stop or not).
>>>>
>>> x86_cpu_dump_state() calls cpu_synchronize_state() already.
>>
>> Ah yes, thanks. I hadn't noticed that.
>>
>> Out of the arches that support KVM only x86 and ppc call it. arm, mips
>> (qemu support not upstream yet), and s390 don't. s390 never seems to
>> emit that exit code, and arm only does so for unsupported exceptions
>> (which should never happen).
>>
>> I'll fix in mips_cpu_dump_state() instead.
>>
> Moving cpu_synchronize_state() up to cpu_dump_state() would be better.

Yes, please. I did not review the hooks themselves much, just avoided
global functions.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

      reply	other threads:[~2013-08-24 17:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-23 12:26 [PATCH] kvm: sync cpu state on internal error before dump James Hogan
2013-08-23 12:26 ` [Qemu-devel] " James Hogan
2013-08-23 12:58 ` Gleb Natapov
2013-08-23 12:58   ` [Qemu-devel] " Gleb Natapov
2013-08-23 13:41   ` James Hogan
2013-08-23 13:41     ` [Qemu-devel] " James Hogan
2013-08-24 10:37     ` Gleb Natapov
2013-08-24 10:37       ` [Qemu-devel] " Gleb Natapov
2013-08-24 17:28       ` Andreas Färber [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5218ED4C.8060201@suse.de \
    --to=afaerber@suse.de \
    --cc=gleb@redhat.com \
    --cc=james.hogan@imgtec.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.