From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Salter Date: Mon, 18 May 2020 18:20:42 +0000 Subject: Re: [PATCH 10/29] c6x: use asm-generic/cacheflush.h Message-Id: <5260142047d0339e00d4a74865c2f0b7511c89f6.camel@redhat.com> List-Id: References: <20200515143646.3857579-1-hch@lst.de> <20200515143646.3857579-11-hch@lst.de> In-Reply-To: <20200515143646.3857579-11-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christoph Hellwig , Andrew Morton , Arnd Bergmann , Roman Zippel Cc: linux-arch@vger.kernel.org, linux-xtensa@linux-xtensa.org, Michal Simek , Jessica Yu , linux-ia64@vger.kernel.org, linux-c6x-dev@linux-c6x.org, linux-sh@vger.kernel.org, linux-hexagon@vger.kernel.org, x86@kernel.org, linux-um@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-m68k@lists.linux-m68k.org, openrisc@lists.librecores.org, linux-alpha@vger.kernel.org, sparclinux@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org On Fri, 2020-05-15 at 16:36 +0200, Christoph Hellwig wrote: > C6x needs almost no cache flushing routines of its own. Rely on > asm-generic/cacheflush.h for the defaults. > > Signed-off-by: Christoph Hellwig > --- > arch/c6x/include/asm/cacheflush.h | 19 +------------------ > 1 file changed, 1 insertion(+), 18 deletions(-) > > diff --git a/arch/c6x/include/asm/cacheflush.h b/arch/c6x/include/asm/cacheflush.h > index 4540b40475e6c..10922d528de6d 100644 > --- a/arch/c6x/include/asm/cacheflush.h > +++ b/arch/c6x/include/asm/cacheflush.h > @@ -16,21 +16,6 @@ > #include > #include > > -/* > - * virtually-indexed cache management (our cache is physically indexed) > - */ > -#define flush_cache_all() do {} while (0) > -#define flush_cache_mm(mm) do {} while (0) > -#define flush_cache_dup_mm(mm) do {} while (0) > -#define flush_cache_range(mm, start, end) do {} while (0) > -#define flush_cache_page(vma, vmaddr, pfn) do {} while (0) > -#define flush_cache_vmap(start, end) do {} while (0) > -#define flush_cache_vunmap(start, end) do {} while (0) > -#define ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE 0 > -#define flush_dcache_page(page) do {} while (0) > -#define flush_dcache_mmap_lock(mapping) do {} while (0) > -#define flush_dcache_mmap_unlock(mapping) do {} while (0) > - > /* > * physically-indexed cache management > */ > @@ -49,14 +34,12 @@ do { \ > (unsigned long) page_address(page) + PAGE_SIZE)); \ > } while (0) > > - > #define copy_to_user_page(vma, page, vaddr, dst, src, len) \ > do { \ > memcpy(dst, src, len); \ > flush_icache_range((unsigned) (dst), (unsigned) (dst) + (len)); \ > } while (0) > > -#define copy_from_user_page(vma, page, vaddr, dst, src, len) \ > - memcpy(dst, src, len) > +#include > > #endif /* _ASM_C6X_CACHEFLUSH_H */ Acked-by: Mark Salter From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F26EAC433E1 for ; Mon, 18 May 2020 18:21:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CED54207C4 for ; Mon, 18 May 2020 18:21:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="P1Ae4Jcm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387804AbgERSVA (ORCPT ); Mon, 18 May 2020 14:21:00 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:41671 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731703AbgERSU4 (ORCPT ); Mon, 18 May 2020 14:20:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589826054; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bgUgYOhXHVrOhAbBYxlnYyhMzdekwGrXn9fI5GzJacU=; b=P1Ae4JcmTm0WHLLAVaElH5dd9rU87sM7FkJZLRKSfEpQ1W+vh24p5OoRUEyXSMHavi2+O6 hyofZQ6yzv9FW4cIZOWwA/V4f5w47EuRXrN/yW5dL62ma3WCPjDUeiuN2Na9ibgT7BUb10 dYriE19REwII93v6UFtVKKn+YoNgRvs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-266-kVRrudnWNEOZ64966nyy_Q-1; Mon, 18 May 2020 14:20:52 -0400 X-MC-Unique: kVRrudnWNEOZ64966nyy_Q-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 428731005510; Mon, 18 May 2020 18:20:48 +0000 (UTC) Received: from ovpn-115-234.rdu2.redhat.com (ovpn-115-234.rdu2.redhat.com [10.10.115.234]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6AF23398; Mon, 18 May 2020 18:20:43 +0000 (UTC) Message-ID: <5260142047d0339e00d4a74865c2f0b7511c89f6.camel@redhat.com> Subject: Re: [PATCH 10/29] c6x: use asm-generic/cacheflush.h From: Mark Salter To: Christoph Hellwig , Andrew Morton , Arnd Bergmann , Roman Zippel Cc: linux-arch@vger.kernel.org, linux-xtensa@linux-xtensa.org, Michal Simek , Jessica Yu , linux-ia64@vger.kernel.org, linux-c6x-dev@linux-c6x.org, linux-sh@vger.kernel.org, linux-hexagon@vger.kernel.org, x86@kernel.org, linux-um@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-m68k@lists.linux-m68k.org, openrisc@lists.librecores.org, linux-alpha@vger.kernel.org, sparclinux@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Date: Mon, 18 May 2020 14:20:42 -0400 In-Reply-To: <20200515143646.3857579-11-hch@lst.de> References: <20200515143646.3857579-1-hch@lst.de> <20200515143646.3857579-11-hch@lst.de> Organization: Red Hat, Inc Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.2 (3.36.2-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2020-05-15 at 16:36 +0200, Christoph Hellwig wrote: > C6x needs almost no cache flushing routines of its own. Rely on > asm-generic/cacheflush.h for the defaults. > > Signed-off-by: Christoph Hellwig > --- > arch/c6x/include/asm/cacheflush.h | 19 +------------------ > 1 file changed, 1 insertion(+), 18 deletions(-) > > diff --git a/arch/c6x/include/asm/cacheflush.h b/arch/c6x/include/asm/cacheflush.h > index 4540b40475e6c..10922d528de6d 100644 > --- a/arch/c6x/include/asm/cacheflush.h > +++ b/arch/c6x/include/asm/cacheflush.h > @@ -16,21 +16,6 @@ > #include > #include > > -/* > - * virtually-indexed cache management (our cache is physically indexed) > - */ > -#define flush_cache_all() do {} while (0) > -#define flush_cache_mm(mm) do {} while (0) > -#define flush_cache_dup_mm(mm) do {} while (0) > -#define flush_cache_range(mm, start, end) do {} while (0) > -#define flush_cache_page(vma, vmaddr, pfn) do {} while (0) > -#define flush_cache_vmap(start, end) do {} while (0) > -#define flush_cache_vunmap(start, end) do {} while (0) > -#define ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE 0 > -#define flush_dcache_page(page) do {} while (0) > -#define flush_dcache_mmap_lock(mapping) do {} while (0) > -#define flush_dcache_mmap_unlock(mapping) do {} while (0) > - > /* > * physically-indexed cache management > */ > @@ -49,14 +34,12 @@ do { \ > (unsigned long) page_address(page) + PAGE_SIZE)); \ > } while (0) > > - > #define copy_to_user_page(vma, page, vaddr, dst, src, len) \ > do { \ > memcpy(dst, src, len); \ > flush_icache_range((unsigned) (dst), (unsigned) (dst) + (len)); \ > } while (0) > > -#define copy_from_user_page(vma, page, vaddr, dst, src, len) \ > - memcpy(dst, src, len) > +#include > > #endif /* _ASM_C6X_CACHEFLUSH_H */ Acked-by: Mark Salter From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E69CAC433E3 for ; Mon, 18 May 2020 18:23:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C0A7F20643 for ; Mon, 18 May 2020 18:23:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="la7oyhKb"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="aO0gEs3g" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C0A7F20643 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bgUgYOhXHVrOhAbBYxlnYyhMzdekwGrXn9fI5GzJacU=; b=la7oyhKbEBfhy7 bUC7CRxtPKho1iPLM9uzzZcQKO6usk2IDi5aVWyR7ufxrFR3Vy9MBdIPpwH/R761xsnH+/TDh/ucB 6LSt6U0rqkaZwXEsTbjDZ4bGpwUMbpe+oa3tqZDqNf0I+l7sPeHYo68utX84QqtA3RC3k5Ncrdct+ 6yPZthaA+TMdK45SXjSGdWAUb8Y+F8TGv89YeIN7lISjbaMCyRb5a5wQKqlvw8L1F1QOZB696p0Xx 3V4xhuP8tEfxW7Xo+qgFNJAtTne1jTQgVS0WkIRLJPLMboYNIuzBoEfKfosmanb3lQwi+ZDj/sHB/ B+pyZI/9CIm4pqzw92ZA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jakPr-0005oY-F6; Mon, 18 May 2020 18:23:07 +0000 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120] helo=us-smtp-1.mimecast.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jakPn-0005mA-CT for linux-riscv@lists.infradead.org; Mon, 18 May 2020 18:23:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589826181; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bgUgYOhXHVrOhAbBYxlnYyhMzdekwGrXn9fI5GzJacU=; b=aO0gEs3gguCIaK2BWL5X5EtHk8V5AxDuXSocAJRaBoX+Cdcg5OR01t6ima7+V8KRYywfTt 0+Stv4mN4+nI4/R6OmGw1oRjk3ZxLpjOJT4U6/UeCB1QdvLxl0lgco67CySOi9A4OfABZI 18/n6pWJo84PKezvNlXH//SOLx3Rc7U= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-266-kVRrudnWNEOZ64966nyy_Q-1; Mon, 18 May 2020 14:20:52 -0400 X-MC-Unique: kVRrudnWNEOZ64966nyy_Q-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 428731005510; Mon, 18 May 2020 18:20:48 +0000 (UTC) Received: from ovpn-115-234.rdu2.redhat.com (ovpn-115-234.rdu2.redhat.com [10.10.115.234]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6AF23398; Mon, 18 May 2020 18:20:43 +0000 (UTC) Message-ID: <5260142047d0339e00d4a74865c2f0b7511c89f6.camel@redhat.com> Subject: Re: [PATCH 10/29] c6x: use asm-generic/cacheflush.h From: Mark Salter To: Christoph Hellwig , Andrew Morton , Arnd Bergmann , Roman Zippel Date: Mon, 18 May 2020 14:20:42 -0400 In-Reply-To: <20200515143646.3857579-11-hch@lst.de> References: <20200515143646.3857579-1-hch@lst.de> <20200515143646.3857579-11-hch@lst.de> Organization: Red Hat, Inc Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.2 (3.36.2-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200518_112303_609782_A2266130 X-CRM114-Status: GOOD ( 13.54 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, linux-xtensa@linux-xtensa.org, Michal Simek , linux-alpha@vger.kernel.org, linux-ia64@vger.kernel.org, linux-c6x-dev@linux-c6x.org, linux-sh@vger.kernel.org, linux-hexagon@vger.kernel.org, x86@kernel.org, linux-um@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-m68k@lists.linux-m68k.org, openrisc@lists.librecores.org, Jessica Yu , sparclinux@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org On Fri, 2020-05-15 at 16:36 +0200, Christoph Hellwig wrote: > C6x needs almost no cache flushing routines of its own. Rely on > asm-generic/cacheflush.h for the defaults. > > Signed-off-by: Christoph Hellwig > --- > arch/c6x/include/asm/cacheflush.h | 19 +------------------ > 1 file changed, 1 insertion(+), 18 deletions(-) > > diff --git a/arch/c6x/include/asm/cacheflush.h b/arch/c6x/include/asm/cacheflush.h > index 4540b40475e6c..10922d528de6d 100644 > --- a/arch/c6x/include/asm/cacheflush.h > +++ b/arch/c6x/include/asm/cacheflush.h > @@ -16,21 +16,6 @@ > #include > #include > > -/* > - * virtually-indexed cache management (our cache is physically indexed) > - */ > -#define flush_cache_all() do {} while (0) > -#define flush_cache_mm(mm) do {} while (0) > -#define flush_cache_dup_mm(mm) do {} while (0) > -#define flush_cache_range(mm, start, end) do {} while (0) > -#define flush_cache_page(vma, vmaddr, pfn) do {} while (0) > -#define flush_cache_vmap(start, end) do {} while (0) > -#define flush_cache_vunmap(start, end) do {} while (0) > -#define ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE 0 > -#define flush_dcache_page(page) do {} while (0) > -#define flush_dcache_mmap_lock(mapping) do {} while (0) > -#define flush_dcache_mmap_unlock(mapping) do {} while (0) > - > /* > * physically-indexed cache management > */ > @@ -49,14 +34,12 @@ do { \ > (unsigned long) page_address(page) + PAGE_SIZE)); \ > } while (0) > > - > #define copy_to_user_page(vma, page, vaddr, dst, src, len) \ > do { \ > memcpy(dst, src, len); \ > flush_icache_range((unsigned) (dst), (unsigned) (dst) + (len)); \ > } while (0) > > -#define copy_from_user_page(vma, page, vaddr, dst, src, len) \ > - memcpy(dst, src, len) > +#include > > #endif /* _ASM_C6X_CACHEFLUSH_H */ Acked-by: Mark Salter From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Salter Subject: Re: [PATCH 10/29] c6x: use asm-generic/cacheflush.h Date: Mon, 18 May 2020 14:20:42 -0400 Message-ID: <5260142047d0339e00d4a74865c2f0b7511c89f6.camel@redhat.com> References: <20200515143646.3857579-1-hch@lst.de> <20200515143646.3857579-11-hch@lst.de> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589826057; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bgUgYOhXHVrOhAbBYxlnYyhMzdekwGrXn9fI5GzJacU=; b=LHpMJHvTqR4bS7BOLhElvkKPeYOYcOnKdUDWTIN1DiiFEuBj1Wfpg5VAxD8lGTo7Xqpq6m fzJDo8yH9BGRHSZPsnBWeWIc47ShwX3Uy5323Khj9iu9hDqS3kxwPZvxz9cZKg/557JR6C Mcl3BWeu/IUouc77fUatFePTVcQ61I0= In-Reply-To: <20200515143646.3857579-11-hch@lst.de> Sender: sparclinux-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Christoph Hellwig , Andrew Morton , Arnd Bergmann , Roman Zippel Cc: linux-arch@vger.kernel.org, linux-xtensa@linux-xtensa.org, Michal Simek , Jessica Yu , linux-ia64@vger.kernel.org, linux-c6x-dev@linux-c6x.org, linux-sh@vger.kernel.org, linux-hexagon@vger.kernel.org, x86@kernel.org, linux-um@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-m68k@lists.linux-m68k.org, openrisc@lists.librecores.org, linux-alpha@vger.kernel.org, sparclinux@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org On Fri, 2020-05-15 at 16:36 +0200, Christoph Hellwig wrote: > C6x needs almost no cache flushing routines of its own. Rely on > asm-generic/cacheflush.h for the defaults. > > Signed-off-by: Christoph Hellwig > --- > arch/c6x/include/asm/cacheflush.h | 19 +------------------ > 1 file changed, 1 insertion(+), 18 deletions(-) > > diff --git a/arch/c6x/include/asm/cacheflush.h b/arch/c6x/include/asm/cacheflush.h > index 4540b40475e6c..10922d528de6d 100644 > --- a/arch/c6x/include/asm/cacheflush.h > +++ b/arch/c6x/include/asm/cacheflush.h > @@ -16,21 +16,6 @@ > #include > #include > > -/* > - * virtually-indexed cache management (our cache is physically indexed) > - */ > -#define flush_cache_all() do {} while (0) > -#define flush_cache_mm(mm) do {} while (0) > -#define flush_cache_dup_mm(mm) do {} while (0) > -#define flush_cache_range(mm, start, end) do {} while (0) > -#define flush_cache_page(vma, vmaddr, pfn) do {} while (0) > -#define flush_cache_vmap(start, end) do {} while (0) > -#define flush_cache_vunmap(start, end) do {} while (0) > -#define ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE 0 > -#define flush_dcache_page(page) do {} while (0) > -#define flush_dcache_mmap_lock(mapping) do {} while (0) > -#define flush_dcache_mmap_unlock(mapping) do {} while (0) > - > /* > * physically-indexed cache management > */ > @@ -49,14 +34,12 @@ do { \ > (unsigned long) page_address(page) + PAGE_SIZE)); \ > } while (0) > > - > #define copy_to_user_page(vma, page, vaddr, dst, src, len) \ > do { \ > memcpy(dst, src, len); \ > flush_icache_range((unsigned) (dst), (unsigned) (dst) + (len)); \ > } while (0) > > -#define copy_from_user_page(vma, page, vaddr, dst, src, len) \ > - memcpy(dst, src, len) > +#include > > #endif /* _ASM_C6X_CACHEFLUSH_H */ Acked-by: Mark Salter From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E6E3C433E0 for ; Mon, 18 May 2020 18:23:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C05DB20643 for ; Mon, 18 May 2020 18:23:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AzkFmOIb"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="aO0gEs3g" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C05DB20643 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TgfJjvJMA4tgo5sxlQ3fLX/veuKiEBI7y+Fh6SDzzTw=; b=AzkFmOIbfpDFh9 ua92Ehlz2+3DAo9fmG/HpQLuh6l9k27cHBFzkix9faI6HAT1Ybp0GBTn978pdIbE9U3gjkqOEDS3F lxfgb0NfckdtOUuDas5N04pMsW/BhlXxjZcoCiCZ1dJjmzXVkckmO5r8yDvVTPoMNs3W8myg0MRSJ D9wz+aaY+xzTyhYt/In5+YGuLciH3NL1dpSUtJtVIJJDDP76xgGBbJncIxnIuGDcObU6mqi55ZO0q HHswzG7vzYskUw35tGbSJDe92Wgb4+UI22oNsEZHqQlDiK61ghvOl+JIx5nxVf2cXo9nnzI1tDf3V mogE8NnmLAwWwCePn9yQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jakPs-0005ps-Ub; Mon, 18 May 2020 18:23:08 +0000 Received: from us-smtp-1.mimecast.com ([205.139.110.61] helo=us-smtp-delivery-1.mimecast.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jakPn-0005m9-DG for linux-arm-kernel@lists.infradead.org; Mon, 18 May 2020 18:23:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589826181; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bgUgYOhXHVrOhAbBYxlnYyhMzdekwGrXn9fI5GzJacU=; b=aO0gEs3gguCIaK2BWL5X5EtHk8V5AxDuXSocAJRaBoX+Cdcg5OR01t6ima7+V8KRYywfTt 0+Stv4mN4+nI4/R6OmGw1oRjk3ZxLpjOJT4U6/UeCB1QdvLxl0lgco67CySOi9A4OfABZI 18/n6pWJo84PKezvNlXH//SOLx3Rc7U= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-266-kVRrudnWNEOZ64966nyy_Q-1; Mon, 18 May 2020 14:20:52 -0400 X-MC-Unique: kVRrudnWNEOZ64966nyy_Q-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 428731005510; Mon, 18 May 2020 18:20:48 +0000 (UTC) Received: from ovpn-115-234.rdu2.redhat.com (ovpn-115-234.rdu2.redhat.com [10.10.115.234]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6AF23398; Mon, 18 May 2020 18:20:43 +0000 (UTC) Message-ID: <5260142047d0339e00d4a74865c2f0b7511c89f6.camel@redhat.com> Subject: Re: [PATCH 10/29] c6x: use asm-generic/cacheflush.h From: Mark Salter To: Christoph Hellwig , Andrew Morton , Arnd Bergmann , Roman Zippel Date: Mon, 18 May 2020 14:20:42 -0400 In-Reply-To: <20200515143646.3857579-11-hch@lst.de> References: <20200515143646.3857579-1-hch@lst.de> <20200515143646.3857579-11-hch@lst.de> Organization: Red Hat, Inc User-Agent: Evolution 3.36.2 (3.36.2-1.fc32) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200518_112303_648880_5489CAA6 X-CRM114-Status: GOOD ( 14.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, linux-xtensa@linux-xtensa.org, Michal Simek , linux-alpha@vger.kernel.org, linux-ia64@vger.kernel.org, linux-c6x-dev@linux-c6x.org, linux-sh@vger.kernel.org, linux-hexagon@vger.kernel.org, x86@kernel.org, linux-um@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-m68k@lists.linux-m68k.org, openrisc@lists.librecores.org, Jessica Yu , sparclinux@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 2020-05-15 at 16:36 +0200, Christoph Hellwig wrote: > C6x needs almost no cache flushing routines of its own. Rely on > asm-generic/cacheflush.h for the defaults. > > Signed-off-by: Christoph Hellwig > --- > arch/c6x/include/asm/cacheflush.h | 19 +------------------ > 1 file changed, 1 insertion(+), 18 deletions(-) > > diff --git a/arch/c6x/include/asm/cacheflush.h b/arch/c6x/include/asm/cacheflush.h > index 4540b40475e6c..10922d528de6d 100644 > --- a/arch/c6x/include/asm/cacheflush.h > +++ b/arch/c6x/include/asm/cacheflush.h > @@ -16,21 +16,6 @@ > #include > #include > > -/* > - * virtually-indexed cache management (our cache is physically indexed) > - */ > -#define flush_cache_all() do {} while (0) > -#define flush_cache_mm(mm) do {} while (0) > -#define flush_cache_dup_mm(mm) do {} while (0) > -#define flush_cache_range(mm, start, end) do {} while (0) > -#define flush_cache_page(vma, vmaddr, pfn) do {} while (0) > -#define flush_cache_vmap(start, end) do {} while (0) > -#define flush_cache_vunmap(start, end) do {} while (0) > -#define ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE 0 > -#define flush_dcache_page(page) do {} while (0) > -#define flush_dcache_mmap_lock(mapping) do {} while (0) > -#define flush_dcache_mmap_unlock(mapping) do {} while (0) > - > /* > * physically-indexed cache management > */ > @@ -49,14 +34,12 @@ do { \ > (unsigned long) page_address(page) + PAGE_SIZE)); \ > } while (0) > > - > #define copy_to_user_page(vma, page, vaddr, dst, src, len) \ > do { \ > memcpy(dst, src, len); \ > flush_icache_range((unsigned) (dst), (unsigned) (dst) + (len)); \ > } while (0) > > -#define copy_from_user_page(vma, page, vaddr, dst, src, len) \ > - memcpy(dst, src, len) > +#include > > #endif /* _ASM_C6X_CACHEFLUSH_H */ Acked-by: Mark Salter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Salter Date: Mon, 18 May 2020 14:20:42 -0400 Subject: [OpenRISC] [PATCH 10/29] c6x: use asm-generic/cacheflush.h In-Reply-To: <20200515143646.3857579-11-hch@lst.de> References: <20200515143646.3857579-1-hch@lst.de> <20200515143646.3857579-11-hch@lst.de> Message-ID: <5260142047d0339e00d4a74865c2f0b7511c89f6.camel@redhat.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: openrisc@lists.librecores.org On Fri, 2020-05-15 at 16:36 +0200, Christoph Hellwig wrote: > C6x needs almost no cache flushing routines of its own. Rely on > asm-generic/cacheflush.h for the defaults. > > Signed-off-by: Christoph Hellwig > --- > arch/c6x/include/asm/cacheflush.h | 19 +------------------ > 1 file changed, 1 insertion(+), 18 deletions(-) > > diff --git a/arch/c6x/include/asm/cacheflush.h b/arch/c6x/include/asm/cacheflush.h > index 4540b40475e6c..10922d528de6d 100644 > --- a/arch/c6x/include/asm/cacheflush.h > +++ b/arch/c6x/include/asm/cacheflush.h > @@ -16,21 +16,6 @@ > #include > #include > > -/* > - * virtually-indexed cache management (our cache is physically indexed) > - */ > -#define flush_cache_all() do {} while (0) > -#define flush_cache_mm(mm) do {} while (0) > -#define flush_cache_dup_mm(mm) do {} while (0) > -#define flush_cache_range(mm, start, end) do {} while (0) > -#define flush_cache_page(vma, vmaddr, pfn) do {} while (0) > -#define flush_cache_vmap(start, end) do {} while (0) > -#define flush_cache_vunmap(start, end) do {} while (0) > -#define ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE 0 > -#define flush_dcache_page(page) do {} while (0) > -#define flush_dcache_mmap_lock(mapping) do {} while (0) > -#define flush_dcache_mmap_unlock(mapping) do {} while (0) > - > /* > * physically-indexed cache management > */ > @@ -49,14 +34,12 @@ do { \ > (unsigned long) page_address(page) + PAGE_SIZE)); \ > } while (0) > > - > #define copy_to_user_page(vma, page, vaddr, dst, src, len) \ > do { \ > memcpy(dst, src, len); \ > flush_icache_range((unsigned) (dst), (unsigned) (dst) + (len)); \ > } while (0) > > -#define copy_from_user_page(vma, page, vaddr, dst, src, len) \ > - memcpy(dst, src, len) > +#include > > #endif /* _ASM_C6X_CACHEFLUSH_H */ Acked-by: Mark Salter