From: Stephen Warren <swarren@wwwdotorg.org>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Johannes Berg <johannes@sipsolutions.net>,
"David S. Miller" <davem@davemloft.net>
Cc: Chen-Yu Tsai <wens@csie.org>, Rhyland Klein <rklein@nvidia.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>
Subject: Re: [PATCH 2/4] net: rfkill: gpio: remove gpio names
Date: Thu, 20 Feb 2014 09:38:47 -0700 [thread overview]
Message-ID: <53062F97.3050407@wwwdotorg.org> (raw)
In-Reply-To: <1392900697-27577-3-git-send-email-heikki.krogerus@linux.intel.com>
On 02/20/2014 05:51 AM, Heikki Krogerus wrote:
> There is no use for them in this driver. This will fix a
> static checker warning..
Didn't you remove the use:
- gpio = devm_gpiod_get_index(&pdev->dev, rfkill->reset_name, 0);
+ gpio = devm_gpiod_get_index(&pdev->dev, NULL, 0);
doesn't that parameter get put into the sysfs GPIO debug file, so people
can see which GPIOs are used for what?
next prev parent reply other threads:[~2014-02-20 16:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-20 12:51 [PATCH 0/4] net: rfkill: gpio: clean up and a few new acpi ids Heikki Krogerus
2014-02-20 12:51 ` [PATCH 1/4] net: rfkill: gpio: remove unused and obsolete platform parameters Heikki Krogerus
2014-02-21 13:55 ` Marc Dietrich
2014-02-21 14:23 ` Heikki Krogerus
2014-02-22 22:32 ` [PATCH 1/4] net: rfkill: gpio: remove unused and obsoleteplatform parameters Marc Dietrich
2014-02-24 8:38 ` Heikki Krogerus
2014-02-24 8:42 ` [PATCH 1/4] net: rfkill: gpio: remove unused andobsoleteplatform parameters Marc Dietrich
2014-02-20 12:51 ` [PATCH 2/4] net: rfkill: gpio: remove gpio names Heikki Krogerus
2014-02-20 16:38 ` Stephen Warren [this message]
2014-02-21 1:55 ` Chen-Yu Tsai
2014-02-21 5:35 ` Stephen Warren
2014-02-21 5:35 ` Stephen Warren
2014-02-25 9:13 ` Linus Walleij
2014-02-25 17:35 ` Stephen Warren
2014-03-07 2:51 ` Linus Walleij
2014-03-07 2:51 ` Linus Walleij
2014-02-27 17:38 ` Gross, Mark
2014-02-27 17:47 ` Stephen Warren
2014-02-27 20:06 ` mark gross
2014-03-07 2:58 ` Linus Walleij
2014-02-20 12:51 ` [PATCH 3/4] net: rfkill: gpio: add ACPI ID for GPS module on Lenove Miix2 Heikki Krogerus
2014-02-20 12:51 ` [PATCH 4/4] net: rfkill: gpio: add ACPI IDs for a Broadcom bluetooth chip Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53062F97.3050407@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=gnurou@gmail.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=johannes@sipsolutions.net \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rklein@nvidia.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.