From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755672AbaBTRpk (ORCPT ); Thu, 20 Feb 2014 12:45:40 -0500 Received: from avon.wwwdotorg.org ([70.85.31.133]:51884 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755622AbaBTRpf (ORCPT ); Thu, 20 Feb 2014 12:45:35 -0500 Message-ID: <53063E01.5030808@wwwdotorg.org> Date: Thu, 20 Feb 2014 10:40:17 -0700 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Linaro CC: "Rafael J. Wysocki" , Lists linaro-kernel , "cpufreq@vger.kernel.org" , "linux-pm@vger.kernel.org" , Linux Kernel Mailing List , Nishanth Menon , Kgene Kim , "jinchoi@broadcom.com" , Lan Tianyu , Sebastian Capella , Jonghwan Choi Subject: Re: [PATCH V5 0/7] cpufreq: suspend early/resume late: dpm_{suspend|resume}() References: <52FE71BD.3020103@wwwdotorg.org> <2869027.iYHxWOSS2C@vostro.rjw.lan> <52FEAECA.5080905@wwwdotorg.org> <5303C018.1020707@wwwdotorg.org> <5304E93C.9000104@wwwdotorg.org> <90EA67AE-7F57-4F43-8967-642903AD72AC@linaro.org> In-Reply-To: X-Enigmail-Version: 1.5.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/19/2014 06:50 PM, Linaro wrote: > > >> On 20-Feb-2014, at 7:19 am, Linaro wrote: >> >> >> >>>> On 19-Feb-2014, at 10:56 pm, Stephen Warren wrote: >>>> >>>>> On 02/18/2014 09:15 PM, Viresh Kumar wrote: >>>>>> On 19-Feb-2014 1:48 AM, "Stephen Warren" wrote: >>>>>> >>>>>>> On 02/17/2014 02:20 AM, Viresh Kumar wrote: >>>>>>> On 15 February 2014 05:33, Stephen Warren wrote: >>>>>>> On 02/14/2014 03:23 PM, Rafael J. Wysocki wrote: >>>>>> >>>>>>>> Well, it would be good to verify which part, then. >>>>>>> >>>>>>> Patch 2/7 appears to stop that message from being printed during >>>>>>> suspend, and perhaps reduce the number of times it's printed during >>>>>>> resume. Patch 7/7 stops the message being printed at all. >>>>>>> >>>>>>> Looking at patch 7, I wonder if it's simply because tegra_target() was >>>>>>> modified never to return -EBUSY, so the bug is still there, but it's >>>>>>> just been hidden. >>>>>> >>>>>> No, the bug is removed now. Its hidden in current linus/master :) >>>>> >>>>> I'm not sure what that means; I still see the message: >>>> >>>> I have given a better reply in one of the earlier mails in this thread. >>>> And skipped a more elaborative reply now. >>>> >>>> So this failure was always there since long time, as you disable your >>>> target() fn early in suspend. But the message wasn't printed earlier. >>>> >>>> A recently added core patch started printing this, so not a new bug. >>>> But this series fixes suspend resume completely and you wouldn't see it >>>> anymore. >>> >>> OK, so I suppose we have two options: >>> >>> a) Just ignore the kernel error spew since it's a known issue. >>> >>> b) If I make the Tegra driver return 0 rather than -EBUSY, would that >>> work? It would certainly silence the error. However, I wonder if it >>> would cause the cpufreq core to get out of sync with HW; the core would >>> think that it'd set some frequency, which the driver ignored, and if it >>> later wanted to switch frequency, the call might get skipped because the >>> core thought the HW was already set to that frequency? >> >> Option is the one you need. > > Option a.. Well, except that still leaves a bunch of errors in the kernel log, and I have to remember to ignore them:-/ It'd be nice if the cpufreq core didn't keep changing its behaviour and adding new error prints. It really should be up to the cpufreq drivers to log the errors if they experience any.