Re: [PATCH V5 0/7] cpufreq: suspend early/resume late: dpm_{suspend|resume}()

From: Stephen Warren <swarren@wwwdotorg.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Lists linaro-kernel <linaro-kernel@lists.linaro.org>,
	"cpufreq@vger.kernel.org" <cpufreq@vger.kernel.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Nishanth Menon <nm@ti.com>, Kgene Kim <kgene.kim@samsung.com>,
	"jinchoi@broadcom.com" <jinchoi@broadcom.com>,
	Lan Tianyu <tianyu.lan@intel.com>,
	Sebastian Capella <sebastian.capella@linaro.org>,
	Jonghwan Choi <jhbird.choi@samsung.com>
Subject: Re: [PATCH V5 0/7] cpufreq: suspend early/resume late: dpm_{suspend|resume}()
Date: Mon, 24 Feb 2014 10:17:35 -0700	[thread overview]
Message-ID: <530B7EAF.9060502@wwwdotorg.org> (raw)
In-Reply-To: <CAKohpok3Y9H96rSFkUL=v3pMwRd9=YyVDfuY7SSSq6FevF1Snw@mail.gmail.com>

On 02/23/2014 11:43 PM, Viresh Kumar wrote:
> On 20 February 2014 23:10, Stephen Warren <swarren@wwwdotorg.org> wrote:
>> Well, except that still leaves a bunch of errors in the kernel log, and
>> I have to remember to ignore them:-/
> 
> Just for few releases, before this patchset goes in.
> 
>> It'd be nice if the cpufreq core didn't keep changing its behaviour and
>> adding new error prints. It really should be up to the cpufreq drivers
>> to log the errors if they experience any.
> 
> Hmm... not sure.. Its better to do error prints at a single place, i.e. cpufreq
> core on behalf of all drivers. If there is a error being returned from some
> routine, we better print a message for that. Rather than living in the illusion
> that everything is fine :)

As a general rule, I think it's better to report the error right where
it happened. That's the only place where the code knows exactly what the
error was. Further up the call stack, we have to guess why there was an
error from the return code, which isn't very much information.