Re: [Qemu-devel] [PATCH v6 6/8] virtio-scsi: use virtio wrappers to access headers

From: "Andreas Färber" <afaerber@suse.de>
To: Greg Kurz <gkurz@linux.vnet.ibm.com>
Cc: kwolf@redhat.com, peter.maydell@linaro.org,
	thuth@linux.vnet.ibm.com, mst@redhat.com, marc.zyngier@arm.com,
	rusty@rustcorp.com.au, agraf@suse.de, qemu-devel@nongnu.org,
	stefanha@redhat.com, cornelia.huck@de.ibm.com,
	pbonzini@redhat.com, anthony@codemonkey.ws
Subject: Re: [Qemu-devel] [PATCH v6 6/8] virtio-scsi: use virtio wrappers to access headers
Date: Fri, 28 Mar 2014 18:21:43 +0100	[thread overview]
Message-ID: <5335AFA7.9010306@suse.de> (raw)
In-Reply-To: <20140328181326.22c0a6a5@bahia.local>

Am 28.03.2014 18:13, schrieb Greg Kurz:
> On Fri, 28 Mar 2014 11:57:56 +0100
> Greg Kurz <gkurz@linux.vnet.ibm.com> wrote:
>> @@ -519,8 +521,8 @@ static void virtio_scsi_push_event(VirtIOSCSI *s, SCSIDevice *dev,
>>
>>      evt = req->resp.event;
>>      memset(evt, 0, sizeof(VirtIOSCSIEvent));
>> -    evt->event = event;
>> -    evt->reason = reason;
>> +    evt->event = virtio_tswap32(event);
>> +    evt->reason = virtio_tswap32(reason);
> 
> My bad again, it should be:
> 
>  +    evt->event = virtio_tswap32(event, vdev);
>  +    evt->reason = virtio_tswap32(reason, vdev);

Pure bikeshedding, but wouldn't it make sense to have the vdev as first
argument?

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg