All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Weil <sw@weilnetz.de>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [PATCH for 2.1] qemu-char: initialize out_lock
Date: Wed, 25 Jun 2014 12:26:04 +0200	[thread overview]
Message-ID: <53AAA3BC.4010500@weilnetz.de> (raw)
In-Reply-To: <1403679897-11480-1-git-send-email-pbonzini@redhat.com>

Am 25.06.2014 09:04, schrieb Paolo Bonzini:
> Otherwise, Windows fails with a deadlock.
>
> Reported-by: Stefan Weil <sw@weilnetz.de>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  qemu-char.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/qemu-char.c b/qemu-char.c
> index 2e50a10..17bd360 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -94,6 +94,7 @@ static QTAILQ_HEAD(CharDriverStateHead, CharDriverState) chardevs =
>  CharDriverState *qemu_chr_alloc(void)
>  {
>      CharDriverState *chr = g_malloc0(sizeof(CharDriverState));
> +    qemu_mutex_init(&chr->chr_write_lock);
>      return chr;
>  }
>  


Thanks, this fixes the problem with QEMU for Windows.

Tested-by: Stefan Weil <sw@weilnetz.de>

  reply	other threads:[~2014-06-25 10:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-25  7:04 [Qemu-devel] [PATCH for 2.1] qemu-char: initialize out_lock Paolo Bonzini
2014-06-25 10:26 ` Stefan Weil [this message]
2014-06-26 12:32 ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53AAA3BC.4010500@weilnetz.de \
    --to=sw@weilnetz.de \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.