From: Pascal Huerst <pascal.huerst@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH V5 2/2] google-breakpad: integration into Makefile and Config.in
Date: Wed, 09 Jul 2014 11:48:22 +0200 [thread overview]
Message-ID: <53BD0FE6.7090602@gmail.com> (raw)
In-Reply-To: <53B252FA.4050100@mind.be>
Hey Arnout, Thomas, all
-- snip --
On 01.07.2014 08:19, Arnout Vandecappelle wrote:
> On 29/06/14 12:36, Thomas Petazzoni wrote:
>> On Wed, 25 Jun 2014 22:31:20 +0200, Arnout Vandecappelle wrote:
>>> Actually, this symbol could be defined inside the google-breakpad/Config.in,
>>> no? Though you probably got a comment before that that is not the right place :-)
>>
>> Yeah, that's tricky. We could turn it into a "select", but then
>> everybody will always see this option related to google-breakpad in the
>> Build options. So I believe the solution of using a 'depends on' is
>> still the most appropriate solution. Maybe a little piece of
>> documentation should be added in the Buildroot manual to explain how
>> the Google Breakpad integration works?
>>
>> However, I don't really like the prompt. Maybe it should be:
>>
>> [ ] Enable Google Breakpad support
>> () List of binaries to extract symbols from
>
> If it is done in that way, then it really should be in the google breakpad
> package and not in the toolchain menu...
>
>
> However, thinking a bit more about this: the dependency on the target package
> is not correct. There's a dependency on the host package because the host tools
> are used, but it's the responsibility of whatever package is linking against the
> static library to also depend on the target package.
>
> So in that case, it is indeed best to keep it in the toolchain menu, remove the
> dependency on the target package, but add a boolean config option to enable
> breakpad to begin with.
Does this look reasonable?
config BR2_GOOGLE_BREAKPAD_ENABLE
bool "Enable google-breakpad support"
select BR2_PACKAGE_GOOGLE_BREAKPAD
help
This option will enable the use of google breakpad, a library and tool
suite that allows you to distribute an application to users with
compiler-provided debugging information removed, record crashes in
compact "minidump" files, send them back to your server and produce
C and C++ stack traces from these minidumps. Breakpad can also
write minidumps on request for programs that have not crashed.
if BR2_GOOGLE_BREAKPAD_ENABLE
config BR2_GOOGLE_BREAKPAD_INCLUDE_FILES
string "List of executables and libraries to extract symbols from"
default ""
help
You may specify a space-separated list of binaries and libraries
with full paths relative to $(TARGET_DIR) of which debug symbols
will be dumped for further use with google breakpad.
A directory structure that can be used by minidump-stackwalk will
be created at:
$(STAGING_DIR)/usr/share/google-breakpad-symbols
endif
regards
pascal
next prev parent reply other threads:[~2014-07-09 9:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-25 13:16 [Buildroot] [PATCH V5 0/2] google-breakpad: new package Pascal Huerst
2014-06-25 13:16 ` [Buildroot] [PATCH V5 1/2] " Pascal Huerst
2014-06-25 19:16 ` Arnout Vandecappelle
2014-06-29 10:30 ` Thomas Petazzoni
2014-07-02 12:59 ` Pascal Huerst
2014-06-25 13:16 ` [Buildroot] [PATCH V5 2/2] google-breakpad: integration into Makefile and Config.in Pascal Huerst
2014-06-25 20:31 ` Arnout Vandecappelle
2014-06-29 10:36 ` Thomas Petazzoni
2014-07-01 6:19 ` Arnout Vandecappelle
2014-07-09 9:48 ` Pascal Huerst [this message]
2014-07-09 9:39 ` Pascal Huerst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BD0FE6.7090602@gmail.com \
--to=pascal.huerst@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.