From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45DB0C433FE for ; Thu, 16 Sep 2021 21:44:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2519E6120E for ; Thu, 16 Sep 2021 21:44:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237719AbhIPVqS (ORCPT ); Thu, 16 Sep 2021 17:46:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234064AbhIPVqQ (ORCPT ); Thu, 16 Sep 2021 17:46:16 -0400 Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9D91C061574 for ; Thu, 16 Sep 2021 14:44:55 -0700 (PDT) Received: by mail-pg1-x531.google.com with SMTP id u18so7584966pgf.0 for ; Thu, 16 Sep 2021 14:44:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=nNhkyuKjI5tXvuO0GxWnGKDPFHuKELj6HwQch3Dl+cU=; b=RdCAqzew0hgwM7IJIodHAuIxcYYqogozZunJPZeCd4VAqc4icaBOKUdNqtLomMMsSr SYrxvgRs4Par89fJEqpPCDZ4+XLY7WO2ZcFStBbsxp22NnxyjT8XxsiXvmsWOLovl1S8 eRYPwD9x1heK58J8sna040Pj1tVdCa5AjEIDSgdMZ+hUWzlxYrJN35KGXusUjSzFUnNG xjF0RiY+S9I+EecNi20gC3vYNw+5M2NwC8QmQ5XFIGfe7OG4swOXc7v6W8TbDOcVZu+F L6R4b/3/fMY7Kb4/qFdOJ7EeADI2gvjGoiU2Qo6G+0EHPzyyADa52HwUU26v8KbIqwFz OZVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=nNhkyuKjI5tXvuO0GxWnGKDPFHuKELj6HwQch3Dl+cU=; b=rtTViMh6RG4EqnQmK1Rn5miCms85zBRkPq4kKJZEywCuoeOIVdYxbu7m0QlEDuZDA2 X5qYa9874tyJ4w+NPITTHSiUgozyBWhttMp4AKe7EZ0aELMAiiYcjK5EDXwQaQrEu7B2 Giq6KJZeEGdMZ0LvD5ESVP1vaiWsyVRzpPyfWpuMCH4hVHjAI8lCpYK8z5INc3ViIBlX fuSkioG42T1Xf1OEW7/zfmlHGmn27tYW+/2FjsGlsAYf04wnYz0mOYoPuIxOSjYJz/MN Tebxl5G7K+Wav6dkY0fEbWUzZOSdniwdD7QlDSQ4s2Xryczxlcwc+fOyDLTEtEc9WVEy uvNQ== X-Gm-Message-State: AOAM532DaNYwFxpcpJAdlGcs3fxmm9pR44BGf0xueFXRA6iQhsyZGW96 OGevoYqKz/LctDJQeQOTqls= X-Google-Smtp-Source: ABdhPJzVhWT5Sgs6NyGB+h5G/pJ/sSfVUYQJCbryOzs8m5KPMlhoKb/sKmaxmHzd+O1auOexbs70Yw== X-Received: by 2002:a63:9a19:: with SMTP id o25mr6835991pge.90.1631828695406; Thu, 16 Sep 2021 14:44:55 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id b12sm9017695pjg.0.2021.09.16.14.44.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Sep 2021 14:44:54 -0700 (PDT) Subject: Re: [PATCH net-next 2/4] net: dsa: b53: Drop BCM5301x workaround for a wrong CPU/IMP port To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Andrew Lunn , Vivien Didelot , Vladimir Oltean , "David S . Miller" , Jakub Kicinski Cc: netdev@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= References: <20210916120354.20338-1-zajec5@gmail.com> <20210916120354.20338-3-zajec5@gmail.com> From: Florian Fainelli Message-ID: <53c85810-4ca5-8475-5f34-43467d018414@gmail.com> Date: Thu, 16 Sep 2021 14:44:46 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210916120354.20338-3-zajec5@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 9/16/21 5:03 AM, Rafał Miłecki wrote: > From: Rafał Miłecki > > On BCM5301x port 8 requires a fixed link when used. > > Years ago when b53 was an OpenWrt downstream driver (with configuration > based on sometimes bugged NVRAM) there was a need for a fixup. In case > of forcing fixed link for (incorrectly specified) port 5 the code had to > actually setup port 8 link. > > For upstream b53 driver with setup based on DT there is no need for that > workaround. In DT we have and require correct ports setup. > > Signed-off-by: Rafał Miłecki Reviewed-by: Florian Fainelli Tested-by: Florian Fainelli -- Florian