Re: [RFC v2 3/4] drm/panel: Add new panel driver based on crystal cove pmic

["Kumar, Shobhit" <shobhit.kumar@linux.intel.com>]

On 1/12/2015 1:56 PM, Kumar, Shobhit wrote:
> On 1/9/2015 6:38 PM, Jani Nikula wrote:
>> On Fri, 02 Jan 2015, Shobhit Kumar <shobhit.kumar@intel.com> wrote:
>>> This driver provides support for the "crystal_cove_panel" cell device.
>>> On BYT-T pmic has to be used to enable/disable panel.
>>
>> This needs to be sent to dri-devel.
>
> Will do for the updated patch after addressing all your comments.

Also do we really need to make it as part of drm. How about keeping this 
internal to i915 as most likely no one else other than i915 will use it ?

>
>>
>> With the comments below addressed, and with the disclaimer that I have
>> no idea about the pmic registers or required sleeps, this is
>>
>> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>>
>>>
>>> Signed-off-by: Shobhit Kumar <shobhit.kumar@intel.com>
>>> ---

>>> +module_platform_driver(crystalcove_panel_driver);
>>> +
>>> +MODULE_AUTHOR("Shobhit Kumar <shobhit.kumar@linux.intel.com");
>>> +MODULE_DESCRIPTION("Intel Crystal Cove Panel Driver");
>>> +MODULE_LICENSE("GPL v2");
>>
>> This conflicts with the copyright header of the file.

I have seen drivers in kernel header both with Copyright and GPL V2. 
Example - "drivers/gpu/drm/panel/panel-s6e8aa0.c"

I can change to  MODULE_LICENSE("GPL and additional rights");

Regards
Shobhit
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx