From: "Jan Beulich" <JBeulich@suse.com>
To: Ian Campbell <Ian.Campbell@eu.citrix.com>
Cc: roy.franz@linaro.org, xen-devel <xen-devel@lists.xenproject.org>,
Tim Deegan <tim@xen.org>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH] arm64/EFI: minor corrections
Date: Mon, 12 Jan 2015 13:59:13 +0000 [thread overview]
Message-ID: <54B3E1410200007800053C62@mail.emea.novell.com> (raw)
In-Reply-To: <1421070408.26317.62.camel@eu.citrix.com>
>>> On 12.01.15 at 14:46, <Ian.Campbell@eu.citrix.com> wrote:
> On Mon, 2015-01-12 at 08:59 +0000, Jan Beulich wrote:
>> - don't bail when using the last slot of bootinfo.mem.bank[] (due to
>> premature incrementing of the array index)
>> - GUIDs should be static const (and placed into .init.* whenever
>> possible)
>> - PrintErrMsg() issues a CR/LF pair itself - no need to explicitly
>> append one to the message passed to the function
> - Avoid needless use of DisplayUint via __stringify.
>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
>
> Will you commit yourself or would you like me to?
I will.
Jan
prev parent reply other threads:[~2015-01-12 13:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-12 8:59 [PATCH] arm64/EFI: minor corrections Jan Beulich
2015-01-12 13:46 ` Ian Campbell
2015-01-12 13:59 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B3E1410200007800053C62@mail.emea.novell.com \
--to=jbeulich@suse.com \
--cc=Ian.Campbell@eu.citrix.com \
--cc=roy.franz@linaro.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.