From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758345AbbA3NQZ (ORCPT ); Fri, 30 Jan 2015 08:16:25 -0500 Received: from smtp97.iad3a.emailsrvr.com ([173.203.187.97]:46908 "EHLO smtp97.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752758AbbA3NQX (ORCPT ); Fri, 30 Jan 2015 08:16:23 -0500 X-Sender-Id: abbotti@mev.co.uk Message-ID: <54CB8424.4060407@mev.co.uk> Date: Fri, 30 Jan 2015 13:16:20 +0000 From: Ian Abbott User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.3.0 MIME-Version: 1.0 To: Dan Carpenter CC: Rickard Strandqvist , H Hartley Sweeten , devel@driverdev.osuosl.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Fred Akers Subject: Re: [PATCH v2] staging: comedi: drivers: addi_apci_3501: Removed variables that is never used References: <1422570895-9239-1-git-send-email-rickard_strandqvist@spectrumdigital.se> <54CB5D18.8020001@mev.co.uk> <20150130121027.GX6456@mwanda> In-Reply-To: <20150130121027.GX6456@mwanda> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/01/15 12:10, Dan Carpenter wrote: > On Fri, Jan 30, 2015 at 10:29:44AM +0000, Ian Abbott wrote: >>> @@ -285,7 +284,7 @@ static irqreturn_t apci3501_interrupt(int irq, void *d) >>> ul_Command1 = inl(dev->iobase + APCI3501_TIMER_CTRL_REG); >>> ul_Command1 = ((ul_Command1 & 0xFFFFF9FDul) | 1 << 1); >>> outl(ul_Command1, dev->iobase + APCI3501_TIMER_CTRL_REG); >>> - i_temp = inl(dev->iobase + APCI3501_TIMER_STATUS_REG) & 0x1; >>> + inl(dev->iobase + APCI3501_TIMER_STATUS_REG); >>> >>> return IRQ_HANDLED; >>> } >>> >> >> Reviewed-by: Ian Abbott > > Ian, is the inl() really needed? Richard did the conservative thing, > but if we knew we could delete the inl() that would be nice. I'm not sure if it's really needed, but it is part of some watchdog functionality, so I thought it best to leave it alone. Hartley might know if it's needed. -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=-