From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45619) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIGGk-0007a0-VX for qemu-devel@nongnu.org; Mon, 02 Feb 2015 07:38:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YIGGe-0005tY-IW for qemu-devel@nongnu.org; Mon, 02 Feb 2015 07:38:21 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54405) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIGGe-0005tO-BH for qemu-devel@nongnu.org; Mon, 02 Feb 2015 07:38:16 -0500 Message-ID: <54CF6FA9.7090600@redhat.com> Date: Mon, 02 Feb 2015 13:38:01 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <20150122085127.5276.53895.stgit@PASHA-ISP.def.inno> <20150122085215.5276.8878.stgit@PASHA-ISP.def.inno> <54C9FE31.4090404@redhat.com> <001801d03ee3$c8cb7660$5a626320$@Dovgaluk@ispras.ru> In-Reply-To: <001801d03ee3$c8cb7660$5a626320$@Dovgaluk@ispras.ru> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH v8 08/21] cpu: replay instructions sequence List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Dovgaluk , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, alex.bennee@linaro.org, mark.burton@greensocs.com, real@ispras.ru, batuzovk@ispras.ru, maria.klimushenkova@ispras.ru, afaerber@suse.de, fred.konrad@greensocs.com On 02/02/2015 13:28, Pavel Dovgaluk wrote: >>> > > cpu->exception_index = EXCP_INTERRUPT; >>> > > next_tb = 0; >>> > > + qemu_notify_event(); >> > >> > Why is this needed? > It is needed to wake up iothread in replay mode. > Otherwise it waits for additional time and replay becomes too slow. What event (something from a timerlist?) is ready, that has not been notified to the iothread yet? qemu_notify_event() should never be needed in common case. It's probably missing somewhere else. Paolo