From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56035)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YIc8z-0003o1-Fs
	for qemu-devel@nongnu.org; Tue, 03 Feb 2015 06:59:50 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YIc8v-00073H-1a
	for qemu-devel@nongnu.org; Tue, 03 Feb 2015 06:59:49 -0500
Received: from mx1.redhat.com ([209.132.183.28]:39731)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YIc8u-000734-Q2
	for qemu-devel@nongnu.org; Tue, 03 Feb 2015 06:59:44 -0500
Message-ID: <54D0B821.70906@redhat.com>
Date: Tue, 03 Feb 2015 12:59:29 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <20150122085127.5276.53895.stgit@PASHA-ISP.def.inno>
	<20150122085232.5276.99646.stgit@PASHA-ISP.def.inno>
	<54CA086D.2060706@redhat.com>
	<000601d03f9f$6684bef0$338e3cd0$@Dovgaluk@ispras.ru>
	<54D0AB59.7060605@redhat.com>
	<000701d03fa3$e7018500$b5048f00$@Dovgaluk@ispras.ru>
In-Reply-To: <000701d03fa3$e7018500$b5048f00$@Dovgaluk@ispras.ru>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH v8 11/21] replay: recording and
	replaying clock ticks
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Pavel Dovgaluk <Pavel.Dovgaluk@ispras.ru>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, alex.bennee@linaro.org, mark.burton@greensocs.com, real@ispras.ru, batuzovk@ispras.ru, maria.klimushenkova@ispras.ru, afaerber@suse.de, fred.konrad@greensocs.com



On 03/02/2015 12:23, Pavel Dovgaluk wrote:
> > Only to the cpu_get_ticks usage.  The others are okay.
> 
> cpu_get_ticks cannot call cpu_get_real_ticks in icount mode.

You're right, but...

> And other functions can.

... which functions?  cpu_enable_ticks and cpu_disable_ticks call it,
but the result is only used by cpu_get_ticks.  As you said, this cannot
be called in icount mode.

A couple of PPC device models call it, but they probably should call
cpu_get_ticks instead.  So it looks like handling REAL_TICKS is
altogether unnecessary.

Paolo