From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41221)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YKnQq-00076n-59
	for qemu-devel@nongnu.org; Mon, 09 Feb 2015 07:27:17 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YKnQj-0006Rh-7L
	for qemu-devel@nongnu.org; Mon, 09 Feb 2015 07:27:16 -0500
Received: from mx1.redhat.com ([209.132.183.28]:57763)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YKnQj-0006RM-0F
	for qemu-devel@nongnu.org; Mon, 09 Feb 2015 07:27:09 -0500
Message-ID: <54D8A78D.2090805@redhat.com>
Date: Mon, 09 Feb 2015 13:26:53 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <20150122085127.5276.53895.stgit@PASHA-ISP.def.inno>
	<20150122085323.5276.64995.stgit@PASHA-ISP.def.inno>
	<54CB62E5.3000807@redhat.com>
	<001c01d04462$17a41f20$46ec5d60$@Dovgaluk@ispras.ru>
In-Reply-To: <001c01d04462$17a41f20$46ec5d60$@Dovgaluk@ispras.ru>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH v8 20/21] replay: command line options
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Pavel Dovgaluk <Pavel.Dovgaluk@ispras.ru>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, alex.bennee@linaro.org, mark.burton@greensocs.com, real@ispras.ru, batuzovk@ispras.ru, maria.klimushenkova@ispras.ru, afaerber@suse.de, fred.konrad@greensocs.com



On 09/02/2015 13:15, Pavel Dovgaluk wrote:
>> From: Paolo Bonzini [mailto:pbonzini@redhat.com]
>> On 22/01/2015 09:53, Pavel Dovgalyuk wrote:
>>> This patch introduces command line options for enabling recording or replaying
>>> virtual machine behavior. "-record" option starts recording of the execution
>>> and saves it into the log, specified with "fname" parameter. "-replay" option
>>> is intended for replaying previously saved log.
>>>
>>> Signed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
>>>                  break;
>>>              case QEMU_OPTION_snapshot:
>>>                  snapshot = 1;
>>> @@ -3105,6 +3114,7 @@ int main(int argc, char **argv, char **envp)
>>>  #endif
>>>              case QEMU_OPTION_bt:
>>>                  add_device_config(DEV_BT, optarg);
>>> +                not_compatible_replay_param++;
>>
>> Could it be enough to add a migration blocker?
> 
> Record/replay core does not use migration subsystem.
> That is why it should check the hardware by itself.

Right.  But is there anything that supports migration but not replay?
If the two overlap, you can just check migration blockers to see if
record/replay can be allowed.

>>
>>>                  break;
>>>              case QEMU_OPTION_audio_help:
>>>                  AUD_help ();
>>> @@ -3244,6 +3254,7 @@ int main(int argc, char **argv, char **envp)
>>>                  if (!opts) {
>>>                      exit(1);
>>>                  }
>>> +                not_compatible_replay_param++;
>>
>> Why not compatible?
> 
> Replay for audio adapter will be added in latter patches.
> Trying to record/replay machine with audio using current
> set of patches will break the replay.

For this case you can try adding a mechanism similar to migration
blockers (replay blockers).

Paolo