All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stas Sergeev <stsp@list.ru>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: netdev@vger.kernel.org,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Subject: Re: [PATCH 0/6] mvneta: SGMII-based in-band link status signaling
Date: Thu, 26 Mar 2015 20:34:33 +0300	[thread overview]
Message-ID: <55144329.3040501@list.ru> (raw)
In-Reply-To: <551441FA.1010504@gmail.com>

26.03.2015 20:29, Florian Fainelli пишет:
> On 26/03/15 10:23, Stas Sergeev wrote:
>> 26.03.2015 20:13, Florian Fainelli пишет:
>>> Hello,
>>>
>>> On 26/03/15 08:56, Stas Sergeev wrote:
>>>> Hello.
>>>>
>>>> The following patches are needed when mvneta is used
>>>> in SGMII mode without MDIO.
>>> Would you mind using scripts/get_maintainer.pl such that the relevant
>>> people who have touched this code in the past can be CC'd?
>>>
>>> Your patches are barely readable, let alone that you have provided
>>> little to explanation as to why you are making such invasive changes.
>> OK, will re-send tomorrow with more explanations and CCs.
>> Still not sure about "barely readable" though - I made them
>> through checkpatch.pl.
> Your commit messages are very scarce, you need to explain more what you
> are doing an why.
That's OK, will do, thanks.
You said that my patches and barely readable AND have
little explanation, so I thought you mean the code changes
itself are barely readable too.

      reply	other threads:[~2015-03-26 17:34 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-26 15:56 [PATCH 0/6] mvneta: SGMII-based in-band link status signaling Stas Sergeev
2015-03-26 15:58 ` [PATCH 1/6] restructure of_phy_register_fixed_link() for further modifications Stas Sergeev
2015-03-26 16:00   ` [PATCH 2/6] pass phy_device instead of net_device to fixed_phy link_update() function Stas Sergeev
2015-03-26 16:01     ` [PATCH 3/6] fixed_phy: add fixed_phy_unregister() Stas Sergeev
2015-03-26 16:02       ` [PATCH 4/6] of: add API for changing parameters of fixed link Stas Sergeev
2015-03-26 16:03         ` [PATCH 5/6] mvneta: implement SGMII-based in-band link status signaling Stas Sergeev
2015-03-26 16:04           ` [PATCH 6/6] mvneta: port marvell's official in-band status enabling procedure Stas Sergeev
2015-03-26 22:49     ` [PATCH 2/6] pass phy_device instead of net_device to fixed_phy link_update() function David Miller
2015-03-26 22:55       ` Stas Sergeev
2015-03-26 22:59         ` Thomas Petazzoni
2015-03-26 19:01   ` [PATCH 1/6] restructure of_phy_register_fixed_link() for further modifications Sergei Shtylyov
2015-03-26 20:26     ` Stas Sergeev
2015-03-26 17:13 ` [PATCH 0/6] mvneta: SGMII-based in-band link status signaling Florian Fainelli
2015-03-26 17:23   ` Stas Sergeev
2015-03-26 17:29     ` Florian Fainelli
2015-03-26 17:34       ` Stas Sergeev [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55144329.3040501@list.ru \
    --to=stsp@list.ru \
    --cc=f.fainelli@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=thomas.petazzoni@free-electrons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.