From: Waiman Long <waiman.long@hp.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: linux-arch@vger.kernel.org, riel@redhat.com, x86@kernel.org,
kvm@vger.kernel.org, scott.norton@hp.com,
raghavendra.kt@linux.vnet.ibm.com, paolo.bonzini@gmail.com,
oleg@redhat.com, linux-kernel@vger.kernel.org, mingo@redhat.com,
david.vrabel@citrix.com, hpa@zytor.com, luto@amacapital.net,
xen-devel@lists.xenproject.org, tglx@linutronix.de,
paulmck@linux.vnet.ibm.com, torvalds@linux-foundation.org,
boris.ostrovsky@oracle.com,
virtualization@lists.linux-foundation.org, doug.hatch@hp.com
Subject: Re: [PATCH 8/9] qspinlock: Generic paravirt support
Date: Wed, 01 Apr 2015 16:10:34 -0400 [thread overview]
Message-ID: <551C50BA.8070308__24684.5179507092$1427919157$gmane$org@hp.com> (raw)
In-Reply-To: <20150401171223.GO23123@twins.programming.kicks-ass.net>
On 04/01/2015 01:12 PM, Peter Zijlstra wrote:
> On Wed, Apr 01, 2015 at 12:20:30PM -0400, Waiman Long wrote:
>> After more careful reading, I think the assumption that the presence of an
>> unused bucket means there is no match is not true. Consider the scenario:
>>
>> 1. cpu 0 puts lock1 into hb[0]
>> 2. cpu 1 puts lock2 into hb[1]
>> 3. cpu 2 clears hb[0]
>> 4. cpu 3 looks for lock2 and doesn't find it
> Hmm, yes. The only way I can see that being true is if we assume entries
> are never taken out again.
>
> The wikipedia page could use some clarification here, this is not clear.
>
>> At this point, I am thinking using back your previous idea of passing the
>> queue head information down the queue.
> Having to scan the entire array for a lookup sure sucks, but the wait
> loops involved in the other idea can get us in the exact predicament we
> were trying to get out, because their forward progress depends on other
> CPUs.
For the waiting loop, the worst case is when a new CPU get queued right
before we write the head value to the previous tail node. In the case,
the maximum number of retries is equal to the total number of CPUs - 2.
But that should rarely happen.
I do find a way to guarantee forward progress in a few steps. I will try
the normal way once. If that fails, I will insert the head node to the
tail once again after saving the next pointer. After modifying the
previous tail node, cmpxchg will be used to restore the previous tail.
If that fails, we just have to wait until the next pointer is updated
and write it out to the previous tail node. We can now restore the next
pointer and move forward.
Let me know if that looks reasonable to you.
-Longman
next prev parent reply other threads:[~2015-04-01 20:10 UTC|newest]
Thread overview: 135+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-16 13:16 [PATCH 0/9] qspinlock stuff -v15 Peter Zijlstra
2015-03-16 13:16 ` Peter Zijlstra
2015-03-16 13:16 ` [PATCH 1/9] qspinlock: A simple generic 4-byte queue spinlock Peter Zijlstra
2015-03-16 13:16 ` Peter Zijlstra
2015-03-16 13:16 ` Peter Zijlstra
2015-03-16 13:16 ` [PATCH 2/9] qspinlock, x86: Enable x86-64 to use " Peter Zijlstra
2015-03-16 13:16 ` Peter Zijlstra
2015-03-16 13:16 ` Peter Zijlstra
2015-03-16 13:16 ` [PATCH 3/9] qspinlock: Add pending bit Peter Zijlstra
2015-03-16 13:16 ` Peter Zijlstra
2015-03-16 13:16 ` Peter Zijlstra
2015-03-16 13:16 ` [PATCH 4/9] qspinlock: Extract out code snippets for the next patch Peter Zijlstra
2015-03-16 13:16 ` Peter Zijlstra
2015-03-16 13:16 ` Peter Zijlstra
2015-03-16 13:16 ` [PATCH 5/9] qspinlock: Optimize for smaller NR_CPUS Peter Zijlstra
2015-03-16 13:16 ` Peter Zijlstra
2015-03-16 13:16 ` Peter Zijlstra
2015-03-16 13:16 ` [PATCH 6/9] qspinlock: Use a simple write to grab the lock Peter Zijlstra
2015-03-16 13:16 ` Peter Zijlstra
2015-03-16 13:16 ` Peter Zijlstra
2015-03-16 13:16 ` [PATCH 7/9] qspinlock: Revert to test-and-set on hypervisors Peter Zijlstra
2015-03-16 13:16 ` Peter Zijlstra
2015-03-16 13:16 ` Peter Zijlstra
2015-03-16 13:16 ` [PATCH 8/9] qspinlock: Generic paravirt support Peter Zijlstra
2015-03-16 13:16 ` Peter Zijlstra
2015-03-18 20:50 ` Waiman Long
2015-03-19 10:12 ` Peter Zijlstra
2015-03-19 10:12 ` Peter Zijlstra
2015-03-19 10:12 ` Peter Zijlstra
2015-03-19 12:25 ` Peter Zijlstra
2015-03-19 12:25 ` Peter Zijlstra
2015-03-19 13:43 ` Peter Zijlstra
2015-03-19 13:43 ` Peter Zijlstra
2015-03-19 13:43 ` Peter Zijlstra
2015-03-19 23:25 ` Waiman Long
2015-03-19 23:25 ` Waiman Long
2015-03-19 23:25 ` Waiman Long
2015-04-01 16:20 ` Waiman Long
2015-04-01 16:20 ` Waiman Long
2015-04-01 16:20 ` Waiman Long
2015-04-01 17:12 ` Peter Zijlstra
2015-04-01 17:12 ` Peter Zijlstra
2015-04-01 17:12 ` Peter Zijlstra
2015-04-01 17:42 ` Peter Zijlstra
2015-04-01 17:42 ` Peter Zijlstra
2015-04-01 18:17 ` Peter Zijlstra
2015-04-01 18:17 ` Peter Zijlstra
2015-04-01 18:54 ` Waiman Long
2015-04-01 18:54 ` Waiman Long
2015-04-01 18:48 ` Peter Zijlstra
2015-04-01 18:48 ` Peter Zijlstra
2015-04-01 19:58 ` Waiman Long
2015-04-01 21:03 ` Peter Zijlstra
2015-04-01 21:03 ` Peter Zijlstra
2015-04-01 21:03 ` Peter Zijlstra
2015-04-02 16:28 ` Waiman Long
2015-04-02 17:20 ` Peter Zijlstra
2015-04-02 17:20 ` Peter Zijlstra
2015-04-02 19:48 ` Peter Zijlstra
2015-04-02 19:48 ` Peter Zijlstra
2015-04-03 3:39 ` Waiman Long
2015-04-03 3:39 ` Waiman Long
2015-04-03 3:39 ` Waiman Long
2015-04-03 13:43 ` Peter Zijlstra
2015-04-03 13:43 ` Peter Zijlstra
2015-04-03 13:43 ` Peter Zijlstra
2015-04-02 19:48 ` Peter Zijlstra
2015-04-02 17:20 ` Peter Zijlstra
2015-04-02 16:28 ` Waiman Long
2015-04-02 16:28 ` Waiman Long
2015-04-01 19:58 ` Waiman Long
2015-04-01 19:58 ` Waiman Long
2015-04-01 18:48 ` Peter Zijlstra
2015-04-01 18:54 ` Waiman Long
2015-04-01 18:17 ` Peter Zijlstra
2015-04-01 17:42 ` Peter Zijlstra
2015-04-01 20:10 ` Waiman Long
2015-04-01 20:10 ` Waiman Long
2015-04-01 20:10 ` Waiman Long [this message]
2015-03-19 12:25 ` Peter Zijlstra
2015-03-18 20:50 ` Waiman Long
2015-03-16 13:16 ` Peter Zijlstra
2015-03-16 13:16 ` [PATCH 9/9] qspinlock, x86, kvm: Implement KVM support for paravirt qspinlock Peter Zijlstra
2015-03-16 13:16 ` [PATCH 9/9] qspinlock,x86,kvm: " Peter Zijlstra
2015-03-16 13:16 ` [PATCH 9/9] qspinlock, x86, kvm: " Peter Zijlstra
2015-03-19 2:45 ` Waiman Long
2015-03-19 10:01 ` Peter Zijlstra
2015-03-19 10:01 ` [PATCH 9/9] qspinlock,x86,kvm: " Peter Zijlstra
2015-03-19 10:01 ` Peter Zijlstra
2015-03-19 21:08 ` [PATCH 9/9] qspinlock, x86, kvm: " Waiman Long
2015-03-19 21:08 ` [PATCH 9/9] qspinlock,x86,kvm: " Waiman Long
2015-03-19 21:08 ` [PATCH 9/9] qspinlock, x86, kvm: " Waiman Long
2015-03-20 7:43 ` Raghavendra K T
2015-03-20 7:43 ` [PATCH 9/9] qspinlock,x86,kvm: " Raghavendra K T
2015-03-20 7:43 ` [PATCH 9/9] qspinlock, x86, kvm: " Raghavendra K T
2015-03-19 2:45 ` Waiman Long
2015-03-16 14:08 ` [PATCH 0/9] qspinlock stuff -v15 David Vrabel
2015-03-16 14:08 ` [Xen-devel] " David Vrabel
2015-03-16 14:08 ` David Vrabel
2015-03-16 14:08 ` David Vrabel
2015-03-16 14:08 ` David Vrabel
2015-03-18 20:36 ` Waiman Long
2015-03-18 20:36 ` Waiman Long
2015-03-18 20:36 ` Waiman Long
2015-03-19 18:01 ` [Xen-devel] " David Vrabel
2015-03-19 18:01 ` David Vrabel
2015-03-19 18:01 ` David Vrabel
2015-03-19 18:32 ` Peter Zijlstra
2015-03-19 18:32 ` Peter Zijlstra
2015-03-19 18:32 ` Peter Zijlstra
2015-03-19 18:01 ` David Vrabel
2015-03-25 19:47 ` Konrad Rzeszutek Wilk
2015-03-26 20:21 ` Peter Zijlstra
2015-03-26 20:21 ` Peter Zijlstra
2015-03-26 20:21 ` Peter Zijlstra
2015-03-27 14:07 ` Konrad Rzeszutek Wilk
2015-03-27 14:07 ` Konrad Rzeszutek Wilk
2015-03-27 14:07 ` Konrad Rzeszutek Wilk
2015-03-30 16:41 ` Waiman Long
2015-03-30 16:41 ` Waiman Long
2015-03-30 16:41 ` Waiman Long
2015-03-30 16:25 ` Waiman Long
2015-03-30 16:25 ` Waiman Long
2015-03-30 16:29 ` Peter Zijlstra
2015-03-30 16:29 ` Peter Zijlstra
2015-03-30 16:43 ` Waiman Long
2015-03-30 16:43 ` Waiman Long
2015-03-30 16:43 ` Waiman Long
2015-03-30 16:29 ` Peter Zijlstra
2015-03-30 16:25 ` Waiman Long
2015-03-25 19:47 ` Konrad Rzeszutek Wilk
2015-03-25 19:47 ` Konrad Rzeszutek Wilk
2015-03-27 6:40 ` Raghavendra K T
2015-03-27 6:40 ` Raghavendra K T
2015-03-27 6:40 ` Raghavendra K T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='551C50BA.8070308__24684.5179507092$1427919157$gmane$org@hp.com' \
--to=waiman.long@hp.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=doug.hatch@hp.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@redhat.com \
--cc=oleg@redhat.com \
--cc=paolo.bonzini@gmail.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=raghavendra.kt@linux.vnet.ibm.com \
--cc=riel@redhat.com \
--cc=scott.norton@hp.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.