From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752733AbbEKVjP (ORCPT ); Mon, 11 May 2015 17:39:15 -0400 Received: from cantor2.suse.de ([195.135.220.15]:59235 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752474AbbEKVjM (ORCPT ); Mon, 11 May 2015 17:39:12 -0400 Message-ID: <5551217C.9090504@suse.de> Date: Mon, 11 May 2015 23:39:08 +0200 From: =?windows-1252?Q?Andreas_F=E4rber?= Organization: SUSE Linux GmbH User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Russell King - ARM Linux , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH] Show proper respect for Heinrich Hertz by using the correct unit for frequency References: <20150511131952.GD2067@n2100.arm.linux.org.uk> In-Reply-To: <20150511131952.GD2067@n2100.arm.linux.org.uk> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 11.05.2015 um 15:19 schrieb Russell King - ARM Linux: > The SI unit of frequency is Hertz, named after Heinrich Hertz, and is > given the symbol "Hz" to denote this. "hz" is not the unit of frequency, > and is in fact meaningless. > > Fix arch/arm to correctly use "Hz", thereby acknowledging Heinrich Hertz > contribution to the modern world. > > Signed-off-by: Russell King Nice. :) Since you're being exact, should it be "Hertz' contribution"? > diff --git a/arch/arm/boot/dts/omap3-cm-t3517.dts b/arch/arm/boot/dts/omap3-cm-t3517.dts > index f5b5a1d96cd7..53ae04f9104d 100644 > --- a/arch/arm/boot/dts/omap3-cm-t3517.dts > +++ b/arch/arm/boot/dts/omap3-cm-t3517.dts > @@ -66,7 +66,7 @@ > > otg_drv_vbus: pinmux_otg_drv_vbus { > pinctrl-single,pins = < > - OMAP3_CORE1_IOPAD(0x2210, PIN_INPUT_PULLDOWN | MUX_MODE0) /* rmii_50Mhz_clk.usb0_drvvbus */ > + OMAP3_CORE1_IOPAD(0x2210, PIN_INPUT_PULLDOWN | MUX_MODE0) /* rmii_50MHz_clk.usb0_drvvbus */ This one looks like an identifier - did you check where it comes from and whether it needs to be fixed there as well? > >; > }; > Rest looks good, Reviewed-by: Andreas Färber Cheers, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB 21284 (AG Nürnberg) From mboxrd@z Thu Jan 1 00:00:00 1970 From: afaerber@suse.de (=?windows-1252?Q?Andreas_F=E4rber?=) Date: Mon, 11 May 2015 23:39:08 +0200 Subject: [PATCH] Show proper respect for Heinrich Hertz by using the correct unit for frequency In-Reply-To: <20150511131952.GD2067@n2100.arm.linux.org.uk> References: <20150511131952.GD2067@n2100.arm.linux.org.uk> Message-ID: <5551217C.9090504@suse.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Am 11.05.2015 um 15:19 schrieb Russell King - ARM Linux: > The SI unit of frequency is Hertz, named after Heinrich Hertz, and is > given the symbol "Hz" to denote this. "hz" is not the unit of frequency, > and is in fact meaningless. > > Fix arch/arm to correctly use "Hz", thereby acknowledging Heinrich Hertz > contribution to the modern world. > > Signed-off-by: Russell King Nice. :) Since you're being exact, should it be "Hertz' contribution"? > diff --git a/arch/arm/boot/dts/omap3-cm-t3517.dts b/arch/arm/boot/dts/omap3-cm-t3517.dts > index f5b5a1d96cd7..53ae04f9104d 100644 > --- a/arch/arm/boot/dts/omap3-cm-t3517.dts > +++ b/arch/arm/boot/dts/omap3-cm-t3517.dts > @@ -66,7 +66,7 @@ > > otg_drv_vbus: pinmux_otg_drv_vbus { > pinctrl-single,pins = < > - OMAP3_CORE1_IOPAD(0x2210, PIN_INPUT_PULLDOWN | MUX_MODE0) /* rmii_50Mhz_clk.usb0_drvvbus */ > + OMAP3_CORE1_IOPAD(0x2210, PIN_INPUT_PULLDOWN | MUX_MODE0) /* rmii_50MHz_clk.usb0_drvvbus */ This one looks like an identifier - did you check where it comes from and whether it needs to be fixed there as well? > >; > }; > Rest looks good, Reviewed-by: Andreas F?rber Cheers, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany GF: Felix Imend?rffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N?rnberg)