From: Olivier MATZ <olivier.matz@6wind.com>
To: Keith Wiles <keith.wiles@intel.com>, dev@dpdk.org
Subject: Re: [PATCH v7 1/2] Simplify the ifdefs in rte.app.mk
Date: Tue, 12 May 2015 17:44:09 +0200 [thread overview]
Message-ID: <55521FC9.2020000@6wind.com> (raw)
In-Reply-To: <1431386066-6147-1-git-send-email-keith.wiles@intel.com>
Hi Keith,
On 05/12/2015 01:14 AM, Keith Wiles wrote:
> Trying to simplify the ifdefs in rte.app.mk to make the code
> more readable and maintainable by moving LDLIBS variable to use
> the same style as LDLIBS-y being used in the rest of the code.
>
> Added a new variable called EXTRA_LDLIBS to be used by example apps
> instead of using LDLIBS directly. The new internal variable _LDLIBS
> should not be used outside of the rte.app.mk file.
>
> Signed-off-by: Keith Wiles <keith.wiles@intel.com>
Sorry to comment again :)
I think it should be split differently, by topic/feature and not
by location (mk vs doc)
The first commit should only do what the title says, which is
"simplify the makefile", and not add the EXTRA_LIBS variable.
The second commit should add the EXTRA_LIBS + the associated doc.
Few nits:
- the commit log is right-shifted
- the titles could be prefixed by "mk:"
- don't forget the "--in-reply-to" :)
Regards,
Olivier
next prev parent reply other threads:[~2015-05-12 15:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <017274>
2015-05-11 23:14 ` [PATCH v7 1/2] Simplify the ifdefs in rte.app.mk Keith Wiles
2015-05-11 23:14 ` [PATCH v7 2/2] Update Docs for new EXTRA_LDLIBS variable Keith Wiles
2015-05-12 15:44 ` Olivier MATZ [this message]
2015-05-12 19:11 ` [PATCH v8 1/2] mk:Simplify the ifdefs in rte.app.mk Keith Wiles
2015-05-12 19:11 ` [PATCH v8 2/2] mk:Update Docs for new EXTRA_LDLIBS variable Keith Wiles
2015-05-13 7:41 ` [PATCH v8 1/2] mk:Simplify the ifdefs in rte.app.mk Olivier MATZ
2015-05-13 13:17 ` Wiles, Keith
2015-05-13 13:56 ` Olivier MATZ
2015-05-13 14:04 ` Wiles, Keith
2015-05-13 14:28 ` Olivier MATZ
2015-05-13 14:34 ` Wiles, Keith
2015-05-13 16:35 ` [PATCH v9 1/2] mk:Simplify the ifdefs in the makefile Keith Wiles
2015-05-13 16:35 ` [PATCH v9 2/2] mk:Introduce the EXTRA_LDLIBS variable Keith Wiles
2015-05-14 12:30 ` [PATCH v9 1/2] mk:Simplify the ifdefs in the makefile Olivier MATZ
2015-05-14 15:14 ` Wiles, Keith
2015-05-14 14:21 ` [PATCH v10 " Keith Wiles
2015-05-14 14:21 ` [PATCH v10 2/2] mk:Introduce the EXTRA_LDLIBS variable Keith Wiles
2015-05-14 15:42 ` [PATCH v10 1/2] mk:Simplify the ifdefs in the makefile Olivier MATZ
2015-05-14 21:38 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55521FC9.2020000@6wind.com \
--to=olivier.matz@6wind.com \
--cc=dev@dpdk.org \
--cc=keith.wiles@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.