From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965413AbbEMVlx (ORCPT ); Wed, 13 May 2015 17:41:53 -0400 Received: from lists.s-osg.org ([54.187.51.154]:60249 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933971AbbEMVlw (ORCPT ); Wed, 13 May 2015 17:41:52 -0400 Message-ID: <5553C51B.6080504@osg.samsung.com> Date: Wed, 13 May 2015 15:41:47 -0600 From: Shuah Khan Organization: Samsung Open Source Group User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: tyler.baker@linaro.org CC: Andy Lutomirski , Kevin Hilman , John Stultz , Darren Hart , Michael Ellerman , David Herrmann , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Shuah Khan Subject: Re: [PATCH 2/2] selftests/breakpoints: only set TEST_PROGS when built References: <1431467947-29847-1-git-send-email-tyler.baker@linaro.org> <1431467947-29847-3-git-send-email-tyler.baker@linaro.org> In-Reply-To: <1431467947-29847-3-git-send-email-tyler.baker@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/12/2015 03:59 PM, tyler.baker@linaro.org wrote: > From: Tyler Baker > > Set TEST_PROGS only when a build has occurred. > > Signed-off-by: Tyler Baker > --- > tools/testing/selftests/breakpoints/Makefile | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/breakpoints/Makefile b/tools/testing/selftests/breakpoints/Makefile > index 1822356..54cc3e7 100644 > --- a/tools/testing/selftests/breakpoints/Makefile > +++ b/tools/testing/selftests/breakpoints/Makefile > @@ -12,12 +12,11 @@ endif > all: > ifeq ($(ARCH),x86) > gcc breakpoint_test.c -o breakpoint_test > + TEST_PROGS := breakpoint_test > else > echo "Not an x86 target, can't build breakpoints selftests" > endif > > -TEST_PROGS := breakpoint_test > - > include ../lib.mk > > clean: > Hmm. With this change install fails to copy breakpoint_test all together. Remember setting TEST_PROGS in compile step makes it not stick around when install target is called. A better approach would be the following: if [ -f breakpoint_test ] TEST_PROGS := breakpoint_test fi include ../lib.mk -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh@osg.samsung.com | (970) 217-8978 From mboxrd@z Thu Jan 1 00:00:00 1970 From: shuahkh@osg.samsung.com (Shuah Khan) Date: Wed, 13 May 2015 15:41:47 -0600 Subject: [PATCH 2/2] selftests/breakpoints: only set TEST_PROGS when built In-Reply-To: <1431467947-29847-3-git-send-email-tyler.baker@linaro.org> References: <1431467947-29847-1-git-send-email-tyler.baker@linaro.org> <1431467947-29847-3-git-send-email-tyler.baker@linaro.org> Message-ID: <5553C51B.6080504@osg.samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 05/12/2015 03:59 PM, tyler.baker at linaro.org wrote: > From: Tyler Baker > > Set TEST_PROGS only when a build has occurred. > > Signed-off-by: Tyler Baker > --- > tools/testing/selftests/breakpoints/Makefile | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/breakpoints/Makefile b/tools/testing/selftests/breakpoints/Makefile > index 1822356..54cc3e7 100644 > --- a/tools/testing/selftests/breakpoints/Makefile > +++ b/tools/testing/selftests/breakpoints/Makefile > @@ -12,12 +12,11 @@ endif > all: > ifeq ($(ARCH),x86) > gcc breakpoint_test.c -o breakpoint_test > + TEST_PROGS := breakpoint_test > else > echo "Not an x86 target, can't build breakpoints selftests" > endif > > -TEST_PROGS := breakpoint_test > - > include ../lib.mk > > clean: > Hmm. With this change install fails to copy breakpoint_test all together. Remember setting TEST_PROGS in compile step makes it not stick around when install target is called. A better approach would be the following: if [ -f breakpoint_test ] TEST_PROGS := breakpoint_test fi include ../lib.mk -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh at osg.samsung.com | (970) 217-8978