From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58255) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yskum-0001LZ-7j for qemu-devel@nongnu.org; Thu, 14 May 2015 00:38:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yskuj-0001kq-3E for qemu-devel@nongnu.org; Thu, 14 May 2015 00:38:32 -0400 Received: from v220110690675601.yourvserver.net ([37.221.199.173]:43142) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yskui-0001jQ-TG for qemu-devel@nongnu.org; Thu, 14 May 2015 00:38:29 -0400 Message-ID: <555426C0.9020402@weilnetz.de> Date: Thu, 14 May 2015 06:38:24 +0200 From: Stefan Weil MIME-Version: 1.0 References: <20150513174204.GS23627@redhat.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefano Stabellini , "Daniel P. Berrange" Cc: pbonzini@redhat.com, rth@twiddle.net, xen-devel@lists.xensource.com, qemu-devel@nongnu.org, mst@redhat.com Am 13.05.2015 um 20:15 schrieb Stefano Stabellini: > On Wed, 13 May 2015, Daniel P. Berrange wrote: >> On Wed, May 13, 2015 at 06:29:46PM +0100, Stefano Stabellini wrote: >>> Do not emulate a floppy drive if no drives are supposed to be present. >>> >>> This fixes the behavior of -nodefaults, that should remove the floppy >>> drive (see docs/qdev-device-use.txt:Default Devices), but actually >>> doesn't. >> Technically that doc is just refering to the disablement of the >> primary floppy drive, as opposed to the floppy controller. The >> floppy controller itself is really a built-in device that is >> defined as part of the machine type, along with the various other >> platform devices hanging off the PIIX and ISA brige. > I think you are right, this patch is a bit too harsh in fixing the > problem: I just wanted to properly disable drive emulation, because from > my tests the guest thinks that one drive is present even when is not. A short test on some of my physical machines shows that most of them don't have a floppy disk controller at all (dmesg | grep FDC). Only some older machines still have one. Therefore I think that QEMU must also be able to offer a virtual machine without an FDC, maybe as the default for the next version of QEMU. Stefan From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Weil Subject: Re: [PATCH] Do not emulate a floppy drive when -nodefaults Date: Thu, 14 May 2015 06:38:24 +0200 Message-ID: <555426C0.9020402@weilnetz.de> References: <20150513174204.GS23627@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org To: Stefano Stabellini , "Daniel P. Berrange" Cc: pbonzini@redhat.com, rth@twiddle.net, xen-devel@lists.xensource.com, qemu-devel@nongnu.org, mst@redhat.com List-Id: xen-devel@lists.xenproject.org Am 13.05.2015 um 20:15 schrieb Stefano Stabellini: > On Wed, 13 May 2015, Daniel P. Berrange wrote: >> On Wed, May 13, 2015 at 06:29:46PM +0100, Stefano Stabellini wrote: >>> Do not emulate a floppy drive if no drives are supposed to be present. >>> >>> This fixes the behavior of -nodefaults, that should remove the floppy >>> drive (see docs/qdev-device-use.txt:Default Devices), but actually >>> doesn't. >> Technically that doc is just refering to the disablement of the >> primary floppy drive, as opposed to the floppy controller. The >> floppy controller itself is really a built-in device that is >> defined as part of the machine type, along with the various other >> platform devices hanging off the PIIX and ISA brige. > I think you are right, this patch is a bit too harsh in fixing the > problem: I just wanted to properly disable drive emulation, because from > my tests the guest thinks that one drive is present even when is not. A short test on some of my physical machines shows that most of them don't have a floppy disk controller at all (dmesg | grep FDC). Only some older machines still have one. Therefore I think that QEMU must also be able to offer a virtual machine without an FDC, maybe as the default for the next version of QEMU. Stefan