From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932771AbbENPBq (ORCPT ); Thu, 14 May 2015 11:01:46 -0400 Received: from eu-smtp-delivery-143.mimecast.com ([146.101.78.143]:32219 "EHLO eu-smtp-delivery-143.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750956AbbENPBp convert rfc822-to-8bit (ORCPT ); Thu, 14 May 2015 11:01:45 -0400 Message-ID: <5554B8D8.8090006@arm.com> Date: Thu, 14 May 2015 16:01:44 +0100 From: Juri Lelli User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Doug Smythies , "peterz@infradead.org" , "'Ingo Molnar'" CC: "linux-kernel@vger.kernel.org" Subject: Re: On resume from suspend only CPU 0 comes back on-line [REGRESSION][BISECTED] References: <004801d08e54$20d5bd60$62813820$@net> In-Reply-To: <004801d08e54$20d5bd60$62813820$@net> X-OriginalArrivalTime: 14 May 2015 15:01:42.0520 (UTC) FILETIME=[E347A780:01D08E56] X-MC-Unique: X7OOVl0OTnWBGEj4Ecq0QQ-1 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Doug, On 14/05/15 15:41, Doug Smythies wrote: > As of, or about, Kernel 4.1RC1 on resume from suspend only CPU 0 comes back on-line. > The issue persists through Kernel 4.1RC3. > This is on my test computer with an i7-2600K. > I do not normally use suspend on this computer, but was doing so while working on a bug report. > > The kernel was bisected, and this is the result: > Does commit 533445c6e533 "sched/core: Fix regression in cpuset_cpu_inactive() for suspend" on tip/sched/core fix the bug? Thanks, - Juri > 3c18d447b3b36a8d3c90dc37dfbd363cdb685d0a is the first bad commit > commit 3c18d447b3b36a8d3c90dc37dfbd363cdb685d0a > Author: Juri Lelli > Date: Tue Mar 31 09:53:37 2015 +0100 > > sched/core: Check for available DL bandwidth in cpuset_cpu_inactive() > > Hotplug operations are destructive w.r.t. cpusets. In case such an > operation is performed on a CPU belonging to an exlusive cpuset, the > DL bandwidth information associated with the corresponding root > domain is gone even if the operation fails (in sched_cpu_inactive()). > > For this reason we need to move the check we currently have in > sched_cpu_inactive() to cpuset_cpu_inactive() to prevent useless > cpusets reconfiguration in the CPU_DOWN_FAILED path. > > Signed-off-by: Juri Lelli > Signed-off-by: Peter Zijlstra (Intel) > Cc: Juri Lelli > Link: http://lkml.kernel.org/r/1427792017-7356-2-git-send-email-juri.lelli@arm.com > Signed-off-by: Ingo Molnar > > :040000 040000 10f8d81afdc8e625f8e6720883d3eb42c28d452b c08264528890941bad35d5d4cc134c03f259c534 M kernel > > Since I sometimes mess up using git bisect, and end up at some random result, > the above was double checked manually: > > 3c18d447b3b36a8d3c90dc37dfbd363cdb685d0a has the issue. > 4cd57f97135840f637431c92380c8da3edbe44ed (the previous commit) does not have the issue. > >