From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54009) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YswJC-0006Mn-Hd for qemu-devel@nongnu.org; Thu, 14 May 2015 12:48:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YswJ9-0000d5-A7 for qemu-devel@nongnu.org; Thu, 14 May 2015 12:48:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45754) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YswJ9-0000cU-5K for qemu-devel@nongnu.org; Thu, 14 May 2015 12:48:27 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id A9E2B8E901 for ; Thu, 14 May 2015 16:48:26 +0000 (UTC) Message-ID: <5554D1D9.3060108@redhat.com> Date: Thu, 14 May 2015 10:48:25 -0600 From: Eric Blake MIME-Version: 1.0 References: <1431432187-10993-1-git-send-email-armbru@redhat.com> <1431432187-10993-6-git-send-email-armbru@redhat.com> In-Reply-To: <1431432187-10993-6-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="NugjuTrKw09S2sDpCirGUgnMQMrgF6cgV" Subject: Re: [Qemu-devel] [PATCH 05/15] tap: net_tap_fd_init() can't fail, drop dead error handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --NugjuTrKw09S2sDpCirGUgnMQMrgF6cgV Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/12/2015 06:02 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > net/tap.c | 14 +------------- > 1 file changed, 1 insertion(+), 13 deletions(-) >=20 > @@ -552,14 +551,8 @@ int net_init_bridge(const NetClientOptions *opts, = const char *name, > } > =20 > fcntl(fd, F_SETFL, O_NONBLOCK); Well, fcntl() could fail. And don't we have the helper function util/oslib-posix.c:qemu_set_nonblock() for doing this correctly? (Then again, that helper also ignores failures). But the raw use of fcntl here is pre-existing and you didn't touch it, so it doesn't affect my review of this patch. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --NugjuTrKw09S2sDpCirGUgnMQMrgF6cgV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVVNHZAAoJEKeha0olJ0Nqx+4H/j89jfgmmuQA818/5iIOAZIy DPq/EUAC2A5Yijogmev4nbL1GLfwWz4WUKjHvnM37iTVT6Vz26hCgapMibEEuONV RBRGs3ZWQQbv4oEu+2tm9mLHpbPhFe5Npo/qDJYwLxC/A7O7wpGnaSiVTGzfZ1SC OqrDg/6EBxJUHDcPSlxfA7iC8miIlRy0ZfVITExMjSDd1XgqzRN/FoL9BoKsptvV DiAf8VZlYT6f3yaStoafU9hzmLtPesObnR+Srv/zg2l3J/ZM2uh91AxrW3DQY0tn 5uKB9eO7LePjSOZk8vCMeyGNioE0/2zLwlZKtcZtXYy1dqbYvmwkjMiC1Xy3kPU= =SZZS -----END PGP SIGNATURE----- --NugjuTrKw09S2sDpCirGUgnMQMrgF6cgV--