From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Tue, 1 Sep 2015 13:13:30 -0700 Subject: [U-Boot] [PATCH v2 4/4] distro_bootcmd: Add support for booting from ubifs In-Reply-To: <1440266693-15664-5-git-send-email-hdegoede@redhat.com> References: <1440266693-15664-1-git-send-email-hdegoede@redhat.com> <1440266693-15664-5-git-send-email-hdegoede@redhat.com> Message-ID: <55E606EA.9020103@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 08/22/2015 11:04 AM, Hans de Goede wrote: > From: Roy Spliet > > Under the assumptions of having a UBI volume called boot, containing > a ubifs filesystem. > > Signed-off-by: Hans de Goede I'd expect the person in the "From:" line above to have an s-o-b line too. If the patch has changed so much that isn't appropriate, perhaps change the patch's git author to you and just mentioned "Based on work by: Roy ..."? > diff --git a/include/config_distro_bootcmd.h b/include/config_distro_bootcmd.h > +#ifdef CONFIG_CMD_UBIFS > +#define BOOTENV_SHARED_UBIFS \ > + "ubifs_boot=" \ > + "if ubi part UBI && ubifsmount ubi${devnum}:boot; then " \ I don't know ubifs well enough to know the implications of that particular set of ubi commands, but as far as the impact-on/integration-into the bootcmd.h file, this patch looks fine. Acked-by: Stephen Warren