Hi Heiko,

On 09/02/2015 10:15 AM, Yakir Yang wrote:

Hi Heiko,

在 09/02/2015 05:47 AM, Heiko Stuebner 写道:

Hi Yakir,

Am Dienstag, 1. September 2015, 13:46:11 schrieb Yakir Yang:

    The Samsung Exynos eDP controller and Rockchip RK3288 eDP controller
share the same IP, so a lot of parts can be re-used. I split the common
code into bridge directory, then rk3288 and exynos only need to keep
some platform code. Cause I can't find the exact IP name of exynos dp
controller, so I decide to name dp core driver with "analogix" which I
find in rk3288 eDP TRM ;)

Beyond that, there are three light registers setting differents bewteen
exynos and rk3288.
1. RK3288 have five special pll resigters which not indicata in exynos
    dp controller.
2. The address of DP_PHY_PD(dp phy power manager register) are different
    between rk3288 and exynos.
3. Rk3288 and exynos have different setting with AUX_HW_RETRY_CTL(dp debug
    register).

I have verified this series on two kinds of rockchip platform board, one
is rk3288 sdk board which connect with a 2K display port monitor, the other
is google jerry chromebook which connect with a eDP screen "cnm,n116bgeea2",
both of them works rightlly.

it looks like during the rebase something did go wrong and I found some issues
I mentioned in the replies to individual patches.

I did prepare a branch based on mainline [0] with both the old and the new edp
driver - rk3288_veyron_defconfig build both drivers into the image.

While the old driver still works, I wasn't able to make the new one work yet
... the drm core does find the connector, but not that anything is connected
to it. I'll try to dig deeper tomorrow, but maybe you'll see anything
interesting before then.

Many thanks for your comment and debug, I would rebase on your
"edp-with-veyron" branch and fix the broken, make sure v6 would
work rightly at least in your side and my side.

Just like we talk off line, I guess there are two tricky questions which make analogix_dp just crash/failed on rockchip platform:

- One is how to reach a agreement with the common way to register connector. There would be a conflict with Exynos & IMX & Rockchip.
   On analogix_dp thread, Exynos want to register connector when that connector is ready.
   On dw_hdmi thread, IMX want to register connector when all component is already.
     So Exynos & IMX & Rockchip should reach a common way to register connector to fix this issue.

- The other is atomic API.
      The rockchip drm haven't implemented the atomic API, but the original exynos_dp have used the atomic API on connector helper function. That's why analogix_dp just keep crash on your side.

I have prepared the v5 version, although those would work directly on rockchip side, but I could upload some HACK patches to gerrit to make this works, hope we can keep the discussion going forward.

Thanks,
- Yakir

- Yakir

Heiko

[0] https://github.com/mmind/linux-rockchip/tree/tmp/edp-with-veyron

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip