From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2361DC433F5 for ; Sat, 25 Sep 2021 08:11:44 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB31360BD3 for ; Sat, 25 Sep 2021 08:11:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CB31360BD3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=xs4all.nl Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 21DD5834D4; Sat, 25 Sep 2021 10:11:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=xs4all.nl Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 600B2834D8; Sat, 25 Sep 2021 10:11:37 +0200 (CEST) Received: from sibelius.xs4all.nl (sibelius.xs4all.nl [83.163.83.176]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 36B5B834B8 for ; Sat, 25 Sep 2021 10:11:33 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=xs4all.nl Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=mark.kettenis@xs4all.nl Received: from localhost (bloch.sibelius.xs4all.nl [local]) by bloch.sibelius.xs4all.nl (OpenSMTPD) with ESMTPA id ee3202ee; Sat, 25 Sep 2021 10:11:23 +0200 (CEST) Date: Sat, 25 Sep 2021 10:11:23 +0200 (CEST) From: Mark Kettenis To: Simon Glass Cc: kettenis@openbsd.org, u-boot@lists.denx.de, oliver.graute@kococonnector.com, michael@walle.cc, anup.patel@wdc.com, jbalkind@ucsb.edu, tianrui-wei@outlook.com, padmarao.begari@microchip.com, kishon@ti.com, stephan@gerhold.net, xypron.glpk@gmx.de, bin.meng@windriver.com, ashe@kivikakk.ee, michal.simek@xilinx.com, wasim.khan@nxp.com, ye.li@nxp.com, igor.opaniuk@foundries.io, sr@denx.de, mk7.kang@samsung.com, takahiro.akashi@linaro.org, weijie.gao@mediatek.com, vabhav.sharma@nxp.com, andriy.shevchenko@linux.intel.com, p.yadav@ti.com In-Reply-To: (message from Simon Glass on Fri, 24 Sep 2021 19:20:32 -0600) Subject: Re: [PATCH 0/5] Apple M1 Support References: <20210918135437.36667-1-kettenis@openbsd.org> Message-ID: <5614837a43225d79@bloch.sibelius.xs4all.nl> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean > From: Simon Glass > Date: Fri, 24 Sep 2021 19:20:32 -0600 > > Hi Mark, > > On Sat, 18 Sept 2021 at 07:54, Mark Kettenis wrote: > > > > This series adds basic support for Apple's M1 SoC to U-Boot. > > This builds a basic U-Boot that can be used as a payload > > for the m1n1 boot loader being developed by the Asahi Linux > > project. > > > > The goal here is to privide an UEFI interface on these machines that > > provide > > > allows booting various open source OSes. This initial series provides > > support for the serial port, framebuffer and the USB 3.1 Type-C ports. > > It can boot a support OS (e.g. OpenBSD/arm64) from a USB disk. > > > > Mark Kettenis (5): > > arm: apple: Add initial support for Apple's M1 SoC > > serial: s5p: Add Apple M1 support > > misc: Add Apple DART driver > > arm: dts: apple: Add preliminary device trees > > doc: board: apple: Add Apple M1 documentation > > > > arch/arm/Kconfig | 22 + > > arch/arm/Makefile | 1 + > > arch/arm/dts/t8103-j274.dts | 135 +++++ > > arch/arm/dts/t8103-j293.dts | 97 ++++ > > arch/arm/dts/t8103.dtsi | 506 ++++++++++++++++++ > > arch/arm/include/asm/arch-m1/clk.h | 11 + > > arch/arm/include/asm/arch-m1/uart.h | 41 ++ > > arch/arm/mach-apple/Kconfig | 18 + > > arch/arm/mach-apple/Makefile | 4 + > > arch/arm/mach-apple/board.c | 163 ++++++ > > arch/arm/mach-apple/lowlevel_init.S | 16 + > > configs/apple_m1_defconfig | 14 + > > doc/board/apple/index.rst | 9 + > > doc/board/apple/m1.rst | 54 ++ > > doc/board/index.rst | 1 + > > drivers/misc/Kconfig | 7 + > > drivers/misc/Makefile | 1 + > > drivers/misc/apple_dart.c | 171 ++++++ > > drivers/serial/Kconfig | 2 +- > > drivers/serial/serial_s5p.c | 22 + > > include/configs/apple.h | 38 ++ > > .../interrupt-controller/apple-aic.h | 15 + > > include/dt-bindings/pinctrl/apple.h | 13 + > > include/dt-bindings/spmi/spmi.h | 10 + > > 24 files changed, 1370 insertions(+), 1 deletion(-) > > create mode 100644 arch/arm/dts/t8103-j274.dts > > create mode 100644 arch/arm/dts/t8103-j293.dts > > create mode 100644 arch/arm/dts/t8103.dtsi > > create mode 100644 arch/arm/include/asm/arch-m1/clk.h > > create mode 100644 arch/arm/include/asm/arch-m1/uart.h > > create mode 100644 arch/arm/mach-apple/Kconfig > > create mode 100644 arch/arm/mach-apple/Makefile > > create mode 100644 arch/arm/mach-apple/board.c > > create mode 100644 arch/arm/mach-apple/lowlevel_init.S > > create mode 100644 configs/apple_m1_defconfig > > create mode 100644 doc/board/apple/index.rst > > create mode 100644 doc/board/apple/m1.rst > > create mode 100644 drivers/misc/apple_dart.c > > create mode 100644 include/configs/apple.h > > create mode 100644 include/dt-bindings/interrupt-controller/apple-aic.h > > create mode 100644 include/dt-bindings/pinctrl/apple.h > > create mode 100644 include/dt-bindings/spmi/spmi.h > > > > -- > > 2.33.0 > > > > I gave this a whirl on a Macbook Air A2337 and needed the patch below > to build the devicetree files. Sorry the formatting is broken. > > Also when booting I get this: > > ... > Preparing to boot kernel at 0x808200000 with fdt at 0x8082e8000 > Valid payload found > Preparing to run next stage at 0x808200000... > MMU: shutting down... > MMU: shutdown successful, clearing caches > > > Then the display clears and it hangs. If I try the J274 devicetree it > just reboots at that point. > > What should I expect? I was hoping for console output as I don't have > serial connected. I don't have a suitable serial cable, and the USB > gadget mode did not result in a ttyACM0 device appearing. For framebuffer support you also need the "30bpp framebuffer support" series I posted earlier: https://patchwork.ozlabs.org/project/uboot/list/?series=262617 With that your should get the usual U-Boot output on the screen. I've not tested the Air, but it should work there. I'll probably post a v2 of that series this weekend as I fixed the EFI GOP support with the help of Heinrich. But that shouldn't matter for U-Boot itself. Regarding the device tree, I was afraid that setting CONFIG_DEFAULT_DEVICE_TREE would make the distroboot commands try to load a device tree from disk before loading the EFI bootloader, but it looks I was mistaken there. It still is a little bit pointless to build the device tree and a u-boot.bin that includes it, but if that makes you happier, I'll add it to the series. Cheers, Mark > Subject: [PATCH] Fix up devicetree > > Get these building. > > Signed-off-by: Simon Glass > --- > > arch/arm/dts/Makefile | 2 ++ > configs/apple_m1_defconfig | 11 +++++------ > 2 files changed, 7 insertions(+), 6 deletions(-) > > diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile > index fc16a57e60b..0c40947cc33 100644 > --- a/arch/arm/dts/Makefile > +++ b/arch/arm/dts/Makefile > @@ -1130,6 +1130,8 @@ dtb-$(CONFIG_TARGET_IMX8MM_CL_IOT_GATE) += > imx8mm-cl-iot-gate.dtb > > dtb-$(CONFIG_TARGET_EA_LPC3250DEVKITV2) += lpc3250-ea3250.dtb > > +dtb-$(CONFIG_ARCH_APPLE) += t8103-j274.dtb t8103-j293.dtb > + > targets += $(dtb-y) > > # Add any required device tree compiler flags here > diff --git a/configs/apple_m1_defconfig b/configs/apple_m1_defconfig > index a7ae15576bf..7712a0bac52 100644 > --- a/configs/apple_m1_defconfig > +++ b/configs/apple_m1_defconfig > @@ -1,14 +1,13 @@ > CONFIG_ARM=y > CONFIG_ARCH_APPLE=y > +CONFIG_DEFAULT_DEVICE_TREE="t8103-j293" > +CONFIG_USE_PREBOOT=y > # CONFIG_DISPLAY_CPUINFO is not set > -# CONFIG_MMC is not set > -# CONFIG_NET is not set > -CONFIG_VIDEO_SIMPLE=y > CONFIG_DISPLAY_BOARDINFO_LATE=y > +# CONFIG_NET is not set > +# CONFIG_MMC is not set > CONFIG_USB_XHCI_HCD=y > CONFIG_USB_XHCI_DWC3=y > CONFIG_USB_KEYBOARD=y > -CONFIG_USB_STORAGE=y > -CONFIG_USE_PREBOOT=y > -CONFIG_PREBOOT="usb start" > +CONFIG_VIDEO_SIMPLE=y > # CONFIG_GENERATE_SMBIOS_TABLE is not set > -- > 2.25.1 >