Re: [PATCH v2 for-next 1/7] IB/core: Extend ib_uverbs_create_qp

[Haggai Eran <haggaie-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>]

On 21/10/2015 12:53, Sagi Grimberg wrote:
> On 10/15/2015 2:44 PM, Eran Ben Elisha wrote:
>> ib_uverbs_ex_create_qp follows the extension verbs
>> mechanism. New features (for example, QP creation flags
>> field which is added in a downstream patch) could used
>> via user-space libraries without breaking the ABI.
> 
> This is an important addition, I'll need it soon for stuff
> I'm working on...
> 
>> +struct ib_uverbs_ex_create_qp {
>> +    __u64 user_handle;
>> +    __u32 pd_handle;
>> +    __u32 send_cq_handle;
>> +    __u32 recv_cq_handle;
>> +    __u32 srq_handle;
>> +    __u32 max_send_wr;
>> +    __u32 max_recv_wr;
>> +    __u32 max_send_sge;
>> +    __u32 max_recv_sge;
>> +    __u32 max_inline_data;
>> +    __u8  sq_sig_all;
>> +    __u8  qp_type;
>> +    __u8  is_srq;
>> +    __u8 reserved;
>> +    __u32 comp_mask;
>> +    __u32 create_flags;
> 
> Can we please make create_flags u64 to begin with?
Note that the size of the struct must be a round number of 64-bit words
to avoid different sizeof values on 32-bit systems. If you change the
size of create_flags you'll need another 32-bit padding field in the struct.

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html