From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41471) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZujWA-0001k2-N1 for qemu-devel@nongnu.org; Fri, 06 Nov 2015 11:05:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZujW6-0005mv-Jq for qemu-devel@nongnu.org; Fri, 06 Nov 2015 11:05:34 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58657) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZujW6-0005mj-Dk for qemu-devel@nongnu.org; Fri, 06 Nov 2015 11:05:30 -0500 References: <1446657582-21619-1-git-send-email-den@openvz.org> <20151106155455.GS12285@stefanha-x1.localdomain> From: Eric Blake Message-ID: <563CCFC8.2000206@redhat.com> Date: Fri, 6 Nov 2015 09:05:28 -0700 MIME-Version: 1.0 In-Reply-To: <20151106155455.GS12285@stefanha-x1.localdomain> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="iDHo9m2p073TxFBQm6RbGObXbDdUp1KDx" Subject: Re: [Qemu-devel] [PATCH 2.5 v5 0/11] dataplane snapshot fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , "Denis V. Lunev" Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi , Juan Quintela This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --iDHo9m2p073TxFBQm6RbGObXbDdUp1KDx Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/06/2015 08:54 AM, Stefan Hajnoczi wrote: > On Wed, Nov 04, 2015 at 08:19:31PM +0300, Denis V. Lunev wrote: >> with test >> while /bin/true ; do >> virsh snapshot-create rhel7 >> sleep 10 >> virsh snapshot-delete rhel7 --current >> done >> with enabled iothreads on a running VM leads to a lot of troubles: han= gs, >> asserts, errors. That is a case of using libvirt to trigger internal snapshots... >=20 > The HMP monitor is legacy and also not used by modern libvirt. =2E..and libvirt is forced to use HMP for internal snapshots, since we _still_ haven't exposed internal snapshots as a QMP command. > I think the affected use cases are restricted to savevm+dataplane and > HMP+dataplane. The fact that the commit message calls out a libvirt method of triggering the bug does mean that it is user-visible, and so it would qualify as a bug fix even during hard freeze. But I also understand that taking a large complex series late in the game is not without risk; and it is not like this is a regression (rather, something that has never worked bulletproof), right? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --iDHo9m2p073TxFBQm6RbGObXbDdUp1KDx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWPM/JAAoJEKeha0olJ0Nq5W0H/ROOlBBXNH8vAhOatBlO58XJ DgrhqgXXDvZawaixhsv5wk1BUSxg5hww1NQJjUNKzB35fhCdSh+F12KvMkIbKWeV KvsvJ/KYE5BQLsak3UcNluxSNOHkn8AUCppl4gR0p1iJ6ZAvgOY+5Z3MwvsRyCWz d97rsWInlghvZCBjtgCkx7ujjuQCrYLLpIZ8o9NfS6Bf3BxhnNhkXjUquStSamaf OyK5OEMSnQGOMu9Idt8uzh6iLqipiNRtVqMhounMMJxGEdz2JDRFBR3+ek3VQBEE lAOOQO0AzgmRUz8z2JntqIjkjD6e0qoykzcB/pI9HuC5FSylEX4JwHl92AcyPcM= =VPvf -----END PGP SIGNATURE----- --iDHo9m2p073TxFBQm6RbGObXbDdUp1KDx--