From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from bh-25.webhostbox.net ([208.91.199.152]:36480 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753843AbbKGP34 (ORCPT ); Sat, 7 Nov 2015 10:29:56 -0500 Subject: Re: [PATCH v2 1/4] watchdog: meson: Enable meson SoC specific data To: Carlo Caione , wim@iguana.be, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org, drake@endlessm.com, jerry.cao@amlogic.com, victor.wan@amlogic.com, romain.perier@gmail.com References: <1446894139-6802-1-git-send-email-carlo@caione.org> <1446894139-6802-2-git-send-email-carlo@caione.org> Cc: Carlo Caione From: Guenter Roeck Message-ID: <563E18F0.4030807@roeck-us.net> Date: Sat, 7 Nov 2015 07:29:52 -0800 MIME-Version: 1.0 In-Reply-To: <1446894139-6802-2-git-send-email-carlo@caione.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org On 11/07/2015 03:02 AM, Carlo Caione wrote: > From: Carlo Caione > > With this patch we refactor the driver code to enable watchdog support > for all platforms based on Amlogic meson SoCs. > > Signed-off-by: Carlo Caione > --- > drivers/watchdog/meson_wdt.c | 56 ++++++++++++++++++++++++++++++-------------- > 1 file changed, 39 insertions(+), 17 deletions(-) > > diff --git a/drivers/watchdog/meson_wdt.c b/drivers/watchdog/meson_wdt.c > index 1f4155e..446af94 100644 > --- a/drivers/watchdog/meson_wdt.c > +++ b/drivers/watchdog/meson_wdt.c > @@ -19,6 +19,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -27,35 +28,47 @@ > #define DRV_NAME "meson_wdt" > > #define MESON_WDT_TC 0x00 > -#define MESON_WDT_TC_EN BIT(22) > -#define MESON_WDT_TC_TM_MASK 0x3fffff > #define MESON_WDT_DC_RESET (3 << 24) > > #define MESON_WDT_RESET 0x04 > > -#define MESON_WDT_TIMEOUT 30 > +#define MESON_WDT_TIMEOUT 5 This is not a reasonable default, the change is not mentioned in the description, and it is unrelated to the change at hand. Sorry if I overlooked it in v1. Guenter From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@roeck-us.net (Guenter Roeck) Date: Sat, 7 Nov 2015 07:29:52 -0800 Subject: [PATCH v2 1/4] watchdog: meson: Enable meson SoC specific data In-Reply-To: <1446894139-6802-2-git-send-email-carlo@caione.org> References: <1446894139-6802-1-git-send-email-carlo@caione.org> <1446894139-6802-2-git-send-email-carlo@caione.org> Message-ID: <563E18F0.4030807@roeck-us.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 11/07/2015 03:02 AM, Carlo Caione wrote: > From: Carlo Caione > > With this patch we refactor the driver code to enable watchdog support > for all platforms based on Amlogic meson SoCs. > > Signed-off-by: Carlo Caione > --- > drivers/watchdog/meson_wdt.c | 56 ++++++++++++++++++++++++++++++-------------- > 1 file changed, 39 insertions(+), 17 deletions(-) > > diff --git a/drivers/watchdog/meson_wdt.c b/drivers/watchdog/meson_wdt.c > index 1f4155e..446af94 100644 > --- a/drivers/watchdog/meson_wdt.c > +++ b/drivers/watchdog/meson_wdt.c > @@ -19,6 +19,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -27,35 +28,47 @@ > #define DRV_NAME "meson_wdt" > > #define MESON_WDT_TC 0x00 > -#define MESON_WDT_TC_EN BIT(22) > -#define MESON_WDT_TC_TM_MASK 0x3fffff > #define MESON_WDT_DC_RESET (3 << 24) > > #define MESON_WDT_RESET 0x04 > > -#define MESON_WDT_TIMEOUT 30 > +#define MESON_WDT_TIMEOUT 5 This is not a reasonable default, the change is not mentioned in the description, and it is unrelated to the change at hand. Sorry if I overlooked it in v1. Guenter