All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Torsten Bögershausen" <tboegi@web.de>
To: Dennis Kaarsemaker <dennis@kaarsemaker.net>,
	Ramsay Jones <ramsay@ramsayjones.plus.com>,
	Adam Dinwoodie <adam@dinwoodie.org>, Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: Bug: t5813 failing on Cygwin
Date: Sun, 8 Nov 2015 08:11:53 +0100	[thread overview]
Message-ID: <563EF5B9.9020002@web.de> (raw)
In-Reply-To: <1446939168.16957.11.camel@kaarsemaker.net>

>>
>> diff --git a/connect.c b/connect.c
>> index 108f5ab..fc73cf9 100644
>> --- a/connect.c
>> +++ b/connect.c
>> @@ -636,6 +636,8 @@ static enum protocol parse_connect_url(const char
>> *url_orig, char **ret_host,
>>  	end = path; /* Need to \0 terminate host here */
>>  	if (separator == ':')
>>  		path++; /* path starts after ':' */
>> +	if (starts_with(path, "//"))
>> +		path++;
>>  	if (protocol == PROTO_GIT || protocol == PROTO_SSH) {
>>  		if (path[1] == '~')
>>  			path++;
>>
>> It seems to work, but I haven't thought about it too deeply ...
>> so I don't know if there are any problems lurking. :)
>>
>> I have to go now, so if somebody wants to take this up ...
> 
> Won't that break file:////server/share urls on cygwin?
> 
The official way to specify UNC names looks like this:
file://<host>/<path>
(Or file://server/share/morepath to follow your example)
#http://www.faqs.org/rfcs/rfc1738.html

But unfortunately Git doesn't support it.
I can put it on the to-do list...

But using "file:////" this is not an official syntax,
and should (in theory) not be used by any user.
Does anybody use it?

Or do people use simply "git clone //server/share/" ?
 

  parent reply	other threads:[~2015-11-08  7:12 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-07 12:11 Bug: t5813 failing on Cygwin Adam Dinwoodie
2015-11-07 18:45 ` Jeff King
2015-11-07 19:20   ` Adam Dinwoodie
2015-11-07 21:02     ` Dennis Kaarsemaker
2015-11-07 21:21       ` Ramsay Jones
2015-11-07 23:05         ` Ramsay Jones
2015-11-07 23:32           ` Dennis Kaarsemaker
2015-11-08  1:46             ` Ramsay Jones
2015-11-08  7:11             ` Torsten Bögershausen [this message]
2015-11-07 23:24       ` Adam Dinwoodie
2015-11-08  5:10       ` Jeff King
2015-11-08  9:54         ` [PATCH] t5813: avoid creating urls that break on cygwin Dennis Kaarsemaker
2015-11-09 15:45           ` Jeff King
2015-11-09 17:49             ` Dennis Kaarsemaker
2015-11-09 17:50               ` Jeff King
2015-11-08 13:21         ` Bug: t5813 failing on Cygwin Ramsay Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=563EF5B9.9020002@web.de \
    --to=tboegi@web.de \
    --cc=adam@dinwoodie.org \
    --cc=dennis@kaarsemaker.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    --cc=ramsay@ramsayjones.plus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.