From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49552) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZvtdS-0007oX-65 for qemu-devel@nongnu.org; Mon, 09 Nov 2015 16:05:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZvtdN-0003Ob-6o for qemu-devel@nongnu.org; Mon, 09 Nov 2015 16:05:54 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58351) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZvtdM-0003OV-V9 for qemu-devel@nongnu.org; Mon, 09 Nov 2015 16:05:49 -0500 References: <1446657582-21619-1-git-send-email-den@openvz.org> <20151106155455.GS12285@stefanha-x1.localdomain> <563CCFC8.2000206@redhat.com> <563D1806.40602@openvz.org> From: Eric Blake Message-ID: <56410AAB.3010802@redhat.com> Date: Mon, 9 Nov 2015 14:05:47 -0700 MIME-Version: 1.0 In-Reply-To: <563D1806.40602@openvz.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="AhcNPbBB2IaEQqW1Sl8Hpiw7K45m5oEPU" Subject: Re: [Qemu-devel] [PATCH 2.5 v5 0/11] dataplane snapshot fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" , Stefan Hajnoczi Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi , Juan Quintela This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --AhcNPbBB2IaEQqW1Sl8Hpiw7K45m5oEPU Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/06/2015 02:13 PM, Denis V. Lunev wrote: >> That is a case of using libvirt to trigger internal snapshots... >> >>> The HMP monitor is legacy and also not used by modern libvirt. >> ...and libvirt is forced to use HMP for internal snapshots, since we >> _still_ haven't exposed internal snapshots as a QMP command. >=20 > Eric, >=20 > by the way, there is a user visible bug with this too :)))))) >=20 > EFI based VM with pflash storage for NVRAM could not > be snapshoted as libvirt configures storage as 'raw'. > OK, this is a libvirt bug. The patch will be sent next > week or in a week by my colleague switching storage > type from 'raw' to 'qcow2'. Not necessarily a bug in libvirt, so much as a limitation that the current qemu implementation of internal snapshots requires qcow2 for all storage devices (even though it might not be technically necessary, if there were an easy way to snapshot state of one non-qcow2 storage alongside the rest of the machine state stored elsewhere). But a libvirt patch would certainly be useful. >=20 > For a QEMU this results in the following: > - QEMU receives command via HMP to make a snapshot > - it fails, but QEMU does not see that fact (error code > is not delivered to libvirt in HMP AFAIK) Libvirt is still using QMP to deliver the HMP command (via the QMP human-monitor-command); if I'm understanding your complaint correctly, you are saying that qemu doesn't do error reporting correctly for that? If so, fix that in qemu, although libvirt should also be able to work around it when dealing with broken qemu. > - on request to switch to snapshot the commands > just do nothing and from the point of libvirt the command > was successful >=20 > We should have these commands even in the simple > rudimentary current non-ideal form even just as wrappers > around HMP functions. >=20 > Do you have an opinion about importance of the last > issue? Should it be considered for 2.6? We've gone since 0.14 without anyone writing the remaining few QMP commands to completely obsolete the need for human-monitor-command backdoors into HMP. Volunteers are welcome to submit code to complete the conversion, but the length of time it has taken so far may be an indication that it is not as easy as you think. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --AhcNPbBB2IaEQqW1Sl8Hpiw7K45m5oEPU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWQQqrAAoJEKeha0olJ0Nq8T0IAKKPtYNn+7cNUUepteyycYls CwE2Xw35uq0TfuLDIQujfTLvwUIejjh6jBYZ+0YUkVdwCoPiqXiCoyGEbNDj4aRe BjIik5ujY2glchfUYo+WG2NXhYFwGvOkupu0nNaa1aqKrI7SKOEKsf7yWyzYCSXM fJAWG29SmB3dDHNvKNviUoPpyd6sos9lrzGGS5dH6Uin0KizNRZaTNYFE5gjbbvB /EqW06vGujZ8H0EWi/JrpPZWoH2OHDgfJndu+VbFL3qo8bhynO4990BDTuIZ6RLZ 5fcE1V79O2pwdmKHuLRqGnB+8Uo/OcUtj08R8HibPW5IeUt8dtH6DKUXxHzNTGE= =NlGb -----END PGP SIGNATURE----- --AhcNPbBB2IaEQqW1Sl8Hpiw7K45m5oEPU--