All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Gordon <david.s.gordon@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
	Jesse Barnes <jbarnes@virtuousgeek.org>,
	intel-gfx@lists.freedesktop.org, daniel.vetter@ffwll.ch
Subject: Re: [PATCH v2, 2/4] drm/i915: simplify testing for the global default context
Date: Tue, 5 Jan 2016 13:16:58 +0000	[thread overview]
Message-ID: <568BC24A.8080706@intel.com> (raw)
In-Reply-To: <20160105100646.GA14720@nuc-i3427.alporthouse.com>

On 05/01/16 10:06, Chris Wilson wrote:
> On Mon, Jan 04, 2016 at 01:38:26PM -0800, Jesse Barnes wrote:
>> On 01/04/2016 11:39 AM, Chris Wilson wrote:
>>> This series is NAKed.
>>
>> Why?  Because you want things in a different order?  Or do you object to something in Dave's reply?
>
> The series was intended as a code cleanup and in the process tried to
> introduce a false concept that I objected to. Since the cleanup was not
> predicated upon that idea, the patches would have been much tidier
> without it.

I don't think it's a false concept; there very evidently *IS* a global 
default context, so why not flag it as such by name, rather than by 
implication. and the subsequent cleanup *does* require it.

> The fundamental issue at stake here is execlists behaves badly and we
> have to futz around in higher level code to undo that mistake.
> -Chris

Now I agree that the execlist->default_context is a bad idea, and that's 
exactly what we will get rid of in patch 4, but we can't do it until 
these precursor patches have separated the various purposes for which it 
is used into distinct categories, each of which is then replaced by a 
cleaner alternative.

So it *is* a step towards rewriting execlists, even if it doesn't (at 
this stage) fix everything you might eventually want.

.Dave.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2016-01-05 13:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-23 19:33 [PATCH v2, 0/4] improve handling of the driver's default context Dave Gordon
2015-12-23 19:33 ` [PATCH v2, 1/4] drm/i915: remove intel_context::file_priv, add flag for " Dave Gordon
2015-12-23 19:33 ` [PATCH v2, 2/4] drm/i915: simplify testing for the global " Dave Gordon
2015-12-23 21:02   ` Chris Wilson
2016-01-04 17:43     ` Dave Gordon
2016-01-04 19:39       ` Chris Wilson
2016-01-04 21:38         ` Jesse Barnes
2016-01-05 10:06           ` Chris Wilson
2016-01-05 13:16             ` Dave Gordon [this message]
2015-12-23 19:33 ` [PATCH v2, 3/4] drm/i915: simplify allocation of driver-internal requests Dave Gordon
2015-12-23 19:33 ` [PATCH v2, 4/4] drm/i915: abolish separate per-engine default_context pointers Dave Gordon
2015-12-24  7:49 ` ✗ warning: Fi.CI.BAT Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=568BC24A.8080706@intel.com \
    --to=david.s.gordon@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=daniel.vetter@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jbarnes@virtuousgeek.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.