All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michel Thierry <michel.thierry@intel.com>
To: Ben Widawsky <benjamin.widawsky@intel.com>,
	Intel GFX <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 5/5] drm/i915: Use CSB helper in debugfs
Date: Wed, 6 Jan 2016 15:10:50 +0000	[thread overview]
Message-ID: <568D2E7A.5070005@intel.com> (raw)
In-Reply-To: <1452018609-10142-6-git-send-email-benjamin.widawsky@intel.com>

On 1/5/2016 6:30 PM, Ben Widawsky wrote:
> Since we extracted it for use in error state, we may as well use it in debugfs
> too.
>
> Signed-off-by: Ben Widawsky <benjamin.widawsky@intel.com>

Reviewed-by: Michel Thierry <michel.thierry@intel.com>

(depends on patch 4/5, where I have a small request)

> ---
>   drivers/gpu/drm/i915/i915_debugfs.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index 3b05bd1..0b829fa 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -2099,8 +2099,7 @@ static int i915_execlists(struct seq_file *m, void *data)
>                             read_pointer, write_pointer);
>
>                  for (i = 0; i < GEN8_CSB_ENTRIES; i++) {
> -                       status = I915_READ(RING_CONTEXT_STATUS_BUF_LO(ring, i));
> -                       ctx_id = I915_READ(RING_CONTEXT_STATUS_BUF_HI(ring, i));
> +                       intel_lrc_get_context_status(ring, i, &status, &ctx_id);
>
>                          seq_printf(m, "\tStatus buffer %d: 0x%08X, context: %u\n",
>                                     i, status, ctx_id);
> --
> 2.6.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2016-01-06 15:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-05 18:30 [PATCH 0/5] Some minor CSB/execlist stuff Ben Widawsky
2016-01-05 18:30 ` [PATCH 1/5] drm/i915: Cleanup some of the CSB handling Ben Widawsky
2016-01-06 15:08   ` Michel Thierry
2016-01-05 18:30 ` [PATCH 2/5] drm/i915: Change WARN to ERROR in CSB count Ben Widawsky
2016-01-06 15:09   ` Michel Thierry
2016-01-05 18:30 ` [PATCH 3/5] drm/i915: Extract CSB status read Ben Widawsky
2016-01-06 15:09   ` Michel Thierry
2016-01-06 15:15     ` Chris Wilson
2016-01-07 14:34   ` Daniel Vetter
2016-01-05 18:30 ` [PATCH 4/5] drm/i915: Add basic execlist info to error state Ben Widawsky
2016-01-06 15:10   ` Michel Thierry
2016-01-05 18:30 ` [PATCH 5/5] drm/i915: Use CSB helper in debugfs Ben Widawsky
2016-01-06 15:10   ` Michel Thierry [this message]
2016-01-06  8:20 ` ✗ warning: Fi.CI.BAT Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=568D2E7A.5070005@intel.com \
    --to=michel.thierry@intel.com \
    --cc=benjamin.widawsky@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.