From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juergen Gross Subject: Re: [PATCH v2 05/13] libxl: move xen-init-dom0 to tools/helpers Date: Thu, 7 Jan 2016 07:15:31 +0100 Message-ID: <568E0283.80306@suse.com> References: <1450444471-6454-1-git-send-email-jgross@suse.com> <1450444471-6454-6-git-send-email-jgross@suse.com> <1452096768.21055.105.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1452096768.21055.105.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , xen-devel@lists.xen.org, ian.jackson@eu.citrix.com, stefano.stabellini@eu.citrix.com, wei.liu2@citrix.com, dgdegra@tycho.nsa.gov List-Id: xen-devel@lists.xenproject.org On 06/01/16 17:12, Ian Campbell wrote: > On Fri, 2015-12-18 at 14:14 +0100, Juergen Gross wrote: >> Move xen-init-dom0 from tools/libxl to tools/helpers, as it is just a >> helper program. >> >> Signed-off-by: Juergen Gross >> --- >> tools/helpers/Makefile | 10 ++++++++++ >> tools/{libxl => helpers}/xen-init-dom0.c | 0 >> tools/libxl/Makefile | 14 +++----------- >> 3 files changed, 13 insertions(+), 11 deletions(-) >> rename tools/{libxl => helpers}/xen-init-dom0.c (100%) >> >> diff --git a/tools/helpers/Makefile b/tools/helpers/Makefile >> index 52347fd..92aead4 100644 >> --- a/tools/helpers/Makefile >> +++ b/tools/helpers/Makefile >> @@ -5,10 +5,16 @@ >> XEN_ROOT = $(CURDIR)/../.. >> include $(XEN_ROOT)/tools/Rules.mk >> >> +PROGS += xen-init-dom0 >> ifeq ($(CONFIG_Linux),y) >> PROGS += init-xenstore-domain >> endif >> >> +XEN_INIT_DOM0_OBJS = xen-init-dom0.o >> +$(XEN_INIT_DOM0_OBJS): CFLAGS += $(CFLAGS_libxenctrl) > > I think the only use of this was for the xtl_* interfaces, which are now in > libxentoollog.h (with a compat include via xenctrl.h). Would you mind > switching the tool over to use xentoollog directly (perhaps in a separate > patch)? Will do. Juergen