From: Jason Wang <jasowang@redhat.com>
To: Wei Xu <wexu@redhat.com>, qemu-devel@nongnu.org
Cc: Wei Xu <wei@redhat.com>,
victork@redhat.com, mst@redhat.com, yvugenfi@redhat.com,
marcel@redhat.com, dfleytma@redhat.com
Subject: Re: [Qemu-devel] [RFC Patch v2 03/10] virtio-net rsc: Chain Lookup, Packet Caching and Framework of IPv4
Date: Mon, 1 Feb 2016 17:22:05 +0800 [thread overview]
Message-ID: <56AF23BD.3040108@redhat.com> (raw)
In-Reply-To: <56AF1132.3010006@redhat.com>
On 02/01/2016 04:02 PM, Wei Xu wrote:
[...]
>>
>>> + return NULL;
>>> + }
>>> +
>>> + chain->proto = proto;
>>> + chain->do_receive = virtio_net_rsc_receive4;
>>> +
>>> + QTAILQ_INIT(&chain->buffers);
>>> + QTAILQ_INSERT_TAIL(&n->rsc_chains, chain, next);
>>> + return chain;
>>> +}
>> Better to split the chain initialization from lookup. And we can
>> initialize ipv4 chain during initialization.
>
> Since the allocation happens really seldom, is it ok to keep the
> mechanism to make the logic clean?
Ok for now.
next prev parent reply other threads:[~2016-02-01 9:22 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-31 18:13 [Qemu-devel] [RFC v2 0/10] Support Receive-Segment-Offload(RSC) for WHQL test of Window guest wexu
2016-01-31 18:13 ` [Qemu-devel] [RFC Patch v2 01/10] virtio-net rsc: Data structure, 'Segment', 'Chain' and 'Status' wexu
2016-01-31 18:13 ` [Qemu-devel] [RFC Patch v2 02/10] virtio-net rsc: Initilize & Cleanup wexu
2016-01-31 18:47 ` Michael S. Tsirkin
2016-02-01 3:56 ` Wei Xu
2016-02-01 3:32 ` Jason Wang
2016-02-01 7:46 ` Wei Xu
2016-01-31 18:13 ` [Qemu-devel] [RFC Patch v2 03/10] virtio-net rsc: Chain Lookup, Packet Caching and Framework of IPv4 wexu
2016-01-31 18:50 ` Michael S. Tsirkin
2016-02-01 3:40 ` Wei Xu
2016-02-01 5:55 ` Jason Wang
2016-02-01 8:02 ` Wei Xu
2016-02-01 9:22 ` Jason Wang [this message]
2016-01-31 18:13 ` [Qemu-devel] [RFC Patch v2 04/10] virtio-net rsc: Detailed IPv4 and General TCP data coalescing wexu
2016-02-01 6:21 ` Jason Wang
2016-02-01 8:29 ` Wei Xu
2016-02-01 9:29 ` Jason Wang
2016-01-31 18:13 ` [Qemu-devel] [RFC Patch v2 05/10] virtio-net rsc: Create timer to drain the packets from the cache pool wexu
2016-02-01 6:28 ` Jason Wang
2016-02-01 8:39 ` Wei Xu
2016-02-01 9:31 ` Jason Wang
2016-02-01 13:31 ` Wei Xu
2016-01-31 18:13 ` [Qemu-devel] [RFC Patch v2 06/10] virtio-net rsc: IPv4 checksum wexu
2016-02-01 6:31 ` Jason Wang
2016-02-01 8:40 ` Wei Xu
2016-01-31 18:13 ` [Qemu-devel] [RFC Patch v2 07/10] virtio-net rsc: Checking TCP flag and drain specific connection packets wexu
2016-02-01 6:44 ` Jason Wang
2016-02-01 8:44 ` Wei Xu
2016-01-31 18:13 ` [Qemu-devel] [RFC Patch v2 08/10] virtio-net rsc: Sanity check & More bypass cases check wexu
2016-02-01 6:58 ` Jason Wang
2016-02-01 8:46 ` Wei Xu
2016-01-31 18:13 ` [Qemu-devel] [RFC Patch v2 09/10] virtio-net rsc: Add IPv6 support wexu
2016-02-01 7:14 ` Jason Wang
2016-02-01 8:49 ` Wei Xu
2016-01-31 18:13 ` [Qemu-devel] [RFC Patch v2 10/10] virtio-net rsc: Add Receive Segment Coalesce statistics wexu
2016-02-01 7:16 ` Jason Wang
2016-02-01 8:50 ` Wei Xu
2016-01-31 19:03 ` [Qemu-devel] [RFC v2 0/10] Support Receive-Segment-Offload(RSC) for WHQL test of Window guest Michael S. Tsirkin
2016-02-01 3:23 ` Jason Wang
2016-02-01 3:42 ` Wei Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56AF23BD.3040108@redhat.com \
--to=jasowang@redhat.com \
--cc=dfleytma@redhat.com \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=victork@redhat.com \
--cc=wei@redhat.com \
--cc=wexu@redhat.com \
--cc=yvugenfi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.