All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Rybchenko <arybchenko@solarflare.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
	John McNamara <john.mcnamara@intel.com>
Cc: <dev@dpdk.org>, Olivier Matz <olivier.matz@6wind.com>
Subject: Re: [PATCH v3] doc: document NIC features
Date: Fri, 7 Jul 2017 18:38:56 +0300	[thread overview]
Message-ID: <56cd604e-fcad-ca66-aee5-bade5c9a20a3@solarflare.com> (raw)
In-Reply-To: <199b9881-26d4-f36d-9737-02b8559d449e@intel.com>

On 07/07/2017 06:06 PM, Ferruh Yigit wrote:
> On 7/7/2017 11:55 AM, Andrew Rybchenko wrote:
> <...>
>
>>> +TSO
>>> +---
>>> +
>>> +Supports TCP Segmentation Offloading.
>>> +
>>> +* **mbuf**: ``mbuf.ol_flags:PKT_TX_TCP_SEG``.
>> DEV_TX_OFFLOAD_*_TSO in tx_offload_capa
>> Is support of one TSO option sufficient to say Yes?
> This is common question for a few offload features, like ones that can
> be valid for Rx and Tx path, I guess feature should be "Yes" if all are
> supported, otherwise "P(artial)".

IMHO, it would be more informative to have separate features for TCP, 
UDP and
encapsulated TSO offloads.

Otherwise when a new TSO offload flag is added, it should change all Y to P
(and update PMDs documentation to provide details).

> But this is hard to trace and if marked as "P", makes hard to figure out
> what is supported.

Ideally for all "P" it should be a hyperlink to PMD documentation section
which provides details.

> <...>

<...>

  reply	other threads:[~2017-07-07 15:39 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-15 16:37 [RFC] doc: document NIC features Ferruh Yigit
2017-06-21 13:25 ` [PATCH] " Ferruh Yigit
2017-06-22 19:02   ` [PATCH v2] " Ferruh Yigit
2017-07-02 20:20     ` Mcnamara, John
2017-07-05 13:20     ` [PATCH v3] " Ferruh Yigit
2017-07-05 16:03       ` Mcnamara, John
2017-07-07 10:55       ` Andrew Rybchenko
2017-07-07 13:37         ` Ferruh Yigit
2017-07-07 13:53           ` Thomas Monjalon
2017-07-07 13:57             ` Ferruh Yigit
2017-07-07 14:02               ` Thomas Monjalon
2017-07-07 14:13                 ` Ferruh Yigit
2017-07-07 14:20                   ` Wiles, Keith
2017-07-07 20:37                     ` Thomas Monjalon
2017-07-07 23:54                       ` Wiles, Keith
2017-07-07 15:06         ` Ferruh Yigit
2017-07-07 15:38           ` Andrew Rybchenko [this message]
2017-07-07 17:21       ` [PATCH v4] " Ferruh Yigit
2017-07-08  9:47         ` Andrew Rybchenko
2017-07-20  9:10           ` Ferruh Yigit
2017-07-20  9:23         ` [PATCH v5] " Ferruh Yigit
2017-07-26  5:08           ` Shreyansh Jain
2017-08-01 10:15             ` Ferruh Yigit
2017-08-01 15:23           ` [PATCH v6] " Ferruh Yigit
2017-08-03  8:56             ` Shreyansh Jain
2017-08-03  8:57               ` Shreyansh Jain
2017-08-03 10:42             ` Mcnamara, John
2017-08-03 22:57             ` Thomas Monjalon
2017-08-04  8:56               ` Ferruh Yigit
2017-08-04  9:32                 ` Thomas Monjalon
2017-08-04 10:04                   ` Ferruh Yigit
2017-08-04 10:10                     ` Thomas Monjalon
2017-08-04 11:11                   ` Mcnamara, John
2017-08-04 11:40                     ` Ferruh Yigit
2017-08-04 13:06             ` [PATCH v7] " Ferruh Yigit
2017-08-04 13:34               ` Mcnamara, John
2017-08-05  9:34               ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56cd604e-fcad-ca66-aee5-bade5c9a20a3@solarflare.com \
    --to=arybchenko@solarflare.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=john.mcnamara@intel.com \
    --cc=olivier.matz@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.