From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38612) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aoVKP-0008Ce-6j for qemu-devel@nongnu.org; Fri, 08 Apr 2016 08:15:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aoVKO-0001Pe-9W for qemu-devel@nongnu.org; Fri, 08 Apr 2016 08:15:57 -0400 References: <1459855253-5378-1-git-send-email-famz@redhat.com> <20160408100616.GA29498@stefanha-x1.localdomain> From: Paolo Bonzini Message-ID: <5707A0F0.8080302@redhat.com> Date: Fri, 8 Apr 2016 14:15:44 +0200 MIME-Version: 1.0 In-Reply-To: <20160408100616.GA29498@stefanha-x1.localdomain> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v3 0/2] block: Fix hang with mirroring qcow2 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , Fam Zheng Cc: qemu-devel@nongnu.org, Kevin Wolf , lvivier@redhat.com, qemu-block@nongnu.org, Stefan Hajnoczi On 08/04/2016 12:06, Stefan Hajnoczi wrote: > On Tue, Apr 05, 2016 at 07:20:51PM +0800, Fam Zheng wrote: >> See patch 1 for the bug analysis. >> >> v3: Make bdrv_co_drain a public function and use it directly in block/= mirror.c. >> [Stefan] >> >> >> >> Fam Zheng (2): >> block: Fix bdrv_drain in coroutine >> mirror: Replace bdrv_drain(bs) with bdrv_co_drain(bs) >> >> block/io.c | 45 ++++++++++++++++++++++++++++++++++++++++++= +++ >> block/mirror.c | 2 +- >> include/block/block.h | 1 + >> 3 files changed, 47 insertions(+), 1 deletion(-) >> >> --=20 >> 2.7.4 >=20 > Thanks, applied to my block tree: > https://github.com/stefanha/qemu/commits/block FWIW, I've now rebased my bdrv_drain patches on top of this, and the need for the extra bottom half is gone! This is a much better solution for that other problem with mirror.c. Paolo