From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932195AbcEKMy0 (ORCPT ); Wed, 11 May 2016 08:54:26 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:32628 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751923AbcEKMyX (ORCPT ); Wed, 11 May 2016 08:54:23 -0400 X-AuditID: cbfec7f5-f792a6d000001302-45-57332b7b685b Subject: Re: [PATCH v3 27/27] ARM: dts: exynos: Add RTC and I2C to Exynos5410 To: Javier Martinez Canillas , Kukjin Kim , Krzysztof Kozlowski , Sylwester Nawrocki , Tomasz Figa , Michael Turquette , Stephen Boyd , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org References: <1462910970-1812-1-git-send-email-krzk@kernel.org> <1462910970-1812-28-git-send-email-krzk@kernel.org> Cc: Rob Herring From: Krzysztof Kozlowski Message-id: <57332B7A.5070909@kernel.org> Date: Wed, 11 May 2016 14:54:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-version: 1.0 In-reply-to: Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmplkeLIzCtJLcpLzFFi42I5/e/4Zd1qbeNwg7Xf9CzmHznHavHm7Rom i9cvDC36H79mttj0+Bqrxceee6wWl3fNYbOYcX4fk8XFU64WrXuPsFscftPOavHjTDeLxapd fxgdeD3e32hl97jc18vksXPWXXaPTas62Tw2L6n32NIP5PVtWcXo8XmTXABHFJdNSmpOZllq kb5dAlfG8ZMvWQsWcVWcu/yRpYFxJUcXIyeHhICJxKZFV5ggbDGJC/fWs3UxcnEICSxllFix awEzhPOMUeLWkmeMIFXCAr4Sa789ZQJJiAhcZpaYdf8NI0TVWkaJ3uXnmEGqmAVUJL7d+gVU xcHBJqAt8W9LMUiYV0BToqvxOzuIzSKgKjHlXhsriC0qECGxet01ZogaQYkfk++xgNicAs4S 32evYQEZwyygJ3H/ohbEdHmJzWveMk9gFJiFpGMWQtUsJFULGJlXMYqmliYXFCel5xrpFSfm Fpfmpesl5+duYoREztcdjEuPWR1iFOBgVOLh3VBlFC7EmlhWXJl7iFGCg1lJhFdayzhciDcl sbIqtSg/vqg0J7X4EKM0B4uSOO/MXe9DhATSE0tSs1NTC1KLYLJMHJxSDYzLb0X5ytzftnSr /MZXnOynjgbEJ+9P+Bhd/+7Hghj+j+63n95e23na+d+pyxo7qvMVW/2ucQSz6BbxXAmLVzr9 +IqMdpmwz833FyN7NvAEvk0pO7GnX/LKxOUr1u5WXmx/U2+z9j+vFbGZ52cX5RjnZWxu1HJL ErS9vHLStHwj58pJIbVuR0uUWIozEg21mIuKEwGaiiZqmAIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/11/2016 02:44 PM, Javier Martinez Canillas wrote: > Hello Krzysztof, > > On 05/10/2016 04:09 PM, Krzysztof Kozlowski wrote: >> Configure Exynos5410-specific properties of RTC, I2C and HSI2C nodes. >> This still does not enable them on the board level though. >> >> Signed-off-by: Krzysztof Kozlowski >> --- >> arch/arm/boot/dts/exynos5410.dtsi | 66 +++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 66 insertions(+) >> >> diff --git a/arch/arm/boot/dts/exynos5410.dtsi b/arch/arm/boot/dts/exynos5410.dtsi >> index dd4d6d752865..ae64cb0a8efd 100644 >> --- a/arch/arm/boot/dts/exynos5410.dtsi >> +++ b/arch/arm/boot/dts/exynos5410.dtsi >> @@ -114,6 +114,9 @@ >> status = "disabled"; >> }; >> >> + /* i2c_0-3 are defined in exynos5.dtsi */ >> + /* hsi2c_4-7 are defined in exynos5xx.dtsi */ >> + > > I don't think these comments are needed. For each DTS, there are usually a lot of > nodes defined in higher levels of the DT hierarchy but isn't common to mention it. > > Specially since the mentioned nodes are referenced here by their labels so it is > implicit that are defined in one of the included DTSI (or dtc will fail to build). Okay, if it does not make sense to you then I'll remove them. Thanks for review! Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 From: krzk@kernel.org (Krzysztof Kozlowski) Date: Wed, 11 May 2016 14:54:18 +0200 Subject: [PATCH v3 27/27] ARM: dts: exynos: Add RTC and I2C to Exynos5410 In-Reply-To: References: <1462910970-1812-1-git-send-email-krzk@kernel.org> <1462910970-1812-28-git-send-email-krzk@kernel.org> Message-ID: <57332B7A.5070909@kernel.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 05/11/2016 02:44 PM, Javier Martinez Canillas wrote: > Hello Krzysztof, > > On 05/10/2016 04:09 PM, Krzysztof Kozlowski wrote: >> Configure Exynos5410-specific properties of RTC, I2C and HSI2C nodes. >> This still does not enable them on the board level though. >> >> Signed-off-by: Krzysztof Kozlowski >> --- >> arch/arm/boot/dts/exynos5410.dtsi | 66 +++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 66 insertions(+) >> >> diff --git a/arch/arm/boot/dts/exynos5410.dtsi b/arch/arm/boot/dts/exynos5410.dtsi >> index dd4d6d752865..ae64cb0a8efd 100644 >> --- a/arch/arm/boot/dts/exynos5410.dtsi >> +++ b/arch/arm/boot/dts/exynos5410.dtsi >> @@ -114,6 +114,9 @@ >> status = "disabled"; >> }; >> >> + /* i2c_0-3 are defined in exynos5.dtsi */ >> + /* hsi2c_4-7 are defined in exynos5xx.dtsi */ >> + > > I don't think these comments are needed. For each DTS, there are usually a lot of > nodes defined in higher levels of the DT hierarchy but isn't common to mention it. > > Specially since the mentioned nodes are referenced here by their labels so it is > implicit that are defined in one of the included DTSI (or dtc will fail to build). Okay, if it does not make sense to you then I'll remove them. Thanks for review! Krzysztof