All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Richard W.M. Jones" <rjones@redhat.com>, qemu-devel@nongnu.org
Cc: stefanha@gmail.com, marc.mari.barcelo@gmail.com,
	ehabkost@redhat.com, mst@redhat.com, kraxel@redhat.com,
	rth@twiddle.net, lersek@redhat.com
Subject: Re: [Qemu-devel] [PATCH v7 2/2] Add optionrom compatible with fw_cfg DMA version
Date: Wed, 11 May 2016 22:07:27 +0200	[thread overview]
Message-ID: <573390FF.8010409@redhat.com> (raw)
In-Reply-To: <1462988574-30590-3-git-send-email-rjones@redhat.com>



On 11/05/2016 19:42, Richard W.M. Jones wrote:
> +
> +#ifdef __clang__
> +#define ADDR32
> +#else
> +#define ADDR32 "addr32 "
> +#endif
> +
> +static inline uint16_t readw_es(uint16_t offset)
> +{
> +    uint16_t val;
> +    asm(ADDR32"movw %%es:(%1), %0" : "=r"(val) : "r"((uint32_t)offset));
> +    barrier();
> +    return val;
> +}

Please check that the output is the same byte-by-byte for this asm.

I guess this is okay if we have a guarantee from clang that the asm
block stays at the beginning.  Perhaps check for the 0x55 0xaa signature
in signrom.py?

Thanks,

Paolo

  reply	other threads:[~2016-05-11 20:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-11 17:42 [Qemu-devel] [PATCH v7 0/2] Add optionrom compatible with fw_cfg DMA version Richard W.M. Jones
2016-05-11 17:42 ` [Qemu-devel] [PATCH v7 1/2] scripts/signrom.py: Allow option ROM checksum script to write the size header Richard W.M. Jones
2016-05-11 17:42 ` [Qemu-devel] [PATCH v7 2/2] Add optionrom compatible with fw_cfg DMA version Richard W.M. Jones
2016-05-11 20:07   ` Paolo Bonzini [this message]
2016-05-11 21:04     ` Richard W.M. Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=573390FF.8010409@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=lersek@redhat.com \
    --cc=marc.mari.barcelo@gmail.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rjones@redhat.com \
    --cc=rth@twiddle.net \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.