From: Daniel Borkmann <daniel@iogearbox.net>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Tom Herbert <tom@herbertland.com>
Subject: Re: [Patch net] net_sched: fix mirrored packets checksum
Date: Fri, 01 Jul 2016 11:13:55 +0200 [thread overview]
Message-ID: <57763453.1050008@iogearbox.net> (raw)
In-Reply-To: <CAM_iQpXd7-rx_XzoZ=8gVekLD0YRLkmr0kgud3WoXnjEvCOLZw@mail.gmail.com>
On 07/01/2016 01:41 AM, Cong Wang wrote:
> On Thu, Jun 30, 2016 at 4:26 PM, Cong Wang <xiyou.wangcong@gmail.com> wrote:
>> On Thu, Jun 30, 2016 at 4:11 PM, Daniel Borkmann <daniel@iogearbox.net> wrote:
>>> On 07/01/2016 12:42 AM, Cong Wang wrote:
>>>> On Thu, Jun 30, 2016 at 12:50 PM, Daniel Borkmann <daniel@iogearbox.net>
>>>> wrote:
>>>>>
>>>>> Maybe makes sense to move skb_push_rcsum() but /also/ skb_pull_rcsum()
>>>>> to the header then? Both seem similarly small at least (could be split
>>>>> f.e into two patches then, first for the move, second for the actual
>>>>> fix).
>>>>
>>>> No objection from me. Please feel free to send a patch. ;)
>>>
>>> Shrug, I actually meant this as feedback to your patch, since you move that
>>> helper and not as a note to myself. ;)
>>
>> Interesting, my patch only moves what it needs, why does it need
>> to do more?
>
> In case you miss the context:
> http://marc.info/?l=linux-netdev&m=146730654005424&w=2
I didn't miss it. Btw, recently had a similar issue (f8ffad69c9f8b8dfb0b).
> This patch should be backported to stable too, which is another
> reason why we should keep it as small as possible.
Fair enough.
> Here, at Twitter, we already backported it to 4.1 kernel for testing.
>
> (The reason why I don't have a Fixes: tag is that I don't identify an
> offending commit to blame yet.)
next prev parent reply other threads:[~2016-07-01 9:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-30 17:15 [Patch net] net_sched: fix mirrored packets checksum Cong Wang
2016-06-30 19:50 ` Daniel Borkmann
2016-06-30 22:42 ` Cong Wang
2016-06-30 23:11 ` Daniel Borkmann
2016-06-30 23:26 ` Cong Wang
2016-06-30 23:41 ` Cong Wang
2016-07-01 9:13 ` Daniel Borkmann [this message]
2016-07-01 12:39 ` Jamal Hadi Salim
2016-07-01 20:20 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57763453.1050008@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=tom@herbertland.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.