From: Vegard Nossum <vegard.nossum@oracle.com>
To: Markus Pargmann <mpa@pengutronix.de>
Cc: Jens Axboe <axboe@fb.com>,
Quentin Casasnovas <quentin.casasnovas@oracle.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Paul Clements <paul.clements@steeleye.com>,
Pavel Machek <pavel@suse.cz>, Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH] nbd: fix race in ioctl
Date: Fri, 29 Jul 2016 12:55:01 +0200 [thread overview]
Message-ID: <579B3605.4010900@oracle.com> (raw)
In-Reply-To: <22193884.IvLroPXQMD@adelgunde>
On 05/30/2016 02:58 PM, Markus Pargmann wrote:
> Hi,
>
> On Friday 27 May 2016 12:59:35 Vegard Nossum wrote:
>> Quentin ran into this bug:
>>
>> WARNING: CPU: 64 PID: 10085 at fs/sysfs/dir.c:31 sysfs_warn_dup+0x65/0x80
[...]
>> It seems fairly obvious that device_create_file() is not being protected
>> from being run concurrently on the same nbd.
>>
>> Quentin found the following relevant commits:
>>
>> 1a2ad21 nbd: add locking to nbd_ioctl
>> 90b8f28 [PATCH] end of methods switch: remove the old ones
>> d4430d6 [PATCH] beginning of methods conversion
>> 08f8585 [PATCH] move block_device_operations to blkdev.h
>>
>> It would seem that the race was introduced in the process of moving nbd
>> from BKL to unlocked ioctls.
>>
>> By setting nbd->task_recv while the mutex is held, we can prevent other
>> processes from running concurrently (since nbd->task_recv is also checked
>> while the mutex is held).
>>
>> Reported-and-tested-by: Quentin Casasnovas <quentin.casasnovas@oracle.com>
>> Cc: Markus Pargmann <mpa@pengutronix.de>
>> Cc: Paul Clements <paul.clements@steeleye.com>
>> Cc: Pavel Machek <pavel@suse.cz>
>> Cc: Jens Axboe <axboe@fb.com>
>> Cc: Al Viro <viro@zeniv.linux.org.uk>
>> Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>
>
> Thanks, applied.
>
> Best Regards,
>
> Markus
Hi,
I didn't see this patch in the batch that went into 4.8, so I'm just
following up to make sure it doesn't get lost.
Moreover, it should also probably go into stable.
Vegard
next prev parent reply other threads:[~2016-07-29 10:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-27 10:59 [PATCH] nbd: fix race in ioctl Vegard Nossum
2016-05-30 12:58 ` Markus Pargmann
2016-07-29 10:55 ` Vegard Nossum [this message]
2016-07-29 14:13 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=579B3605.4010900@oracle.com \
--to=vegard.nossum@oracle.com \
--cc=axboe@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpa@pengutronix.de \
--cc=paul.clements@steeleye.com \
--cc=pavel@suse.cz \
--cc=quentin.casasnovas@oracle.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.