All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hou Tao <houtao1@huawei.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs_logprint: fix the transcation type string for delaylog-enabled fs
Date: Wed, 14 Sep 2016 09:02:54 +0800	[thread overview]
Message-ID: <57D8A1BE.60906@huawei.com> (raw)
In-Reply-To: <20160913070913.GG30497@dastard>

>> but the value of XFS_TRANS_CHECKPOINT had been change from 42 to 40
>> by xfs commit 61e63ec (xfs: consolidate superblock logging functions),
>> so return trans_type[type] directly will be incorrect.
>> And there is no flag for delaylog testing, so the suboptimal solution
>> is to use super v5 flag instead. For pre-v5 fs used by kernel after
>> commit 61e63ec, the result of xlog_trans_type will still be incorrect.
> 
> delaylog and v5 superblocks are completely unrelated and so this is
> incorrect.
I don't agree. As we can see from the commit log, v5 superblock was supported
after making delaylog as the only option, so v5 superblock implies delaylog.

Commit 93b8a5854f247138e401471a9c3b82ccb62ff608 makes the delaylog as the only
option, and its date is "Tue Dec 6 21:58:07 2011".

Commit 04a1e6c5b222b089c6960dfc5352002002a4355f adds the support of v5 superblock,
and its date is "Wed Apr 3 16:11:31 2013".

> And so v4 filesystems are still incorrect.
> 
Partial yes: For v4 filesystem before 3.19 (commit 61e63ec), the result
is still correct.

> IOWs, most of the logprint code is for printing log information from
> pre-delaylog kernels. IOWs, for the anyone using a 3.0+ kernel, the
> "trans type" output from xfs_logprint is completely useless
> information, so we should probably either put it behind a command
> line option or remove it completely...
I prefer the command line option over removing it. Pre-delaylog kernel
need it and some cases of xfstests rely on the transaction type string.

The command line will be used to tell whether or not it is a delaylog-enabled
xfs, and if it's a v5 superblock, it must be a delaylog-enabled xfs.

I will send a v2 patch.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2016-09-14  1:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-09  4:08 [PATCH] xfs_logprint: fix the transcation type string for delaylog-enabled fs Hou Tao
2016-09-13  7:09 ` Dave Chinner
2016-09-14  1:02   ` Hou Tao [this message]
2016-09-14  5:31     ` Dave Chinner
2016-09-14 11:00       ` Hou Tao
2016-09-14 11:31       ` [PATCH] xfs_logprint: remove the printing of transaction type Hou Tao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57D8A1BE.60906@huawei.com \
    --to=houtao1@huawei.com \
    --cc=david@fromorbit.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.