From: Jan Beulich <jbeulich@suse.com>
To: Juergen Gross <jgross@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Julien Grall <julien@xen.org>, Wei Liu <wl@xen.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
xen-devel@lists.xenproject.org,
Daniel De Graaf <dgdegra@tycho.nsa.gov>
Subject: Re: [Xen-devel] [PATCH v3 1/9] xen: add a generic way to include binary files as variables
Date: Mon, 3 Feb 2020 14:39:29 +0100 [thread overview]
Message-ID: <58b1a2e5-d63f-ba87-9f20-24b8c0e1097f@suse.com> (raw)
In-Reply-To: <20200121084330.18309-2-jgross@suse.com>
On 21.01.2020 09:43, Juergen Gross wrote:
> --- /dev/null
> +++ b/xen/tools/binfile
> @@ -0,0 +1,29 @@
> +#!/bin/sh
> +# usage: binfile [-i] <target-src.S> <binary-file> <varname>
> +# -i add to .init.rodata (default: .rodata) section
> +
> +[ "$1" = "-i" ] && {
> + shift
> + section=".init"
> +}
> +
> +target=$1
> +binsource=$2
> +varname=$3
> +
> +cat <<EOF >$target
> +#include <asm/asm_defns.h>
> +
> + .section $section.rodata, "a", %progbits
> +
> + .global $varname
> +$varname:
> + .incbin "$binsource"
> +.Lend:
> +
> + .type $varname, %object
> + .size $varname, . - $varname
I'd prefer if you used .Lend here as well.
I wonder whether, right from the beginning, there wouldn't better
be a way to also request better than byte alignment for such a
blob.
> --- a/xen/xsm/flask/Makefile
> +++ b/xen/xsm/flask/Makefile
> @@ -30,6 +30,9 @@ $(AV_H_FILES): $(AV_H_DEPEND)
> obj-bin-$(CONFIG_XSM_FLASK_POLICY) += flask-policy.o
> flask-policy.o: policy.bin
>
> +flask-policy.S: $(XEN_ROOT)/xen/tools/binfile
> + $(XEN_ROOT)/xen/tools/binfile -i $@ policy.bin xsm_flask_init_policy
Doesn't objcopy provide a means to convert a binary blob into
an ELF object containing the binary data from the input file?
If so, why involve the assembler and an intermediate file here?
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2020-02-03 13:39 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 8:43 [Xen-devel] [PATCH v3 0/9] Add hypervisor sysfs-like support Juergen Gross
2020-01-21 8:43 ` [Xen-devel] [PATCH v3 1/9] xen: add a generic way to include binary files as variables Juergen Gross
2020-02-03 13:39 ` Jan Beulich [this message]
2020-02-03 14:02 ` Jürgen Groß
2020-02-03 15:18 ` Jan Beulich
2020-01-21 8:43 ` [Xen-devel] [PATCH v3 2/9] xen: split parameter related definitions in own header file Juergen Gross
2020-01-21 13:00 ` Julien Grall
2020-01-21 13:28 ` Jürgen Groß
2020-01-21 13:31 ` Julien Grall
2020-01-22 1:34 ` Dario Faggioli
2020-01-22 11:28 ` Durrant, Paul
2020-01-22 16:49 ` Jan Beulich
2020-02-03 5:37 ` Tian, Kevin
2020-02-03 12:13 ` Jan Beulich
2020-01-21 8:43 ` [Xen-devel] [PATCH v3 3/9] docs: add feature document for Xen hypervisor sysfs-like support Juergen Gross
2020-01-21 13:14 ` Julien Grall
2020-01-21 14:17 ` Jürgen Groß
2020-02-03 10:29 ` Julien Grall
2020-01-21 8:43 ` [Xen-devel] [PATCH v3 4/9] xen: add basic hypervisor filesystem support Juergen Gross
2020-01-31 15:50 ` Wei Liu
2020-02-03 9:12 ` Jürgen Groß
2020-02-03 15:07 ` Jan Beulich
2020-02-04 6:43 ` Jürgen Groß
2020-02-04 8:48 ` Jan Beulich
2020-02-04 9:21 ` Jürgen Groß
2020-02-04 9:58 ` Jan Beulich
2020-02-04 10:48 ` Jürgen Groß
2020-02-04 11:28 ` Jan Beulich
2020-02-04 11:38 ` Jürgen Groß
2020-01-21 8:43 ` [Xen-devel] [PATCH v3 5/9] libs: add libxenhypfs Juergen Gross
2020-01-31 15:57 ` Wei Liu
2020-02-03 9:14 ` Jürgen Groß
2020-06-03 6:10 ` Olaf Hering
2020-01-21 8:43 ` [Xen-devel] [PATCH v3 6/9] tools: add xenfs tool Juergen Gross
2020-01-31 15:59 ` Wei Liu
2020-01-21 8:43 ` [Xen-devel] [PATCH v3 7/9] xen: provide version information in hypfs Juergen Gross
2020-02-03 17:02 ` Jan Beulich
2020-02-04 6:44 ` Jürgen Groß
2020-01-21 8:43 ` [Xen-devel] [PATCH v3 8/9] xen: add /buildinfo/config entry to hypervisor filesystem Juergen Gross
2020-01-21 8:43 ` [Xen-devel] [PATCH v3 9/9] xen: add runtime parameter access support to hypfs Juergen Gross
2020-01-26 22:05 ` [Xen-devel] [PATCH v3 0/9] Add hypervisor sysfs-like support Rich Persaud
2020-01-27 5:37 ` Jürgen Groß
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58b1a2e5-d63f-ba87-9f20-24b8c0e1097f@suse.com \
--to=jbeulich@suse.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=ian.jackson@eu.citrix.com \
--cc=jgross@suse.com \
--cc=julien@xen.org \
--cc=konrad.wilk@oracle.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.