From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF64FC388F2 for ; Thu, 22 Oct 2020 07:28:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6FB1E20848 for ; Thu, 22 Oct 2020 07:28:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2508551AbgJVH2j (ORCPT ); Thu, 22 Oct 2020 03:28:39 -0400 Received: from mx2.suse.de ([195.135.220.15]:55882 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2506488AbgJVH2j (ORCPT ); Thu, 22 Oct 2020 03:28:39 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 4EEC6ABB2; Thu, 22 Oct 2020 07:28:37 +0000 (UTC) Subject: Re: [PATCH 1/1] video: fbdev: fix divide error in fbcon_switch To: saeed.mirzamohammadi@oracle.com, linux-kernel@vger.kernel.org Cc: b.zolnierkie@samsung.com, akpm@linux-foundation.org, rppt@kernel.org, daniel.vetter@ffwll.ch, jani.nikula@intel.com, gustavoars@kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org References: <20201021235758.59993-1-saeed.mirzamohammadi@oracle.com> From: Thomas Zimmermann Message-ID: <59d0aaeb-f3d0-b386-a3a1-4f5f71fb68aa@suse.de> Date: Thu, 22 Oct 2020 09:28:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.2 MIME-Version: 1.0 In-Reply-To: <20201021235758.59993-1-saeed.mirzamohammadi@oracle.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi On 22.10.20 01:57, saeed.mirzamohammadi@oracle.com wrote: > From: Saeed Mirzamohammadi > > This patch fixes the issue due to: > > [ 89.572883] divide_error: 0000 [#1] SMP KASAN PTI > [ 89.572897] CPU: 3 PID: 16083 Comm: repro Not tainted 5.9.0-rc7.20200930.rc1.allarch-19-g3e32d0d.syzk #5 > [ 89.572902] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 0.5.1 01/01/2011 > [ 89.572934] RIP: 0010:cirrusfb_check_var+0x84/0x1260 > > The error happens when the pixels value is calculated before performing the sanity checks on bits_per_pixel. > A bits_per_pixel set to zero causes divide by zero error. > > This patch moves the calculation after the sanity check. > > Signed-off-by: Saeed Mirzamohammadi > Tested-by: Saeed Mirzamohammadi Looks good, thanks a lot. I'll add the patch to drm-misc-next Reviewed-by: Thomas Zimemrmann Best regards Thomas > --- > drivers/video/fbdev/cirrusfb.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/cirrusfb.c b/drivers/video/fbdev/cirrusfb.c > index 15a9ee7cd734..a7749101b094 100644 > --- a/drivers/video/fbdev/cirrusfb.c > +++ b/drivers/video/fbdev/cirrusfb.c > @@ -531,7 +531,7 @@ static int cirrusfb_check_var(struct fb_var_screeninfo *var, > { > int yres; > /* memory size in pixels */ > - unsigned pixels = info->screen_size * 8 / var->bits_per_pixel; > + unsigned int pixels; > struct cirrusfb_info *cinfo = info->par; > > switch (var->bits_per_pixel) { > @@ -573,6 +573,7 @@ static int cirrusfb_check_var(struct fb_var_screeninfo *var, > return -EINVAL; > } > > + pixels = info->screen_size * 8 / var->bits_per_pixel; > if (var->xres_virtual < var->xres) > var->xres_virtual = var->xres; > /* use highest possible virtual resolution */ > -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99738C56201 for ; Thu, 22 Oct 2020 07:28:45 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 344B4223FB for ; Thu, 22 Oct 2020 07:28:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 344B4223FB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 439546F526; Thu, 22 Oct 2020 07:28:42 +0000 (UTC) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9E6A86F526 for ; Thu, 22 Oct 2020 07:28:38 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 4EEC6ABB2; Thu, 22 Oct 2020 07:28:37 +0000 (UTC) Subject: Re: [PATCH 1/1] video: fbdev: fix divide error in fbcon_switch To: saeed.mirzamohammadi@oracle.com, linux-kernel@vger.kernel.org References: <20201021235758.59993-1-saeed.mirzamohammadi@oracle.com> From: Thomas Zimmermann Message-ID: <59d0aaeb-f3d0-b386-a3a1-4f5f71fb68aa@suse.de> Date: Thu, 22 Oct 2020 09:28:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.2 MIME-Version: 1.0 In-Reply-To: <20201021235758.59993-1-saeed.mirzamohammadi@oracle.com> Content-Language: en-US X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, b.zolnierkie@samsung.com, jani.nikula@intel.com, daniel.vetter@ffwll.ch, gustavoars@kernel.org, dri-devel@lists.freedesktop.org, akpm@linux-foundation.org, rppt@kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" SGkKCk9uIDIyLjEwLjIwIDAxOjU3LCBzYWVlZC5taXJ6YW1vaGFtbWFkaUBvcmFjbGUuY29tIHdy b3RlOgo+IEZyb206IFNhZWVkIE1pcnphbW9oYW1tYWRpIDxzYWVlZC5taXJ6YW1vaGFtbWFkaUBv cmFjbGUuY29tPgo+IAo+IFRoaXMgcGF0Y2ggZml4ZXMgdGhlIGlzc3VlIGR1ZSB0bzoKPiAKPiBb ICAgODkuNTcyODgzXSBkaXZpZGVfZXJyb3I6IDAwMDAgWyMxXSBTTVAgS0FTQU4gUFRJCj4gWyAg IDg5LjU3Mjg5N10gQ1BVOiAzIFBJRDogMTYwODMgQ29tbTogcmVwcm8gTm90IHRhaW50ZWQgNS45 LjAtcmM3LjIwMjAwOTMwLnJjMS5hbGxhcmNoLTE5LWczZTMyZDBkLnN5emsgIzUKPiBbICAgODku NTcyOTAyXSBIYXJkd2FyZSBuYW1lOiBRRU1VIFN0YW5kYXJkIFBDIChpNDQwRlggKyBQSUlYLCAx OTk2KSwgQklPUyAwLjUuMSAwMS8wMS8yMDExCj4gWyAgIDg5LjU3MjkzNF0gUklQOiAwMDEwOmNp cnJ1c2ZiX2NoZWNrX3ZhcisweDg0LzB4MTI2MAo+IAo+IFRoZSBlcnJvciBoYXBwZW5zIHdoZW4g dGhlIHBpeGVscyB2YWx1ZSBpcyBjYWxjdWxhdGVkIGJlZm9yZSBwZXJmb3JtaW5nIHRoZSBzYW5p dHkgY2hlY2tzIG9uIGJpdHNfcGVyX3BpeGVsLgo+IEEgYml0c19wZXJfcGl4ZWwgc2V0IHRvIHpl cm8gY2F1c2VzIGRpdmlkZSBieSB6ZXJvIGVycm9yLgo+IAo+IFRoaXMgcGF0Y2ggbW92ZXMgdGhl IGNhbGN1bGF0aW9uIGFmdGVyIHRoZSBzYW5pdHkgY2hlY2suCj4gCj4gU2lnbmVkLW9mZi1ieTog U2FlZWQgTWlyemFtb2hhbW1hZGkgPHNhZWVkLm1pcnphbW9oYW1tYWRpQG9yYWNsZS5jb20+Cj4g VGVzdGVkLWJ5OiBTYWVlZCBNaXJ6YW1vaGFtbWFkaSA8c2FlZWQubWlyemFtb2hhbW1hZGlAb3Jh Y2xlLmNvbT4KCkxvb2tzIGdvb2QsIHRoYW5rcyBhIGxvdC4gSSdsbCBhZGQgdGhlIHBhdGNoIHRv IGRybS1taXNjLW5leHQKClJldmlld2VkLWJ5OiBUaG9tYXMgWmltZW1ybWFubiA8dHppbW1lcm1h bm5Ac3VzZS5kZT4KCkJlc3QgcmVnYXJkcwpUaG9tYXMKCj4gLS0tCj4gIGRyaXZlcnMvdmlkZW8v ZmJkZXYvY2lycnVzZmIuYyB8IDMgKystCj4gIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMo KyksIDEgZGVsZXRpb24oLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy92aWRlby9mYmRldi9j aXJydXNmYi5jIGIvZHJpdmVycy92aWRlby9mYmRldi9jaXJydXNmYi5jCj4gaW5kZXggMTVhOWVl N2NkNzM0Li5hNzc0OTEwMWIwOTQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy92aWRlby9mYmRldi9j aXJydXNmYi5jCj4gKysrIGIvZHJpdmVycy92aWRlby9mYmRldi9jaXJydXNmYi5jCj4gQEAgLTUz MSw3ICs1MzEsNyBAQCBzdGF0aWMgaW50IGNpcnJ1c2ZiX2NoZWNrX3ZhcihzdHJ1Y3QgZmJfdmFy X3NjcmVlbmluZm8gKnZhciwKPiAgewo+ICAJaW50IHlyZXM7Cj4gIAkvKiBtZW1vcnkgc2l6ZSBp biBwaXhlbHMgKi8KPiAtCXVuc2lnbmVkIHBpeGVscyA9IGluZm8tPnNjcmVlbl9zaXplICogOCAv IHZhci0+Yml0c19wZXJfcGl4ZWw7Cj4gKwl1bnNpZ25lZCBpbnQgcGl4ZWxzOwo+ICAJc3RydWN0 IGNpcnJ1c2ZiX2luZm8gKmNpbmZvID0gaW5mby0+cGFyOwo+ICAKPiAgCXN3aXRjaCAodmFyLT5i aXRzX3Blcl9waXhlbCkgewo+IEBAIC01NzMsNiArNTczLDcgQEAgc3RhdGljIGludCBjaXJydXNm Yl9jaGVja192YXIoc3RydWN0IGZiX3Zhcl9zY3JlZW5pbmZvICp2YXIsCj4gIAkJcmV0dXJuIC1F SU5WQUw7Cj4gIAl9Cj4gIAo+ICsJcGl4ZWxzID0gaW5mby0+c2NyZWVuX3NpemUgKiA4IC8gdmFy LT5iaXRzX3Blcl9waXhlbDsKPiAgCWlmICh2YXItPnhyZXNfdmlydHVhbCA8IHZhci0+eHJlcykK PiAgCQl2YXItPnhyZXNfdmlydHVhbCA9IHZhci0+eHJlczsKPiAgCS8qIHVzZSBoaWdoZXN0IHBv c3NpYmxlIHZpcnR1YWwgcmVzb2x1dGlvbiAqLwo+IAoKLS0gClRob21hcyBaaW1tZXJtYW5uCkdy YXBoaWNzIERyaXZlciBEZXZlbG9wZXIKU1VTRSBTb2Z0d2FyZSBTb2x1dGlvbnMgR2VybWFueSBH bWJICk1heGZlbGRzdHIuIDUsIDkwNDA5IE7DvHJuYmVyZywgR2VybWFueQooSFJCIDM2ODA5LCBB RyBOw7xybmJlcmcpCkdlc2Now6RmdHNmw7xocmVyOiBGZWxpeCBJbWVuZMO2cmZmZXIKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxp bmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==