From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D046C388F9 for ; Thu, 19 Nov 2020 19:44:49 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5C6E924655 for ; Thu, 19 Nov 2020 19:44:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UWvimZ1F" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5C6E924655 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34290 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kfprK-00038O-Gt for qemu-devel@archiver.kernel.org; Thu, 19 Nov 2020 14:44:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48130) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kfpqY-0002MV-Rb for qemu-devel@nongnu.org; Thu, 19 Nov 2020 14:43:58 -0500 Received: from mail-pf1-x434.google.com ([2607:f8b0:4864:20::434]:35474) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kfpqW-0006CQ-BP for qemu-devel@nongnu.org; Thu, 19 Nov 2020 14:43:58 -0500 Received: by mail-pf1-x434.google.com with SMTP id g7so5494604pfc.2 for ; Thu, 19 Nov 2020 11:43:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=o9oZd6H2VNr1fXKrUvYaKzXLZenPKvktbYQVP3aAYlU=; b=UWvimZ1FOZmBbcPzk/ex/J7/ckMj5nQxNp+YGp2pYFyFOxkp/8PTU8gMATqcgkis4z 0X4li5+R5Ad0lSGez6HgR2lrDUvso/s2WBrJfAHQ6Jbzcl2juiad4rW0umXHcSg8prVk 8o2ZQzS0BcKXL8sjoI1l0r7xjpa/SYaH1OGHm2TzPAYEIk8SbYGssLf+q59EEy+awjVg Eul0HS0l5ATRpdq8ZcfbsYkPz4mshZk2kKGs4bM2meed0H6ayZjeiJXGYwcB1qO6p+mJ nmtHPrlur40BEHmFIkDQ/Pm70iWf+6k9ermyphH7xoP9l3BWzpjkKvzAIQ1F/DaR/2ha 0ggA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=o9oZd6H2VNr1fXKrUvYaKzXLZenPKvktbYQVP3aAYlU=; b=R3RUwuqxLI0mQ3HYqkQTrXKtV3NvjKVskXDs5LVtzUGeUMikzixxqeehf+ZFLuNhFY g346iL81W/4/JdiFTxt1n3fCxDmJtD3nBLhScGH4OqJzNXNwydkb7dyv0m0J6WZMIUy+ 6X7Ep2wvTKgKxwn9U1NvQBXpouhHPJUjdNVhljPvjsbnM04qpulQmPEnG6gsI+Anyvo8 Ba29HS2vWBHMBkyEnj2UHl0nq/KVJPRrBY/LyRScECuApLQXr68qMvdczh6jo+HyI9Z4 rZi77bbgrw8CPV5mF6+K2IQaDBCHptyqUxZTXHUGgrD/rFRldkP0zFg5A3xot69/kTRw RxbQ== X-Gm-Message-State: AOAM5331DMc6daYCoa7RCxeqZAB4JzZeQpjlLq2jyhvqeT1Qaqv8F1ed gmA/E7fk7+oKXuJQYWUnCVKbfg== X-Google-Smtp-Source: ABdhPJy8+N8E4jAx8ColvjCwR1gXWXezn/1uI2b33+h5wBdjbAJgZORS3DnH3jesoX5ZVgMWEzWFeQ== X-Received: by 2002:aa7:9694:0:b029:18b:5846:4532 with SMTP id f20-20020aa796940000b029018b58464532mr10718998pfk.41.1605815035036; Thu, 19 Nov 2020 11:43:55 -0800 (PST) Received: from [192.168.1.11] ([71.212.141.89]) by smtp.gmail.com with ESMTPSA id a24sm627260pfl.174.2020.11.19.11.43.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Nov 2020 11:43:54 -0800 (PST) Subject: Re: [RFC 05/15] target/riscv: rvb: pack two words into one register To: frank.chang@sifive.com, qemu-devel@nongnu.org, qemu-riscv@nongnu.org References: <20201118083044.13992-1-frank.chang@sifive.com> <20201118083044.13992-6-frank.chang@sifive.com> From: Richard Henderson Message-ID: <59f30d7e-dcdd-6a7b-1de9-ec07f621c9fa@linaro.org> Date: Thu, 19 Nov 2020 11:43:52 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201118083044.13992-6-frank.chang@sifive.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::434; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bastian Koppelmann , Kito Cheng , Alistair Francis , Palmer Dabbelt , Sagar Karandikar Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 11/18/20 12:29 AM, frank.chang@sifive.com wrote: > +static void gen_pack(TCGv ret, TCGv arg1, TCGv arg2) > +{ > + TCGv lower, higher; > + lower = tcg_temp_new(); > + higher = tcg_temp_new(); > + > +#ifdef TARGET_RISCV64 > + tcg_gen_ext32u_tl(lower, arg1); > + tcg_gen_shli_tl(higher, arg2, 32); > +#else > + tcg_gen_ext16u_tl(lower, arg1); > + tcg_gen_shli_tl(higher, arg2, 16); > +#endif > + tcg_gen_deposit(ret, arg1, arg2, TARGET_LONG_BITS / 2, TARGET_LONG_BITS / 2); > +static void gen_packu(TCGv ret, TCGv arg1, TCGv arg2) > +{ > + TCGv lower, higher; > + lower = tcg_temp_new(); > + higher = tcg_temp_new(); > + > +#ifdef TARGET_RISCV64 > + tcg_gen_shri_tl(lower, arg1, 32); > + tcg_gen_shri_tl(higher, arg2, 32); > + tcg_gen_shli_tl(higher, higher, 32); > +#else > + tcg_gen_shri_tl(lower, arg1, 16); > + tcg_gen_shri_tl(higher, arg2, 16); > + tcg_gen_shli_tl(higher, higher, 16); > +#endif > + > + tcg_gen_or_tl(ret, higher, lower); tcg_gen_shri_tl(t, arg1, TARGET_LONG_BITS / 2); tcg_gen_deposit_tl(ret, arg2, t, 0, TARGET_LONG_BITS / 2); > +static void gen_packh(TCGv ret, TCGv arg1, TCGv arg2) > +{ > + TCGv lower, higher; > + lower = tcg_temp_new(); > + higher = tcg_temp_new(); > + > + tcg_gen_ext8u_tl(lower, arg1); > + tcg_gen_ext8u_tl(higher, arg2); > + tcg_gen_shli_tl(higher, higher, 8); > + > + tcg_gen_or_tl(ret, higher, lower); tcg_gen_ext8u_tl(t, arg2); tcg_gen_deposit_tl(ret, arg1, t, 8, TARGET_LONG_BITS - 8); > +static void gen_packw(TCGv ret, TCGv arg1, TCGv arg2) > +{ > + TCGv lower, higher; > + lower = tcg_temp_new(); > + higher = tcg_temp_new(); > + > + tcg_gen_ext16u_tl(lower, arg1); > + tcg_gen_shli_tl(higher, arg2, 16); > + tcg_gen_or_tl(ret, higher, lower); > + > + tcg_gen_ext32s_tl(ret, ret); > + > + tcg_temp_free(lower); > + tcg_temp_free(higher); > +} tcg_gen_ext16s_i64(t, arg2); tcg_gen_deposit_i64(ret, arg1, t, 16, 48); > +static void gen_packuw(TCGv ret, TCGv arg1, TCGv arg2) > +{ > + TCGv lower, higher; > + lower = tcg_temp_new(); > + higher = tcg_temp_new(); > + > + tcg_gen_shri_tl(lower, arg1, 16); > + tcg_gen_shri_tl(higher, arg2, 16); > + tcg_gen_shli_tl(higher, higher, 16); > + tcg_gen_or_tl(ret, higher, lower); > + > + tcg_gen_ext32s_tl(ret, ret); tcg_gen_shri_i64(t, arg1, 16); tcg_gen_deposit_i64(ret, arg2, t, 0, 16); tcg_gen_ext32s_i64(ret, ret); r~ From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1kfpqa-0002Nt-79 for mharc-qemu-riscv@gnu.org; Thu, 19 Nov 2020 14:44:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48118) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kfpqY-0002Lg-8h for qemu-riscv@nongnu.org; Thu, 19 Nov 2020 14:43:58 -0500 Received: from mail-pg1-x530.google.com ([2607:f8b0:4864:20::530]:43605) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kfpqW-0006CR-BX for qemu-riscv@nongnu.org; Thu, 19 Nov 2020 14:43:57 -0500 Received: by mail-pg1-x530.google.com with SMTP id 34so5155114pgp.10 for ; Thu, 19 Nov 2020 11:43:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=o9oZd6H2VNr1fXKrUvYaKzXLZenPKvktbYQVP3aAYlU=; b=UWvimZ1FOZmBbcPzk/ex/J7/ckMj5nQxNp+YGp2pYFyFOxkp/8PTU8gMATqcgkis4z 0X4li5+R5Ad0lSGez6HgR2lrDUvso/s2WBrJfAHQ6Jbzcl2juiad4rW0umXHcSg8prVk 8o2ZQzS0BcKXL8sjoI1l0r7xjpa/SYaH1OGHm2TzPAYEIk8SbYGssLf+q59EEy+awjVg Eul0HS0l5ATRpdq8ZcfbsYkPz4mshZk2kKGs4bM2meed0H6ayZjeiJXGYwcB1qO6p+mJ nmtHPrlur40BEHmFIkDQ/Pm70iWf+6k9ermyphH7xoP9l3BWzpjkKvzAIQ1F/DaR/2ha 0ggA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=o9oZd6H2VNr1fXKrUvYaKzXLZenPKvktbYQVP3aAYlU=; b=NXdQbzrTNbzJJ7MNzW314HJdmK5vUxoF3PcYysUgxoSZmtrt/FS1ZueQH5NpF3K6a+ lOh9j6xfh3YCsBOcOcMTgMKrGRNUPoHJuT/jLlm5p/uKsAhGb8cmpT4ArH0iQwqs2f+K ygjLuyk4R6G6YUgo4XyBmAutBTh7xpvAPHkpfPqd410zXn105I4pjIG+x4a8XaVUCW19 /FhEB5DVtiijx3Dze/u5gGz5KSgLhfArqytzzzsRnKd6nmCScpEcumH2he6lqaxB4pda +1U3tEz+mc/4wHM/9/xFvL/Cd78Bd7r+4+s9AVtklLeM7BZaZqNACWHsWWnDDjaDrCEh ke1A== X-Gm-Message-State: AOAM532OV6KDP/vCmS1xKqWpPGtfaXfu8x0nX3xmS5NbSrW1ruqtqdGa Wp3I129DJjRP9+fWmYseaLzFlA== X-Google-Smtp-Source: ABdhPJy8+N8E4jAx8ColvjCwR1gXWXezn/1uI2b33+h5wBdjbAJgZORS3DnH3jesoX5ZVgMWEzWFeQ== X-Received: by 2002:aa7:9694:0:b029:18b:5846:4532 with SMTP id f20-20020aa796940000b029018b58464532mr10718998pfk.41.1605815035036; Thu, 19 Nov 2020 11:43:55 -0800 (PST) Received: from [192.168.1.11] ([71.212.141.89]) by smtp.gmail.com with ESMTPSA id a24sm627260pfl.174.2020.11.19.11.43.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Nov 2020 11:43:54 -0800 (PST) Subject: Re: [RFC 05/15] target/riscv: rvb: pack two words into one register To: frank.chang@sifive.com, qemu-devel@nongnu.org, qemu-riscv@nongnu.org Cc: Sagar Karandikar , Bastian Koppelmann , Alistair Francis , Palmer Dabbelt , Kito Cheng References: <20201118083044.13992-1-frank.chang@sifive.com> <20201118083044.13992-6-frank.chang@sifive.com> From: Richard Henderson Message-ID: <59f30d7e-dcdd-6a7b-1de9-ec07f621c9fa@linaro.org> Date: Thu, 19 Nov 2020 11:43:52 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201118083044.13992-6-frank.chang@sifive.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::530; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x530.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Nov 2020 19:43:58 -0000 On 11/18/20 12:29 AM, frank.chang@sifive.com wrote: > +static void gen_pack(TCGv ret, TCGv arg1, TCGv arg2) > +{ > + TCGv lower, higher; > + lower = tcg_temp_new(); > + higher = tcg_temp_new(); > + > +#ifdef TARGET_RISCV64 > + tcg_gen_ext32u_tl(lower, arg1); > + tcg_gen_shli_tl(higher, arg2, 32); > +#else > + tcg_gen_ext16u_tl(lower, arg1); > + tcg_gen_shli_tl(higher, arg2, 16); > +#endif > + tcg_gen_deposit(ret, arg1, arg2, TARGET_LONG_BITS / 2, TARGET_LONG_BITS / 2); > +static void gen_packu(TCGv ret, TCGv arg1, TCGv arg2) > +{ > + TCGv lower, higher; > + lower = tcg_temp_new(); > + higher = tcg_temp_new(); > + > +#ifdef TARGET_RISCV64 > + tcg_gen_shri_tl(lower, arg1, 32); > + tcg_gen_shri_tl(higher, arg2, 32); > + tcg_gen_shli_tl(higher, higher, 32); > +#else > + tcg_gen_shri_tl(lower, arg1, 16); > + tcg_gen_shri_tl(higher, arg2, 16); > + tcg_gen_shli_tl(higher, higher, 16); > +#endif > + > + tcg_gen_or_tl(ret, higher, lower); tcg_gen_shri_tl(t, arg1, TARGET_LONG_BITS / 2); tcg_gen_deposit_tl(ret, arg2, t, 0, TARGET_LONG_BITS / 2); > +static void gen_packh(TCGv ret, TCGv arg1, TCGv arg2) > +{ > + TCGv lower, higher; > + lower = tcg_temp_new(); > + higher = tcg_temp_new(); > + > + tcg_gen_ext8u_tl(lower, arg1); > + tcg_gen_ext8u_tl(higher, arg2); > + tcg_gen_shli_tl(higher, higher, 8); > + > + tcg_gen_or_tl(ret, higher, lower); tcg_gen_ext8u_tl(t, arg2); tcg_gen_deposit_tl(ret, arg1, t, 8, TARGET_LONG_BITS - 8); > +static void gen_packw(TCGv ret, TCGv arg1, TCGv arg2) > +{ > + TCGv lower, higher; > + lower = tcg_temp_new(); > + higher = tcg_temp_new(); > + > + tcg_gen_ext16u_tl(lower, arg1); > + tcg_gen_shli_tl(higher, arg2, 16); > + tcg_gen_or_tl(ret, higher, lower); > + > + tcg_gen_ext32s_tl(ret, ret); > + > + tcg_temp_free(lower); > + tcg_temp_free(higher); > +} tcg_gen_ext16s_i64(t, arg2); tcg_gen_deposit_i64(ret, arg1, t, 16, 48); > +static void gen_packuw(TCGv ret, TCGv arg1, TCGv arg2) > +{ > + TCGv lower, higher; > + lower = tcg_temp_new(); > + higher = tcg_temp_new(); > + > + tcg_gen_shri_tl(lower, arg1, 16); > + tcg_gen_shri_tl(higher, arg2, 16); > + tcg_gen_shli_tl(higher, higher, 16); > + tcg_gen_or_tl(ret, higher, lower); > + > + tcg_gen_ext32s_tl(ret, ret); tcg_gen_shri_i64(t, arg1, 16); tcg_gen_deposit_i64(ret, arg2, t, 0, 16); tcg_gen_ext32s_i64(ret, ret); r~