From: "Jan Beulich" <JBeulich@suse.com>
To: Juergen Gross <jgross@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
Julien Grall <julien.grall@arm.com>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] shim: don't let build modify shim.config
Date: Thu, 19 Apr 2018 04:47:33 -0600 [thread overview]
Message-ID: <5AD873C502000078001BCA14@prv1-mh.provo.novell.com> (raw)
In-Reply-To: <20180419103024.14731-1-jgross@suse.com>
>>> On 19.04.18 at 12:30, <jgross@suse.com> wrote:
> --- a/tools/firmware/xen-dir/Makefile
> +++ b/tools/firmware/xen-dir/Makefile
> @@ -41,21 +41,22 @@ linkfarm.stamp: $(DEP_DIRS) $(DEP_FILES) FORCE
> $(D): linkfarm.stamp
> $(MAKE) -C $(D)/xen distclean
>
> -.PHONY: shim-%config
> -shim-%config: $(D) FORCE
> - $(MAKE) -C $(D)/xen $*config \
I think there was a reason for the % and $*.
> +xen-shim.config: shim.config
> + cp $< $@
Why not copy it to where it actually belong - xen/.config?
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-04-19 10:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-19 10:30 [PATCH] shim: don't let build modify shim.config Juergen Gross
2018-04-19 10:47 ` Jan Beulich [this message]
[not found] ` <5AD873C502000078001BCA14@suse.com>
2018-04-19 11:01 ` Juergen Gross
2018-04-19 14:54 ` Wei Liu
2018-04-19 16:14 ` Andrew Cooper
2018-04-19 16:22 ` Wei Liu
2018-04-20 9:28 ` Roger Pau Monné
2018-04-20 9:33 ` Andrew Cooper
2018-04-20 9:47 ` Juergen Gross
2018-04-20 6:40 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5AD873C502000078001BCA14@prv1-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=jgross@suse.com \
--cc=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.